Conversation
updated `tests/ui/README.md`and `src/tools/tidy/src/issues.txt`
To fix passing the toolstate token to `publish_toolstate.sh`.
As specified by MCP: rust-lang/compiler-team#920 Resolves rust-lang#148309
…r test steps This is redundant and wasteful.
Emscripten: Turn wasm-eh on by default As specified by [MCP](rust-lang/compiler-team#920) Resolves rust-lang#148309 Resolves rust-lang#112195
…mann Recover on misspelled item keyword the title says everything. first commit adds a test that shows how current `main` behaves on misspelled item keyword. second commit adds the recovery, which allows to emit many more errors.
Tidying up UI tests [6/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge. part of rust-lang#133895 removed directory `tests/ui/trait-objects`, `tests/ui/for`, `tests/ui/warnings` `trait-objects` -> `traits/object` `for` -> `for-loop-while` (except `for/issue-20605.rs` test. this relocated to `traits/dyn-iterator-deref-in-for-loop.rs`) `warnings` -> `resolve`, `entry-point` r? Kivooeo
…r=jdonszelmann Move attribute safety checking to attribute parsing This PR moves attribute safety checking to be done during attribute parsing. The `cfg` and `cfg_attr` attribute no longer need special-cased safety checking, yay! This PR is a part 1 of 2, in the second part I'd like to define attribute safety in the attribute parsers rather than getting the information from BUILTIN_ATTRIBUTE_MAP, but to keep PRs reviewable lets do that separately. Fixes rust-lang#148453 by reordering the diagnostics. The "cannot find attribute" diagnostic now appears first, but both diagnostics still appear. r? `@jdonszelmann`
powf, powi: point out SNaN non-determinism The non-determinism has two sources: - LLVM reserves the right to treat signaling NaNs as-if they were quiet, so it may fold `powf(x, 0)` to `1` even if `x` might be a signaling NaN. - Some libm `pow` implementations (e.g. the one in musl) don't implement the signaling NaN special-case. See https://rust.godbolt.org/z/chsbv5v4d. Cc `@tgross35` `@Amanieu`
Use branch name instead of HEAD when unshallowing Fixes a regression with the beta channel that was discovered in rust-lang#149572. r? `@cuviper`
… r=ehuss Apply the `bors` environment also to the `outcome` job To fix passing the toolstate token to `publish_toolstate.sh`. Found in https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/TOOLSTATE_REPO_ACCESS_TOKEN/with/561580948. r? ehuss
… r=Zalathar Don't require a normal tool build of clippy/rustfmt when running their test steps This is redundant and wasteful. Noticed in rust-lang#147372 (comment).
…zelmann Point to the item that is incorrectly annotated with `#[diagnostic::on_const]` close rust-lang#149606 r? estebank
|
@bors try jobs=x86_64-msvc-1,i686-msvc-1,x86_64-mingw-1,test-various,armhf-gnu,aarch64-apple,x86_64-gnu-llvm-20-3 |
This comment has been minimized.
This comment has been minimized.
Rollup of 9 pull requests try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple try-job: x86_64-gnu-llvm-20-3
|
@bors r+ rollup=never p=5 |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: b33119ffdd In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing b33119f (parent) -> 3e2dbcd (this PR) Test differencesShow 654 test diffsStage 1
Stage 2
Additionally, 594 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 3e2dbcdd3a4fc1b5aabfcd0c401c093734e72df2 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (3e2dbcd): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.9%, secondary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 470.287s -> 470.045s (-0.05%) |
|
@rust-timer build 1aeb857 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (1aeb857): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.5%, secondary -0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 3.6%, secondary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 470.287s -> 469.953s (-0.07%) |
Successful merges:
borsenvironment also to theoutcomejob #149612 (Apply theborsenvironment also to theoutcomejob)#[diagnostic::on_const]#149627 (Point to the item that is incorrectly annotated with#[diagnostic::on_const])r? @ghost
@rustbot modify labels: rollup
Create a similar rollup