Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
jnodorp
force-pushed
the
clarify-utf16-errors
branch
from
0517c75 to
ccbfc0b
Compare
This comment has been minimized.
This comment has been minimized.
jnodorp
force-pushed
the
clarify-utf16-errors
branch
from
ccbfc0b to
1cc01e7
Compare
This comment has been minimized.
This comment has been minimized.
jnodorp
force-pushed
the
clarify-utf16-errors
branch
2 times, most recently
from
2279962 to
78830b4
Compare
This comment has been minimized.
This comment has been minimized.
bjorn3
reviewed
Dec 8, 2025
jnodorp
force-pushed
the
clarify-utf16-errors
branch
from
78830b4 to
693dc90
Compare
Collaborator
|
☔ The latest upstream changes (presumably #149836) made this pull request unmergeable. Please resolve the merge conflicts. |
jnodorp
force-pushed
the
clarify-utf16-errors
branch
from
693dc90 to
8fedc80
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
jnodorp
force-pushed
the
clarify-utf16-errors
branch
from
8fedc80 to
5ff0ec6
Compare
joboet
approved these changes
Dec 16, 2025
Member
|
Implementation-wise this looks fine (modulo the nit). I'll reassign this to libs-api though, in case they have comments... r? libs-api |
rustbot
added
the
T-libs-api
Co-authored-by: Jonas Böttiger <jonasboettiger@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix UTF-16 error messages as suggested in #116258.