Another attempt at Vec::extend_with via iter::repeat_n#149751
Another attempt at Vec::extend_with via iter::repeat_n#149751scottmcm wants to merge 1 commit intorust-lang:mainfrom
Vec::extend_with via iter::repeat_n#149751Conversation
This time, try specializing `RepeatN::fold` instead, since for `TrivialClone` it can just copy it every time.
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Another attempt at `Vec::extend_with` via `iter::repeat_n`
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (c311241): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.9%, secondary -3.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 3.8%, secondary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary -0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 470.113s -> 473.879s (0.80%) |
This time, try specializing
RepeatN::foldinstead, since forTrivialCloneit can just copy it every time.Since this hasn't gone well in perf the last few times, start in draft and with
r? ghost
(Inspired by #133662 and #104596 but rather different from both of those)