try enabling linker-messages by default again#149937
Open
jyn514 wants to merge 5 commits intorust-lang:mainfrom
Open
try enabling linker-messages by default again#149937jyn514 wants to merge 5 commits intorust-lang:mainfrom
linker-messages by default again#149937jyn514 wants to merge 5 commits intorust-lang:mainfrom
Conversation
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
@bors try |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 13, 2025
try enabling `linker-messages` by default again
This comment has been minimized.
This comment has been minimized.
Contributor
Member
|
@craterbot build-only |
Collaborator
|
🚨 Error: failed to parse the command 🆘 If you have any trouble with Crater please ask in t-infra on Zulip |
Member
|
@craterbot run mode=build-only |
Collaborator
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
craterbot
added
S-waiting-on-crater
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang#149937. cc `@jieyouxu` `@Oneirical`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang#149937. cc ``@jieyouxu`` ``@Oneirical``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang#149937. cc ```@jieyouxu``` ```@Oneirical```
Collaborator
|
☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts. |
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 18, 2025
don't use no_main and no_core to test IBT The previous test was quite fragile and depended on a bunch of internal features. Simplify it. Split out of rust-lang/rust#149937. cc ```@jieyouxu``` ```@Oneirical```
Collaborator
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
Collaborator
|
🎉 Experiment
Footnotes
|
|
This comment has been minimized.
This comment has been minimized.
mati865
reviewed
Feb 4, 2026
Comment on lines
+687
to
+693
| fn is_windows_gnu_ld(sess: &Session) -> bool { | ||
| let (_, flavor) = linker_and_flavor(sess); | ||
| sess.target.is_like_windows | ||
| && !sess.target.is_like_msvc | ||
| && matches!(flavor, LinkerFlavor::Gnu(_, Lld::No)) | ||
| } |
Member
There was a problem hiding this comment.
This will match windows-gnu and windows-gnullvm targets. Probably doesn't matter enough to justify adding && sess.target.abi != Abi::Llvm there.
| @@ -0,0 +1,5 @@ | |||
| //@ only-windows-gnu | |||
Member
There was a problem hiding this comment.
Wait, this still happens on CI?
It should not since Sep 9, 2024: #119229 (comment)
Regardless of the CI, having a test that fails only with some host tools version doesn't seem right.
Member
Author
There was a problem hiding this comment.
um. hm. possibly this only fails for me locally because I have an old version of windows-gnu? I'm not sure how to test it in CI ...
Member
Author
There was a problem hiding this comment.
maybe instead I could add a fake-linker script that prints exactly the error message I see locally? does that seem reasonable?
Member
There was a problem hiding this comment.
Yeah, that's very likely. Does your ld -v show version older than 2.40?
Fake linker sounds fine for me, although that probably would have to be a batch script or powershell one since this test runs on Windows.
@bors try jobs=x86_64-mingw-1,x86_64-mingw-2
Member
There was a problem hiding this comment.
We can test it on CI after you resolve conflicts.
@bors delegate
Member
Author
There was a problem hiding this comment.
you were exactly right, this did in fact fail in CI lol. i pushed a commit using a fake linker and a powershell script.
Member
|
@rustbot author |
rustbot
added
S-waiting-on-author
Member
Author
|
@rustbot review |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Contributor
Member
Author
|
@rustbot author |
rustbot
added
S-waiting-on-author
- Hide common linker output behind `linker-info` - Add tests - Account for different capitalization on windows-gnu when removing "warning" prefix - Add some more comments - Add macOS deployment-target test - Ignore linker warnings from trying to statically link glibc I don't know what's going on in `nofile-limit.rs` but I want no part of it.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors try jobs=x86_64-mingw-1,x86_64-mingw-2 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
try enabling `linker-messages` by default again try-job: x86_64-mingw-1 try-job: x86_64-mingw-2
rustbot
added
A-tidy
Contributor
|
💔 Test for 02e4e25 failed: CI. Failed job:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
😌 |
Contributor
|
☔ The latest upstream changes (presumably #152239) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linker-infofromlinker-messageslinker-messageswarn-by-default; keeplinker-infodeny-by-defaultHelps with #136096.