Refactor function names of `rustc_ast_lowering` by reddevilmidzy · Pull Request #150122 · rust-lang/rust

reddevilmidzy · 2025-12-18T07:10:54Z

I'll rebase after #149114 is merged.

Would it be better to change lower_const_path_to_const_arg → lower_const_path_to_const_arg_and_intern,
lower_array_length_to_const_arg → lower_array_length_to_const_arg_and_intern?

r? @lcnr

lcnr

thx, gonna mark this on blocked on #149114

View changes since this review

lcnr · 2025-12-18T10:21:33Z

compiler/rustc_ast_lowering/src/block.rs

        let super_ = l.super_.map(|span| self.lower_span(span));
        let ty = l.ty.as_ref().map(|t| {
-            self.lower_ty(t, self.impl_trait_in_bindings_ctxt(ImplTraitPosition::Variable))
+            self.lower_ty_and_intern(


actually, self.lower_ty_and_alloc might be better, we're not really interning here

Oh, I understand. lower_anon_const_to_const_arg_and_alloc was also reflected

reddevilmidzy · 2025-12-18T11:21:24Z

@rustbot label -A-LLVM

reddevilmidzy · 2025-12-24T07:57:52Z

#149114 merged and rebase completed.

@rustbot ready

lcnr · 2026-01-05T15:10:06Z

cc @BoxyUwU

@bors r+ rollup

bors · 2026-01-05T15:10:09Z

📌 Commit 598d01b has been approved by lcnr

It is now in the queue for this repository.

Refactor function names of `rustc_ast_lowering` close: rust-lang#150062 I'll rebase after rust-lang#149114 is merged. Would it be better to change `lower_const_path_to_const_arg` → `lower_const_path_to_const_arg_and_intern`, `lower_array_length_to_const_arg` → `lower_array_length_to_const_arg_and_intern`? r? `@lcnr`

matthiaskrgr · 2026-01-05T19:49:00Z

@bors r-
#150715 (comment)
probably needs rebase

`lower_ty`

`lower_anon_const_to_const_arg_direct` to `lower_anon_const_to_const_arg_and_alloc` and `lower_anon_const_to_const_arg`

rustbot · 2026-01-06T00:45:30Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

reddevilmidzy · 2026-01-06T02:24:57Z

@rustbot ready

lcnr · 2026-01-06T10:10:07Z

@bors r+ rollup

bors · 2026-01-06T10:10:10Z

📌 Commit 56cb5d5 has been approved by lcnr

It is now in the queue for this repository.

Refactor function names of `rustc_ast_lowering` close: rust-lang#150062 I'll rebase after rust-lang#149114 is merged. Would it be better to change `lower_const_path_to_const_arg` → `lower_const_path_to_const_arg_and_intern`, `lower_array_length_to_const_arg` → `lower_array_length_to_const_arg_and_intern`? r? `@lcnr`

…uwer Rollup of 11 pull requests Successful merges: - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items) - #148339 (naked functions: emit `.private_extern` on macos) - #149880 (rustc_codegen_llvm: update alignment for double on AIX) - #150122 (Refactor function names of `rustc_ast_lowering`) - #150412 (use PIDFD_GET_INFO ioctl when available) - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`) - #150695 (MGCA: pretty printing for struct expressions and tuple calls ) - #150698 (Improve comment clarity in candidate_may_shadow) - #150706 (Update wasm-component-ld) - #150707 (Fix ICE when transmute Assume field is invalid) - #150708 (Enable merge queue in new bors) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 11 pull requests Successful merges: - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items) - #148339 (naked functions: emit `.private_extern` on macos) - #149880 (rustc_codegen_llvm: update alignment for double on AIX) - #150122 (Refactor function names of `rustc_ast_lowering`) - #150412 (use PIDFD_GET_INFO ioctl when available) - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`) - #150695 (MGCA: pretty printing for struct expressions and tuple calls ) - #150698 (Improve comment clarity in candidate_may_shadow) - #150706 (Update wasm-component-ld) - #150707 (Fix ICE when transmute Assume field is invalid) - #150708 (Enable merge queue in new bors) r? `@ghost` `@rustbot` modify labels: rollup

…uwer Rollup of 10 pull requests Successful merges: - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items) - #149880 (rustc_codegen_llvm: update alignment for double on AIX) - #150122 (Refactor function names of `rustc_ast_lowering`) - #150412 (use PIDFD_GET_INFO ioctl when available) - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`) - #150695 (MGCA: pretty printing for struct expressions and tuple calls ) - #150698 (Improve comment clarity in candidate_may_shadow) - #150706 (Update wasm-component-ld) - #150707 (Fix ICE when transmute Assume field is invalid) - #150708 (Enable merge queue in new bors) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150122 - reddevilmidzy:refactor, r=lcnr Refactor function names of `rustc_ast_lowering` close: #150062 I'll rebase after #149114 is merged. Would it be better to change `lower_const_path_to_const_arg` → `lower_const_path_to_const_arg_and_intern`, `lower_array_length_to_const_arg` → `lower_array_length_to_const_arg_and_intern`? r? ``@lcnr``

rustbot assigned lcnr Dec 18, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 18, 2025

lcnr reviewed Dec 18, 2025

View reviewed changes

lcnr added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2025

reddevilmidzy force-pushed the refactor branch from 7c13df6 to 5d67210 Compare December 18, 2025 11:13

rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Dec 18, 2025

This comment has been minimized.

Sign in to view

reddevilmidzy force-pushed the refactor branch from 5d67210 to 5e669d8 Compare December 18, 2025 11:16

This comment has been minimized.

Sign in to view

rustbot removed the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Dec 18, 2025

This comment has been minimized.

Sign in to view

reddevilmidzy force-pushed the refactor branch from 5e669d8 to 60c8075 Compare December 24, 2025 06:21

This comment has been minimized.

Sign in to view

reddevilmidzy force-pushed the refactor branch from 60c8075 to 598d01b Compare December 24, 2025 06:34

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Dec 24, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2026

JonathanBrouwer mentioned this pull request Jan 5, 2026

Rollup of 4 pull requests #150715

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 5, 2026

reddevilmidzy added 2 commits January 6, 2026 09:19

rename the lower_ty and lower_ty_direct to lower_ty_and_alloc and

b0a581d

`lower_ty`

rename the lower_anon_const_to_const_arg and

56cb5d5

`lower_anon_const_to_const_arg_direct` to `lower_anon_const_to_const_arg_and_alloc` and `lower_anon_const_to_const_arg`

reddevilmidzy force-pushed the refactor branch from 598d01b to 56cb5d5 Compare January 6, 2026 00:45

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 6, 2026

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2026

JonathanBrouwer mentioned this pull request Jan 6, 2026

Rollup of 11 pull requests #150724

Closed

JonathanBrouwer mentioned this pull request Jan 6, 2026

Rollup of 10 pull requests #150726

Merged

bors merged commit 0a7a92d into rust-lang:main Jan 6, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 6, 2026

reddevilmidzy deleted the refactor branch January 7, 2026 03:23

github-actions bot mentioned this pull request Jan 27, 2026

Toolchain upgrade to nightly-2026-01-30 flux-rs/flux#1345

Draft

Uh oh!

Conversation

reddevilmidzy commented Dec 18, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lcnr left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

reddevilmidzy Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

reddevilmidzy commented Dec 18, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

reddevilmidzy commented Dec 24, 2025

Uh oh!

lcnr commented Jan 5, 2026

Uh oh!

bors commented Jan 5, 2026

Uh oh!

matthiaskrgr commented Jan 5, 2026

Uh oh!

rustbot commented Jan 6, 2026

Uh oh!

reddevilmidzy commented Jan 6, 2026

Uh oh!

lcnr commented Jan 6, 2026

Uh oh!

bors commented Jan 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

reddevilmidzy commented Dec 18, 2025 •

edited by rustbot

Loading

lcnr left a comment •

edited by rustbot

Loading