Merged
Conversation
cg_llvm: More preparation for moving FFI bindings to `rustc_llvm` - Sequel to rust-lang#147327 - Motivated by rust-lang#142897 --- This is another batch of adjustments to code that would otherwise interfere with moving FFI bindings out of `rustc_codegen_llvm` and into `rustc_llvm`.
…test, r=chenyukang Add regression test for rust-lang#120189 This PR adds regression tests for rust-lang#120189. I added tests to verify vectorization of loops inside closures.
…_query_information, r=JonathanBrouwer Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers r? ``@JonathanBrouwer``
rustbot
added
A-attributes
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Dec 19, 2025
Rollup of 3 pull requests Successful merges: - #147430 (cg_llvm: More preparation for moving FFI bindings to `rustc_llvm`) - #149815 (Add regression test for #120189) - #150127 (Port `#[rustc_lint_untracked_query_information]` and `#[rustc_lint_diagnostics]` to using attribute parsers) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 07a5b02a2d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 07a5b02 (parent) -> 0f0d850 (this PR) Test differencesShow 429 test diffsStage 0
Stage 1
(and 329 additional test diffs) Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0f0d850e9146f53b16fb1c6a56ed2f821962ff94 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (0f0d850): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.5%, secondary -2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 481.939s -> 479.055s (-0.60%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_llvm#147430 (cg_llvm: More preparation for moving FFI bindings torustc_llvm)#[rustc_lint_untracked_query_information]and#[rustc_lint_diagnostics]to using attribute parsers #150127 (Port#[rustc_lint_untracked_query_information]and#[rustc_lint_diagnostics]to using attribute parsers)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup