Merged
Conversation
add `vpdpbusd` avx512 intrinsic
This commit adds basic support for FFI callbacks by registering a shim function via libffi. This shim function currently only exits with an error. The main motivation for this is to prevent miri segfaulting as described in [4639](rust-lang/miri#4639). In the future miri could try to continue execution in the registered callback, although as far as I understand Ralf that is no easy problem.
Basic support for FFI callbacks (at least stop segfaulting and report a proper error)
…r vec::IntoIter with any Allocator, not just Global
native lib support: support returning structs
android: get the entire test suite to pass
Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below. This hurts code readability because there is `ToOwned` alongside its impl directly below it. Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.
This updates the rust-version file to e8f3cfc.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: e8f3cfc Filtered ref: 5837f859c413e836e4fd1eb4985632c2f62c7db0 Upstream diff: rust-lang/rust@7fefa09...e8f3cfc This merge was created using https://github.com/rust-lang/josh-sync.
Automatic Rustup
…and data operations
…ests/libc-pipe Refactor libc pipe tests to use utility functions for error handling and data operations
This should make it easier to keep track of where the types/spans came from.
This updates the rust-version file to f57b9e6.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: f57b9e6 Filtered ref: dd835ad11d6c5cea520a087bb620e3643e2dbf0f Upstream diff: rust-lang/rust@e8f3cfc...f57b9e6 This merge was created using https://github.com/rust-lang/josh-sync.
Automatic Rustup
add check_only feature for faster check builds
…gression-test, r=davidtwco test: add regression cases for valtree hashing ICE This PR extends the existing regression test `printing_valtrees_supports_non_values.rs` to cover cases that previously caused an ICE in `const_kind.rs` due to hashing inference variables. It specifically adds: A case where an associated constant is used without the required trait bound. The `0: _` case as suggested in [Here](rust-lang#150409 (comment)) Fixes rust-lang#150409
…cator, r=jhpratt make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global` These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`. (extra context: `VecDeque::extend_front` is unstable and tracked by rust-lang#146975)
…ulacrum alloc: Move Cow impl to existing ones Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below. This hurts code readability because there is `ToOwned` alongside its impl directly below it. Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.
THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for rust-lang#150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.
miri subtree update Subtree update of `miri` to rust-lang/miri@5d149f2. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 5afdf5d8c0 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5afdf5d (parent) -> e29fcf4 (this PR) Test differencesShow 16 test diffs16 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e29fcf45e4ae686d77b490bf07320f0d3a2cf35f --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (e29fcf4): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 475.624s -> 475.648s (0.01%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Vec::extendandVecDeque::extend_frontwork for vec::IntoIter with anyAllocator, not justGlobal#150597 (make specialization ofVec::extendandVecDeque::extend_frontwork for vec::IntoIter with anyAllocator, not justGlobal)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup