resolve: Refactor away the side table `decl_parent_modules` by petrochenkov · Pull Request #150877 · rust-lang/rust

petrochenkov · 2026-01-09T14:14:11Z

Instead keep parent modules in DeclData itself.
Follow up to #150445.

petrochenkov · 2026-01-10T15:38:53Z

I think I'll remove the second commit after rebasing.
The new logic is also not always correct, and it's not strictly more correct than the old one, so let's just keep the current logic.
I need to think what exactly conditions we want there.
Upd: second commit removed.

nnethercote · 2026-01-12T22:41:11Z

@bors r+

rust-bors · 2026-01-12T22:41:14Z

📌 Commit 381c425 has been approved by nnethercote

It is now in the queue for this repository.

jieyouxu · 2026-01-13T01:07:58Z

(Unfortunately has merge conflicts)
@bors r-

rust-bors · 2026-01-13T01:08:02Z

Commit 381c425 has been unapproved.

petrochenkov · 2026-01-13T07:32:21Z

@bors r=nnethercote

rust-bors · 2026-01-13T07:32:24Z

📌 Commit cd95781 has been approved by nnethercote

It is now in the queue for this repository.

@nnethercote

resolve: Refactor away the side table `decl_parent_modules` Instead keep parent modules in `DeclData` itself. Follow up to rust-lang#150445. r? @nnethercote

Instead keep parent modules in `DeclData` itself

rustbot · 2026-01-13T18:19:59Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-01-13T18:20:16Z

@bors r=nnethercote

rust-bors · 2026-01-13T18:20:21Z

📌 Commit c4820e6 has been approved by nnethercote

It is now in the queue for this repository.

@nnethercote

resolve: Refactor away the side table `decl_parent_modules` Instead keep parent modules in `DeclData` itself. Follow up to rust-lang#150445. r? @nnethercote

@ghost

…uwer Rollup of 12 pull requests Successful merges: - #149408 (refactor: remove Ord bound from BinaryHeap::new etc) - #150406 (Change some `matches!(.., .. if ..)` with let-chains) - #150723 (std: move `errno` and related functions into `sys::io`) - #150877 (resolve: Refactor away the side table `decl_parent_modules`) - #150902 (Update to_uppercase docs to avoid ß->SS example) - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg) - #151034 (std: Change UEFI env vars to volatile storage) - #151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`) - #151067 (Avoid should-fail in two ui tests and a codegen-llvm test) - #151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support) - #151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake) - #151096 (Remove `Deref`/`DerefMut` impl for `Providers`.) Failed merges: - #150939 (resolve: Relax some asserts in glob overwriting and add tests) r? @ghost

@ghost

…uwer Rollup of 11 pull requests Successful merges: - #149408 (refactor: remove Ord bound from BinaryHeap::new etc) - #150406 (Change some `matches!(.., .. if ..)` with let-chains) - #150723 (std: move `errno` and related functions into `sys::io`) - #150877 (resolve: Refactor away the side table `decl_parent_modules`) - #150902 (Update to_uppercase docs to avoid ß->SS example) - #151034 (std: Change UEFI env vars to volatile storage) - #151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`) - #151067 (Avoid should-fail in two ui tests and a codegen-llvm test) - #151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support) - #151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake) - #151096 (Remove `Deref`/`DerefMut` impl for `Providers`.) Failed merges: - #150939 (resolve: Relax some asserts in glob overwriting and add tests) r? @ghost

@nnethercote

Rollup merge of #150877 - declmod, r=nnethercote resolve: Refactor away the side table `decl_parent_modules` Instead keep parent modules in `DeclData` itself. Follow up to #150445. r? @nnethercote

@ghost

…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#149408 (refactor: remove Ord bound from BinaryHeap::new etc) - rust-lang/rust#150406 (Change some `matches!(.., .. if ..)` with let-chains) - rust-lang/rust#150723 (std: move `errno` and related functions into `sys::io`) - rust-lang/rust#150877 (resolve: Refactor away the side table `decl_parent_modules`) - rust-lang/rust#150902 (Update to_uppercase docs to avoid ß->SS example) - rust-lang/rust#151034 (std: Change UEFI env vars to volatile storage) - rust-lang/rust#151036 (Better handle when trying to iterate on a `Range` of a type that isn't `Step`) - rust-lang/rust#151067 (Avoid should-fail in two ui tests and a codegen-llvm test) - rust-lang/rust#151072 (also handle ENOTTY ioctl errors when checking pidfd -> pid support) - rust-lang/rust#151077 (Recognize potential `impl<const N: usize>` to `impl<N>` mistake) - rust-lang/rust#151096 (Remove `Deref`/`DerefMut` impl for `Providers`.) Failed merges: - rust-lang/rust#150939 (resolve: Relax some asserts in glob overwriting and add tests) r? @ghost

rustbot assigned nnethercote Jan 9, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 9, 2026

This comment was marked as resolved.

Sign in to view

petrochenkov force-pushed the declmod branch from 5ed3308 to 381c425 Compare January 11, 2026 09:59

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

nnethercote approved these changes Jan 12, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2026

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 13, 2026

petrochenkov force-pushed the declmod branch from 381c425 to cd95781 Compare January 13, 2026 07:31

This comment has been minimized.

Sign in to view

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 13, 2026

rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 13, 2026

JonathanBrouwer mentioned this pull request Jan 13, 2026

Rollup of 14 pull requests #151062

Closed

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 13, 2026

This comment was marked as resolved.

Sign in to view

resolve: Refactor away the side table decl_parent_modules

c4820e6

Instead keep parent modules in `DeclData` itself

petrochenkov force-pushed the declmod branch from cd95781 to c4820e6 Compare January 13, 2026 18:19

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 13, 2026

JonathanBrouwer mentioned this pull request Jan 14, 2026

Rollup of 12 pull requests #151104

Closed

JonathanBrouwer mentioned this pull request Jan 14, 2026

Rollup of 11 pull requests #151107

Merged

rust-bors bot merged commit 129f88c into rust-lang:main Jan 14, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 14, 2026

github-actions bot mentioned this pull request Jan 28, 2026

Toolchain upgrade to nightly-2026-01-30 flux-rs/flux#1345

Draft

Uh oh!

Conversation

petrochenkov commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

petrochenkov commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

nnethercote commented Jan 12, 2026

Uh oh!

rust-bors bot commented Jan 12, 2026

Uh oh!

jieyouxu commented Jan 13, 2026

Uh oh!

rust-bors bot commented Jan 13, 2026

Uh oh!

This comment has been minimized.

petrochenkov commented Jan 13, 2026

Uh oh!

rust-bors bot commented Jan 13, 2026

Uh oh!

This comment was marked as resolved.

rustbot commented Jan 13, 2026

Uh oh!

petrochenkov commented Jan 13, 2026

Uh oh!

rust-bors bot commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

petrochenkov commented Jan 9, 2026 •

edited

Loading

petrochenkov commented Jan 10, 2026 •

edited

Loading