rustc_parse_format: improve diagnostics for unsupported debug = syntax #150897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use |
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-author
Contributor
Author
This comment has been minimized.
This comment has been minimized.
Unique-Usman
force-pushed
the
ua/debug
branch
from
140bb59 to
b56dc0f
Compare
Unique-Usman
changed the title
This comment has been minimized.
This comment has been minimized.
Contributor
|
☔ The latest upstream changes (presumably #151003) made this pull request unmergeable. Please resolve the merge conflicts. |
Unique-Usman
force-pushed
the
ua/debug
branch
from
b56dc0f to
1c6894f
Compare
Collaborator
|
Some changes occurred in src/tools/cargo cc @ehuss |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unique-Usman
force-pushed
the
ua/debug
branch
from
1c6894f to
3db61bc
Compare
Contributor
Author
|
r? @estebank |
This comment has been minimized.
This comment has been minimized.
Unique-Usman
force-pushed
the
ua/debug
branch
from
3db61bc to
f92a01c
Compare
This comment has been minimized.
This comment has been minimized.
Unique-Usman
force-pushed
the
ua/debug
branch
from
f92a01c to
5e2726f
Compare
This comment has been minimized.
This comment has been minimized.
estebank
reviewed
Jan 26, 2026
estebank
reviewed
Feb 2, 2026
Unique-Usman
force-pushed
the
ua/debug
branch
from
5e2726f to
667538e
Compare
Contributor
Author
|
@estebank thanks for the review. I made the necessary changes. |
estebank
approved these changes
Feb 4, 2026
Detect Python-style f-string debug syntax in format strings and emit a
clear diagnostic explaining that it is not supported in Rust. When the
intended operation can be inferred, suggest the corresponding Rust
alternative e.g from `println!("{=}", x)` to `dbg!({x})`.
Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
Unique-Usman
force-pushed
the
ua/debug
branch
from
667538e to
9817ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect Python-style f-string debug syntax in format strings and emit a
clear diagnostic explaining that it is not supported in Rust. When the
intended operation can be inferred, suggest the corresponding Rust
alternative (e.g.
dbg!for{x=}).