Simplify `#[eii]` macro using methods on ecx by jdonszelmann · Pull Request #150906 · rust-lang/rust

jdonszelmann · 2026-01-10T00:56:12Z

No description provided.

rustbot · 2026-01-10T00:56:17Z

rustbot has assigned @WaffleLapkin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jdonszelmann · 2026-01-10T09:48:40Z

@rustbot review

Kivooeo · 2026-01-10T16:39:05Z

r? me

looks good, thanks!

@bors r+ rollup

rust-bors · 2026-01-10T16:39:10Z

📌 Commit 99a8e38 has been approved by Kivooeo

It is now in the queue for this repository.

Simplify `#[eii]` macro using methods on ecx

rust-bors · 2026-01-11T06:46:30Z

☔ The latest upstream changes (presumably #150951) made this pull request unmergeable. Please resolve the merge conflicts.

This pull request was unapproved.

rustbot · 2026-01-11T12:03:15Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2026-01-11T12:03:31Z

@bors r=kivooeo

rust-bors · 2026-01-11T12:03:35Z

📌 Commit d993bd1 has been approved by kivooeo

It is now in the queue for this repository.

rust-log-analyzer · 2026-01-11T13:06:26Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

............................................       (144/144)

======== tests/rustdoc-gui/notable-trait.goml ========

[ERROR] line 255: expected 0 elements, found 1: for command `assert-count: ("//*[@class='tooltip popover']", 0)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html#method.create_an_iterator_from_read>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

Kivooeo · 2026-01-11T13:07:38Z

@bors r-

@rustbot author

rust-bors · 2026-01-11T13:07:42Z

Commit d993bd1 has been unapproved.

rustbot · 2026-01-11T13:07:55Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

jdonszelmann · 2026-01-11T13:15:08Z

@bors retry

rust-bors · 2026-01-11T13:15:10Z

❗ You can only retry pull requests that are approved and have a previously failed auto build

Kivooeo · 2026-01-11T13:16:02Z

@bors r+ @bors retry

rust-bors · 2026-01-11T13:16:06Z

📌 Commit d993bd1 has been approved by Kivooeo

It is now in the queue for this repository.

Kivooeo · 2026-01-11T13:16:23Z

bors is complicated 😔

jdonszelmann · 2026-01-11T13:16:54Z

I think spurious? Do you know what this means @GuillaumeGomez?

@bors try jobs=x86_64-gnu-tools

Simplify `#[eii]` macro using methods on ecx try-job: x86_64-gnu-tools

jdonszelmann · 2026-01-11T13:20:19Z

tested it locally, can't reproduce the failure. Let's keep it approved, I think this was spurious

rust-bors · 2026-01-11T14:20:58Z

☀️ Try build successful (CI)
Build commit: 2147dd5 (2147dd5bdd0353145664579542c7b4962ebd6050, parent: 08f833aa179952037d5d0c5d949d4c3ec18ec212)

Kivooeo · 2026-01-11T14:26:36Z

yeah, seems like everything is fine

@bors rollup

Simplify `#[eii]` macro using methods on ecx

@ghost

Rollup of 7 pull requests Successful merges: - #147938 (Add const cloning of slices and tests) - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc) - #150723 (std: move `errno` and related functions into `sys::io`) - #150906 (Simplify `#[eii]` macro using methods on ecx) - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system) - #150953 (std: sys: fs: uefi: Implement copy) - #150964 (Completely list all unparsed attributes) Failed merges: - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)) r? @ghost

Simplify `#[eii]` macro using methods on ecx

@ghost

Rollup of 7 pull requests Successful merges: - #147938 (Add const cloning of slices and tests) - #149718 (Add freeze file times on Windows) - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc) - #150906 (Simplify `#[eii]` macro using methods on ecx) - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system) - #150953 (std: sys: fs: uefi: Implement copy) - #150964 (Completely list all unparsed attributes) Failed merges: - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)) r? @ghost

@ghost

Rollup of 9 pull requests Successful merges: - #147938 (Add const cloning of slices and tests) - #149718 (Add freeze file times on Windows) - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc) - #150790 (feat: invisible character help string) - #150906 (Simplify `#[eii]` macro using methods on ecx) - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system) - #150953 (std: sys: fs: uefi: Implement copy) - #150964 (Completely list all unparsed attributes) - #150975 (ui: add test for normalizing const projections with assoc const equality) Failed merges: - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)) r? @ghost

Rollup merge of #150906 - eii-ecx-mehods, r=Kivooeo Simplify `#[eii]` macro using methods on ecx

rustbot assigned WaffleLapkin Jan 10, 2026

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 10, 2026

rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 10, 2026

jdonszelmann force-pushed the eii-ecx-mehods branch from 0a2008c to 99a8e38 Compare January 10, 2026 09:52

This comment has been minimized.

Sign in to view

rustbot assigned Kivooeo Jan 10, 2026

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2026

rustbot unassigned WaffleLapkin Jan 10, 2026

rust-bors bot removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2026

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 11, 2026

Rollup merge of rust-lang#150906 - eii-ecx-mehods, r=Kivooeo

801c310

Simplify `#[eii]` macro using methods on ecx

Zalathar mentioned this pull request Jan 11, 2026

[EXPERIMENT] Rollup of 15 pull requests #150948

Closed

rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 11, 2026

rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 11, 2026

improve eii macro by using ecx methods

d993bd1

jdonszelmann force-pushed the eii-ecx-mehods branch from 99a8e38 to d993bd1 Compare January 11, 2026 12:03

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 11, 2026

rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 11, 2026

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 11, 2026

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 11, 2026

rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 11, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jan 11, 2026

Auto merge of #150906 - jdonszelmann:eii-ecx-mehods, r=<try>

2147dd5

Simplify `#[eii]` macro using methods on ecx try-job: x86_64-gnu-tools

jdonszelmann added a commit to jdonszelmann/rust that referenced this pull request Jan 11, 2026

Rollup merge of rust-lang#150906 - eii-ecx-mehods, r=Kivooeo

8e1c167

Simplify `#[eii]` macro using methods on ecx

jdonszelmann mentioned this pull request Jan 11, 2026

Rollup of 7 pull requests #150974

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 11, 2026

Rollup merge of rust-lang#150906 - eii-ecx-mehods, r=Kivooeo

56c3223

Simplify `#[eii]` macro using methods on ecx

matthiaskrgr mentioned this pull request Jan 11, 2026

Rollup of 7 pull requests #150978

Closed

matthiaskrgr mentioned this pull request Jan 11, 2026

Rollup of 9 pull requests #150981

Merged

rust-bors bot merged commit a44a2d3 into rust-lang:main Jan 12, 2026
9 of 12 checks passed

rustbot added this to the 1.94.0 milestone Jan 12, 2026

rust-timer added a commit that referenced this pull request Jan 12, 2026

Unrolled build for #150906

99c72cb

Rollup merge of #150906 - eii-ecx-mehods, r=Kivooeo Simplify `#[eii]` macro using methods on ecx

jdonszelmann mentioned this pull request Jan 14, 2026

Tracking Issue for externally implementable items #125418

Open

48 tasks

github-actions bot mentioned this pull request Jan 28, 2026

Toolchain upgrade to nightly-2026-01-30 flux-rs/flux#1345

Draft

Uh oh!

Conversation

jdonszelmann commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 10, 2026

Uh oh!

jdonszelmann commented Jan 10, 2026

Uh oh!

This comment has been minimized.

Kivooeo commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 11, 2026

Uh oh!

rustbot commented Jan 11, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

rust-bors bot commented Jan 11, 2026

Uh oh!

rust-log-analyzer commented Jan 11, 2026

Uh oh!

Kivooeo commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors bot commented Jan 11, 2026

Uh oh!

rustbot commented Jan 11, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

rust-bors bot commented Jan 11, 2026

Uh oh!

Kivooeo commented Jan 11, 2026

Uh oh!

rust-bors bot commented Jan 11, 2026

Uh oh!

Kivooeo commented Jan 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

This comment has been minimized.

jdonszelmann commented Jan 11, 2026

Uh oh!

rust-bors bot commented Jan 11, 2026

Uh oh!

Kivooeo commented Jan 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jdonszelmann commented Jan 10, 2026 •

edited

Loading

Kivooeo commented Jan 11, 2026 •

edited

Loading

Kivooeo commented Jan 11, 2026 •

edited

Loading