Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing` by GuillaumeGomez · Pull Request #150934 · rust-lang/rust

GuillaumeGomez · 2026-01-10T17:58:04Z

Part of #149865.

I also used this opportunity to remove the id_is_crate_root method.

Once this is merged, I think I'll try to see if we can remove target_id as well.

r? @JonathanBrouwer

rustbot · 2026-01-10T17:58:06Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

JonathanBrouwer · 2026-01-10T18:32:49Z

compiler/rustc_attr_parsing/src/context.rs

    pub(crate) target_span: Span,
    /// The id ([`NodeId`] if `S` is `Early`, [`HirId`] if `S` is `Late`) of the syntactical component this attribute was applied to
    pub(crate) target_id: S::Id,
+    pub(crate) target: Option<rustc_hir::Target>,


It feels a little weird to me that target can be None, but at the same time I see getting parse_single_args to take a Target is just really annoying...
I think this is acceptable

Yeah, not sure how to deal with that. I have some ideas, gonna give it a try later on.

I thought about it more but I really don't see a nice way of fixing this, but if you do feel free to still take a look

Just a hunch, I'll see how far it leads me.

compiler/rustc_attr_parsing/src/attributes/doc.rs

GuillaumeGomez · 2026-01-10T20:30:13Z

Applied suggestion for macro naming.

rust-bors · 2026-01-11T15:50:29Z

☔ The latest upstream changes (presumably #150957) made this pull request unmergeable. Please resolve the merge conflicts.

JonathanBrouwer · 2026-01-11T16:10:33Z

r=me after rebasing

rustbot · 2026-01-11T17:11:53Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

GuillaumeGomez · 2026-01-12T12:48:33Z

@bors r=JonathanBrouwer orllup

rust-bors · 2026-01-12T12:48:37Z

📌 Commit ef1e4e6 has been approved by JonathanBrouwer

It is now in the queue for this repository.

GuillaumeGomez · 2026-01-12T12:48:42Z

@bors rollup

@JonathanBrouwer

…ouwer Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing` Part of rust-lang#149865. I also used this opportunity to remove the `id_is_crate_root` method. Once this is merged, I think I'll try to see if we can remove `target_id` as well. r? @JonathanBrouwer

@ghost

…uwer Rollup of 13 pull requests Successful merges: - #145343 (Dogfood `-Zno-embed-metadata` in the standard library) - #150151 (Destabilise `target-spec-json`) - #150723 (std: move `errno` and related functions into `sys::io`) - #150771 (Remove legacy homu `try` and `auto` branch mentions) - #150826 (Add `f16` inline ASM support for s390x) - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`) - #150943 (Port `#[must_not_suspend]` to attribute parser) - #150990 (std: sys: net: uefi: Make TcpStream Send) - #150995 (core: ptr: split_at_mut: fix typo in safety doc) - #150998 (Relax test expectation for @__llvm_profile_runtime_user) - #151002 (Remove a workaround for a bug (take 2)) - #151005 (Fix typo in `MaybeUninit` docs) - #151011 (Update books) r? @ghost

@JonathanBrouwer

…ouwer Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing` Part of rust-lang#149865. I also used this opportunity to remove the `id_is_crate_root` method. Once this is merged, I think I'll try to see if we can remove `target_id` as well. r? @JonathanBrouwer

@ghost

Rollup of 12 pull requests Successful merges: - #145343 (Dogfood `-Zno-embed-metadata` in the standard library) - #150151 (Destabilise `target-spec-json`) - #150723 (std: move `errno` and related functions into `sys::io`) - #150826 (Add `f16` inline ASM support for s390x) - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`) - #150943 (Port `#[must_not_suspend]` to attribute parser) - #150990 (std: sys: net: uefi: Make TcpStream Send) - #150995 (core: ptr: split_at_mut: fix typo in safety doc) - #150998 (Relax test expectation for @__llvm_profile_runtime_user) - #151002 (Remove a workaround for a bug (take 2)) - #151005 (Fix typo in `MaybeUninit` docs) - #151011 (Update books) r? @ghost

@ghost

…uwer Rollup of 14 pull requests Successful merges: - #150151 (Destabilise `target-spec-json`) - #150826 (Add `f16` inline ASM support for s390x) - #150883 (Improve span for "unresolved intra doc link" on `deprecated` attribute) - #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`) - #150943 (Port `#[must_not_suspend]` to attribute parser) - #150990 (std: sys: net: uefi: Make TcpStream Send) - #150995 (core: ptr: split_at_mut: fix typo in safety doc) - #150998 (Relax test expectation for @__llvm_profile_runtime_user) - #151002 (Remove a workaround for a bug (take 2)) - #151005 (Fix typo in `MaybeUninit` docs) - #151011 (Update books) - #151029 (rustc-dev-guide subtree update) - #151032 (fix: added missing backtick in triagebot.toml) - #151035 (Don't suggest replacing closure parameter with type name) r? @ghost

@JonathanBrouwer

Rollup merge of #150934 - move-doc-attr-checks, r=JonathanBrouwer Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing` Part of #149865. I also used this opportunity to remove the `id_is_crate_root` method. Once this is merged, I think I'll try to see if we can remove `target_id` as well. r? @JonathanBrouwer

JonathanBrouwer · 2026-01-13T16:03:28Z

@rust-timer build 01517e8
Looking into perf regression of #151051

JonathanBrouwer · 2026-01-13T17:57:23Z

@rust-timer build 01517e8

rust-timer · 2026-01-13T18:58:56Z

Finished benchmarking commit (01517e8): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	0.2%	[0.1%, 0.3%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	1

Max RSS (memory usage)

Results (primary 2.0%, secondary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	2.0%	[2.0%, 2.0%]	1

Cycles

Results (primary 2.9%, secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.4%, 3.7%]	5
Regressions ❌ (secondary)	3.2%	[3.2%, 3.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.9%	[2.4%, 3.7%]	5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.958s -> 474.412s (0.10%)
Artifact size: 383.19 MiB -> 383.18 MiB (-0.00%)

@JonathanBrouwer

…anBrouwer Clean up `rustc_attr_parsing` Follow-up of #150934. It removes the `Option<>` wrapping for `SharedContext::target` field and completely removed the `target_id` field. Considering this type contains a closure and never updates its `target_id` field, there is no need to keep it around, it can be used directly in the lint emitter. r? @JonathanBrouwer

@JonathanBrouwer

…anBrouwer Clean up `rustc_attr_parsing` Follow-up of rust-lang/rust#150934. It removes the `Option<>` wrapping for `SharedContext::target` field and completely removed the `target_id` field. Considering this type contains a closure and never updates its `target_id` field, there is no need to keep it around, it can be used directly in the lint emitter. r? @JonathanBrouwer

@ghost

…uwer Rollup of 14 pull requests Successful merges: - rust-lang/rust#150151 (Destabilise `target-spec-json`) - rust-lang/rust#150826 (Add `f16` inline ASM support for s390x) - rust-lang/rust#150883 (Improve span for "unresolved intra doc link" on `deprecated` attribute) - rust-lang/rust#150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`) - rust-lang/rust#150943 (Port `#[must_not_suspend]` to attribute parser) - rust-lang/rust#150990 (std: sys: net: uefi: Make TcpStream Send) - rust-lang/rust#150995 (core: ptr: split_at_mut: fix typo in safety doc) - rust-lang/rust#150998 (Relax test expectation for @__llvm_profile_runtime_user) - rust-lang/rust#151002 (Remove a workaround for a bug (take 2)) - rust-lang/rust#151005 (Fix typo in `MaybeUninit` docs) - rust-lang/rust#151011 (Update books) - rust-lang/rust#151029 (rustc-dev-guide subtree update) - rust-lang/rust#151032 (fix: added missing backtick in triagebot.toml) - rust-lang/rust#151035 (Don't suggest replacing closure parameter with type name) r? @ghost

rustbot assigned JonathanBrouwer Jan 10, 2026

JonathanBrouwer requested changes Jan 10, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2026

GuillaumeGomez force-pushed the move-doc-attr-checks branch from 533e109 to 077c9b2 Compare January 10, 2026 20:28

GuillaumeGomez force-pushed the move-doc-attr-checks branch from 077c9b2 to 3343f73 Compare January 11, 2026 17:11

This comment has been minimized.

Sign in to view

Move checks from check_doc_attrs directly into rustc_attr_parsing

ef1e4e6

GuillaumeGomez force-pushed the move-doc-attr-checks branch from 3343f73 to ef1e4e6 Compare January 11, 2026 17:36

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 12, 2026

rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 12, 2026

JonathanBrouwer mentioned this pull request Jan 12, 2026

Rollup of 13 pull requests #151023

Closed

matthiaskrgr mentioned this pull request Jan 12, 2026

Rollup of 12 pull requests #151038

Closed

JonathanBrouwer mentioned this pull request Jan 13, 2026

Rollup of 14 pull requests #151051

Merged

rust-bors bot merged commit e33f5aa into rust-lang:main Jan 13, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 13, 2026

GuillaumeGomez deleted the move-doc-attr-checks branch January 13, 2026 14:21

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot added the perf-regression Performance regression. label Jan 13, 2026

GuillaumeGomez mentioned this pull request Jan 15, 2026

Clean up rustc_attr_parsing #151162

Merged

github-actions bot mentioned this pull request Jan 28, 2026

Toolchain upgrade to nightly-2026-01-30 flux-rs/flux#1345

Draft

Uh oh!

Conversation

GuillaumeGomez commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

GuillaumeGomez commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 11, 2026

Uh oh!

JonathanBrouwer commented Jan 11, 2026

Uh oh!

rustbot commented Jan 11, 2026

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Jan 12, 2026

Uh oh!

rust-bors bot commented Jan 12, 2026

Uh oh!

GuillaumeGomez commented Jan 12, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

JonathanBrouwer commented Jan 13, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jan 13, 2026

Overall result: ❌ regressions - please read the text below

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

GuillaumeGomez commented Jan 10, 2026 •

edited

Loading

JonathanBrouwer commented Jan 13, 2026 •

edited

Loading