Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Port symbol mangler attrs
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (3162956): comparison URL. Overall result: ❌✅ regressions and improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -1.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.122s -> 472.718s (-0.09%) |
|
☔ The latest upstream changes (presumably #150957) made this pull request unmergeable. Please resolve the merge conflicts. |
aafb475 to
0e0bbee
Compare
|
@Bryntet any chance we can merge this one soon? Ran into wanting it converted in another PR :3 |
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_hir/src/attrs |
0e0bbee to
62fd7ad
Compare
This comment has been minimized.
This comment has been minimized.
|
thanks for reminding me about this PR, had forgotten about it |
62fd7ad to
ca6ebc5
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
ca6ebc5 to
ef7013f
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Tracking issue: #131229
@JonathanBrouwer could you run perf on this?