Add FCW for derive helper attributes that will conflict with built-in attributes

[nik-rev]

Adds a future-compatibility-warning deny-by-default lint that helps catch invalid derive helper attribute names early.

This issues the lint, saying that ignore helper will clash with the built-in ignore attribute.

#![crate_type = "proc-macro"]
#![deny(ambiguous_derive_helpers)] 
use proc_macro::TokenStream; 

#[proc_macro_derive(Trait, attributes(ignore))]
pub fn example(input: TokenStream) -> TokenStream {
    TokenStream::new()
}

If you actually tried to use that ignore helper attribute, you won't be able to due to the ambiguity:

#[derive(Trait)]
struct Foo {
    #[ignore]
    field: (),
}

Produces:

error[E0659]: `ignore` is ambiguous
 --> src/lib.rs:5:7
  |
5 |     #[ignore]
  |       ^^^^^^ ambiguous name
  |
  = note: ambiguous because of a name conflict with a builtin attribute
  = note: `ignore` could refer to a built-in attribute
note: `ignore` could also refer to the derive helper attribute defined here
 --> src/lib.rs:3:10
  |
3 | #[derive(Trait)]
  |          ^^^^^

[rustbot]

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

[rustbot]

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[chenyukang]

@bors r=chenyukang

[rust-bors]

📌 Commit 4dda363 has been approved by chenyukang

It is now in the queue for this repository.

[petrochenkov]

New deprecation lints go through language team process, and the lint name also doesn't follow naming conventions.

[chenyukang]

@bors r-

[rust-bors]

Commit 4dda363 has been unapproved.

[nik-rev]

@rustbot label +I-lang-nominated

I am nominating this for lang-team attention.

What name should this lint have? The current name doesn't follow the naming conventions

My main idea is allow(derive_helper_attr_with_same_name_as_a_builtin_attr), but that's quite long

[joshtriplett]

The FCW lint seems reasonable.

@rfcbot merge lang

[rust-rfcbot]

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

• @joshtriplett
• @nikomatsakis
• @scottmcm
• @tmandry
• @traviscross

Concerns:

• name resolved by Add FCW for derive helper attributes that will conflict with built-in attributes #151152 (comment)

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

[traviscross]

@rfcbot concern name

We need to spend a few minutes reviewing the name.

[tmandry]

@rfcbot reviewed

[Darksonn]

How about this name? ambiguous_derive_macro_attribute

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[nik-rev]

@rustbot ready

[traviscross]

Looks reasonable to me.

View changes since this review

[traviscross]

Thanks.

@rfcbot resolve name

[traviscross]

@rfcbot reviewed

[rust-rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rust-rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.