Draft
Conversation
rustbot
added
S-waiting-on-author
The `ucd_parse` crate offers a function to get the Unicode version from the readme, so we don't need to reimplement it ourselves.
Instead of `include_str!()`ing `range_search.rs`, just make it a normal module under `core::unicode`. This means the same source code doesn't have to be checked in twice, and it plays nicer with IDEs. Also rename it to `rt` because it will also include runtime functions for case foldings in the next commit.
Instead of writing the body of `to_lower()` and `to_upper()` in a string literal and pasting into the final`unicode_data.rs`, extract the common logic into a helper function in the `rt` module and then call the helper from the generated code. Same motivation as previous commit (better IDE support, less duplicate code checked into git).
Remove `#[rustfmt::skip]` from all the generated modules in `unicode_data.rs`. This means we won't have to worry so much about getting indentation and formatting right when generating code. Exempted for now the case folding tables which would be too long when formatted by `rustfmt`.
This check was made redundant (it will always be true) when we removed all ASCII characters from the tables (a8c6694).
To make the final output code easier to see: * Get rid of the unnecessary line-noise of `.unwrap()`ing calls to `write!()` by moving the `.unwrap()` into a macro. * Join consecutive `write!()` calls using a single multiline format string. * Replace `.push()` and `.push_str(format!())` with `write!()`. * If after doing all of the above, there is only a single `write!()` call in the function, just construct the string directly with `format!()`.
In the case_mapping tables, print the data in hexadecimal. This makes the relationship between each character and character it is mapped to more obvious. Do the same for cascading_map, because we are inspecting the higher byte of the input character, so it makes more sense to compare against a hexadecimal literal.
The preferred way to run `assert`s at compile-time is to put them in an
unnamed constant (`const _: () = { ... };`). This avoids the asserts
being evaluated on every call by tools like MIRI.
Instead of generating a standalone executable to test `unicode_data`, generate normal tests in `coretests`. This ensures tests are always generated, and will be run as part of the normal testsuite. Also change the generated tests to loop over lookup tables, rather than generating a separate `assert_eq!()` statement for every codepoint. The old approach produced a massive (20,000 lines plus) file which took minutes to compile!
Workaround for issue rust-lang#148387
Kmeakin
force-pushed
the
unicode_data_fixes
branch
from
1ebfc8c to
c063bce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responding to reviews in #148438