Rollup of 6 pull requests by JonathanBrouwer · Pull Request #151459 · rust-lang/rust

JonathanBrouwer · 2026-01-21T15:39:44Z

Successful merges:

tests/debuginfo/basic-stepping.rs: Add revisions default-mir-passes, no-SingleUseConsts-mir-pass #147426 ( tests/debuginfo/basic-stepping.rs: Add revisions default-mir-passes, no-SingleUseConsts-mir-pass)
Remove old error emitter #150880 (Remove old error emitter)
use deny(missing_docs) for non-mir intrinsics #151432 (use deny(missing_docs) for non-mir intrinsics)
Move UI tests #151444 (Move UI tests)
Derive Default for QueryArenas #151445 (Derive Default for QueryArenas)
make simd_insert_dyn and simd_extract_dyn const #151453 (make simd_insert_dyn and simd_extract_dyn const)

…nore-*` We want directives nice and tidy.

…, `no-SingleUseConsts-mir-pass` To prevent regressions our test must cover the code both inside and outside of the `SingleUseConsts` MIR pass. Use revisions for that.

This completes the transition to annotate-snippets

…panic.rs

tests/debuginfo/basic-stepping.rs: Add revisions `default-mir-passes`, `no-SingleUseConsts-mir-pass` To prevent regressions our test must cover the code both inside and outside of the `SingleUseConsts` MIR pass. Use revisions for that. We know this use case is sensitive to regressions because it already happened at least once. See rust-lang#33013 (comment). CC rust-lang#130896

…=nnethercote Remove old error emitter This completes the transition to annotate-snippets and cuts 3600 lines of code.

…, r=RalfJung use `deny(missing_docs)` for non-mir intrinsics

Move UI tests Moved several regression tests from `tests/ui/issues` to specific folders

Derive `Default` for `QueryArenas` There's no need to manually implement Default for this struct, because the fields are all `TypeArena<_>` or `()`, which both implement Default already. This lets us avoid one occurrence of the `query_if_arena!` macro.

make `simd_insert_dyn` and `simd_extract_dyn` const For use in `stdarch`. We currently use an equivalent of the fallback body here, but on some targets the intrinsic generate better code. r? RalfJung

JonathanBrouwer · 2026-01-21T15:39:59Z

@bors r+ rollup=never p=5

rust-bors · 2026-01-21T15:40:08Z

📌 Commit 530eeff has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-01-21T19:11:10Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 16m 44s
Pushing daa90b9 to main...

rust-timer · 2026-01-21T19:12:53Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147426	tests/debuginfo/basic-stepping.rs: Add revisions `default-…	`9b5a24b334b8291dba2b94c046669cc60b195b7f` (link)
#150880	Remove old error emitter	`d1da86ef844dd634238b876b2ae44685f5b89a75` (link)
#151432	use `deny(missing_docs)` for non-mir intrinsics	`6e0b729d4dc4c098835cc619d20a7c5978d42894` (link)
#151444	Move UI tests	`feb31e184e8c83b0f2c7fabd99cafbab8ef60dcc` (link)
#151445	Derive `Default` for `QueryArenas`	`1a1ed3e541e03d195034ebe3f37eb33521fe8450` (link)
#151453	make `simd_insert_dyn` and `simd_extract_dyn` const	`113a0a6eb6fec28a50a84d720beea449563a733a` (link)

previous master: 625b63f9e1

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-01-21T19:14:25Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 625b63f (parent) -> daa90b9 (this PR)

Test differences

Show 75 test diffs

Stage 1

[debuginfo-gdb] tests/debuginfo/basic-stepping.rs: pass -> [missing] (J3)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs#default-mir-passes: [missing] -> pass (J3)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs#no-SingleUseConsts-mir-pass: [missing] -> pass (J3)
[ui] tests/ui/cast/generic-trait-object-call.rs: [missing] -> pass (J3)
[ui] tests/ui/extern/lgamma-linkage.rs: [missing] -> pass (J3)
[ui] tests/ui/generics/generic-impl-method-params-2311.rs: [missing] -> pass (J3)
[ui] tests/ui/generics/generic-trait-method-params-2311.rs: [missing] -> pass (J3)
[ui] tests/ui/generics/resolve-generic-method-param-2312.rs: [missing] -> pass (J3)
[ui] tests/ui/issues/issue-2190-1.rs: pass -> [missing] (J3)
[ui] tests/ui/issues/issue-2214.rs: pass -> [missing] (J3)
[ui] tests/ui/issues/issue-2288.rs: pass -> [missing] (J3)
[ui] tests/ui/issues/issue-2311-2.rs: pass -> [missing] (J3)
[ui] tests/ui/issues/issue-2311.rs: pass -> [missing] (J3)
[ui] tests/ui/issues/issue-2312.rs: pass -> [missing] (J3)
[ui] tests/ui/threads-sendsync/recursive-thread-spawn.rs: [missing] -> pass (J3)

Stage 2

[debuginfo-lldb] tests/debuginfo/basic-stepping.rs: ignore (ignored when the architecture is aarch64 (Doesn't work yet.)) -> [missing] (J0)
[debuginfo-lldb] tests/debuginfo/basic-stepping.rs#default-mir-passes: [missing] -> ignore (ignored when the architecture is aarch64 (Doesn't work yet.)) (J0)
[debuginfo-lldb] tests/debuginfo/basic-stepping.rs#no-SingleUseConsts-mir-pass: [missing] -> ignore (ignored when the architecture is aarch64 (Doesn't work yet.)) (J0)
[debuginfo-gdb (split-dwarf)] tests/debuginfo/basic-stepping.rs: pass -> [missing] (J1)
[debuginfo-gdb (split-dwarf)] tests/debuginfo/basic-stepping.rs#default-mir-passes: [missing] -> pass (J1)
[debuginfo-gdb (split-dwarf)] tests/debuginfo/basic-stepping.rs#no-SingleUseConsts-mir-pass: [missing] -> pass (J1)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs: ignore (gcc backend is marked as ignore) -> [missing] (J2)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs#default-mir-passes: [missing] -> ignore (gcc backend is marked as ignore) (J2)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs#no-SingleUseConsts-mir-pass: [missing] -> ignore (gcc backend is marked as ignore) (J2)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs: ignore (ignored when the architecture is aarch64 (Doesn't work yet.)) -> [missing] (J4)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs#default-mir-passes: [missing] -> ignore (ignored when the architecture is aarch64 (Doesn't work yet.)) (J4)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs#no-SingleUseConsts-mir-pass: [missing] -> ignore (ignored when the architecture is aarch64 (Doesn't work yet.)) (J4)
[ui] tests/ui/cast/generic-trait-object-call.rs: [missing] -> pass (J5)
[ui] tests/ui/extern/lgamma-linkage.rs: [missing] -> pass (J5)
[ui] tests/ui/generics/generic-impl-method-params-2311.rs: [missing] -> pass (J5)
[ui] tests/ui/generics/generic-trait-method-params-2311.rs: [missing] -> pass (J5)
[ui] tests/ui/generics/resolve-generic-method-param-2312.rs: [missing] -> pass (J5)
[ui] tests/ui/issues/issue-2190-1.rs: pass -> [missing] (J5)
[ui] tests/ui/issues/issue-2214.rs: pass -> [missing] (J5)
[ui] tests/ui/issues/issue-2288.rs: pass -> [missing] (J5)
[ui] tests/ui/issues/issue-2311-2.rs: pass -> [missing] (J5)
[ui] tests/ui/issues/issue-2311.rs: pass -> [missing] (J5)
[ui] tests/ui/issues/issue-2312.rs: pass -> [missing] (J5)
[ui] tests/ui/threads-sendsync/recursive-thread-spawn.rs: [missing] -> pass (J5)
[debuginfo-cdb] tests/debuginfo/basic-stepping.rs: ignore (ignored when the architecture is aarch64 (Doesn't work yet.)) -> [missing] (J6)
[debuginfo-cdb] tests/debuginfo/basic-stepping.rs#default-mir-passes: [missing] -> ignore (ignored when the architecture is aarch64 (Doesn't work yet.)) (J6)
[debuginfo-cdb] tests/debuginfo/basic-stepping.rs#no-SingleUseConsts-mir-pass: [missing] -> ignore (ignored when the architecture is aarch64 (Doesn't work yet.)) (J6)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs: pass -> [missing] (J7)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs#default-mir-passes: [missing] -> pass (J7)
[debuginfo-gdb] tests/debuginfo/basic-stepping.rs#no-SingleUseConsts-mir-pass: [missing] -> pass (J7)

Additionally, 30 doctest diffs were found. These are ignored, as they are noisy.

Job group index

J0: aarch64-apple
J1: x86_64-gnu-nopt
J2: x86_64-gnu-gcc
J3: x86_64-gnu-llvm-20-3, x86_64-gnu-llvm-21-3
J4: aarch64-gnu, aarch64-gnu-llvm-20-1
J5: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-20-1, aarch64-msvc-1, arm-android, armhf-gnu, dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, i686-msvc-1, test-various, x86_64-gnu, x86_64-gnu-debug, x86_64-gnu-gcc, x86_64-gnu-llvm-20, x86_64-gnu-llvm-20-2, x86_64-gnu-llvm-21-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1, x86_64-msvc-1
J6: aarch64-msvc-1
J7: dist-i586-gnu-i586-i686-musl, i686-gnu-1, i686-gnu-nopt-1, test-various, x86_64-gnu, x86_64-gnu-llvm-20-2, x86_64-gnu-llvm-21-2, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-1

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard daa90b96dd039ce0c5708408972e2af45990c1db --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 6045.6s -> 8410.2s (+39.1%)
x86_64-gnu-llvm-20-1: 3768.8s -> 4423.3s (+17.4%)
x86_64-rust-for-linux: 2672.6s -> 3131.6s (+17.2%)
dist-apple-various: 5155.7s -> 4284.0s (-16.9%)
aarch64-gnu-llvm-20-1: 3415.3s -> 3865.2s (+13.2%)
i686-gnu-2: 5299.0s -> 5948.4s (+12.3%)
pr-check-1: 1666.5s -> 1863.2s (+11.8%)
x86_64-gnu-tools: 3388.3s -> 3786.9s (+11.8%)
i686-gnu-1: 7437.0s -> 8285.9s (+11.4%)
x86_64-gnu-llvm-21-1: 4105.9s -> 4508.2s (+9.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-21T19:52:56Z

Finished benchmarking commit (daa90b9): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

Results (primary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-1.7%, -1.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[-1.7%, 2.7%]	2

Cycles

Results (primary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.0%, 2.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.0%, 2.3%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.946s -> 470.203s (-1.00%)
Artifact size: 383.21 MiB -> 383.19 MiB (-0.01%)

Enselic and others added 18 commits January 5, 2026 08:08

tests/debuginfo/basic-stepping.rs: Don't mix compile-flags with `ig…

de505d2

…nore-*` We want directives nice and tidy.

tests/debuginfo/basic-stepping.rs: Add revisions default-mir-passes…

622572f

…, `no-SingleUseConsts-mir-pass` To prevent regressions our test must cover the code both inside and outside of the `SingleUseConsts` MIR pass. Use revisions for that.

Derive Default for QueryArenas

91a0e09

Add some comments to QueryArenas

2495e58

Remove old error emitter

3ccabc6

This completes the transition to annotate-snippets

use deny(missing_docs) for non-mir intrinsics

9c5bfe8

moved 6 tests to organized locations

6fd6ff3

added issue link

b7d7dce

moved tests/ui/issues/issue-2150.rs -> tests/ui/reachable/loop-after-…

b786aa8

…panic.rs

filename changes

7ba1e3e

fix error

0d6d0fa

make simd_insert_dyn and simd_extract_dyn const

b4220ec

Rollup merge of rust-lang#150880 - bjorn3:remove_old_error_emitter, r…

1fd8543

…=nnethercote Remove old error emitter This completes the transition to annotate-snippets and cuts 3600 lines of code.

Rollup merge of rust-lang#151432 - folkertdev:intrinsics-require-docs…

e937bdd

…, r=RalfJung use `deny(missing_docs)` for non-mir intrinsics

Rollup merge of rust-lang#151444 - Delta17920:move-ui-tests, r=Kivooeo

6cd3cfd

Move UI tests Moved several regression tests from `tests/ui/issues` to specific folders

Rollup merge of rust-lang#151453 - folkertdev:simd-dyn-const, r=RalfJung

530eeff

make `simd_insert_dyn` and `simd_extract_dyn` const For use in `stdarch`. We currently use an equivalent of the fallback body here, but on some targets the intrinsic generate better code. r? RalfJung

rust-bors bot added the rollup A PR which is a rollup label Jan 21, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 21, 2026

rust-bors bot merged commit daa90b9 into rust-lang:main Jan 21, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Jan 21, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests#151459

Rollup of 6 pull requests#151459
rust-bors[bot] merged 18 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-VecWQ0g

JonathanBrouwer commented Jan 21, 2026

Uh oh!

JonathanBrouwer commented Jan 21, 2026

Uh oh!

rust-bors bot commented Jan 21, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 21, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

JonathanBrouwer commented Jan 21, 2026

Uh oh!

JonathanBrouwer commented Jan 21, 2026

Uh oh!

rust-bors bot commented Jan 21, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 21, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 21, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jan 21, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants