std: always use waitable timer objects for sleep on Windows#151553
Draft
joboet wants to merge 1 commit intorust-lang:mainfrom
Draft
std: always use waitable timer objects for sleep on Windows#151553joboet wants to merge 1 commit intorust-lang:mainfrom
sleep on Windows#151553joboet wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
☔ The latest upstream changes (presumably #151634) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stdcurrently only uses waitable timer objects if theCREATE_WAITABLE_TIMER_HIGH_RESOLUTIONis supported (which got added in Windows 10, version 1803), and falls back toSleepotherwise. This is unfortunate, asSleeponly allows specifying the duration in milliseconds and can actually round down the sleep duration (see #149935). Waitable timer objects (supported since Vista), on the other hand, allow expressing the duration in 100 ns units and don't round down. Thus, it's better to use them even if the system doesn't make use of the added precision. I've kept the zero-duration behaviour ofSleep, just to be safe.Fixes #149935
Draft until I implement miri support for WTOs.