Skip to content

[stable] Don't try to recover keyword as non-keyword identifier#151714

Closed
tgross35 wants to merge 2 commits intorust-lang:stablefrom
tgross35:backport-kw-recovery
Closed

[stable] Don't try to recover keyword as non-keyword identifier#151714
tgross35 wants to merge 2 commits intorust-lang:stablefrom
tgross35:backport-kw-recovery

Conversation

@tgross35
Copy link
Contributor

... in macro invocations.

Issue: <rust-lang#149692>.
(cherry picked from commit 31531b3)
There's no sensible recovery scheme here, giving up the recovery is the
right thing to do.

(cherry picked from commit 79c4727)
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 27, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
##[group]Runner Image Provisioner
Hosted Compute Agent
Version: 20260115.477
Commit: 4b342d620503cbe250a3154040964899ea7c9b00
Build Date: 2026-01-15T22:32:41Z
Worker ID: {b8761893-0596-4121-ba9a-7fbddda34362}
Azure Region: westcentralus
##[endgroup]
##[group]Operating System
Ubuntu
24.04.3
LTS

@Mark-Simulacrum Mark-Simulacrum added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Jan 27, 2026
@mu001999
Copy link
Contributor

mu001999 commented Jan 27, 2026

I think we should also backport #151249

@tgross35
Copy link
Contributor Author

@mu001999 could you elaborate on why at the backport stream? #t-compiler/backports > #150590: stable-nominated

@apiraino
Copy link
Contributor

stable backport accepted during t-compiler triage, though we don't feel it deserve in isolation a dot release.

@rustbot label +stable-accepted

@rustbot rustbot added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Jan 29, 2026
@jieyouxu
Copy link
Member

jieyouxu commented Feb 5, 2026

(I'm going to close this in favor of a stable backport rollup that contains #150590, which is already tagged stable-accepted, since the stable backport will need to backport a clippy fix too I think)

@jieyouxu jieyouxu closed this Feb 5, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 5, 2026
@tgross35 tgross35 deleted the backport-kw-recovery branch February 5, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-accepted Accepted for backporting to the compiler in the stable channel. stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants