more float constants by joshuarayton · Pull Request #151825 · rust-lang/rust

joshuarayton · 2026-01-29T13:58:32Z

Add constants discussed in #146939 rust-lang/libs-team#661
Retry of #146934

r? @tgross35

joshuarayton · 2026-01-29T15:36:11Z

Not sure why this failed, #93784 seems to be relevant.

tgross35

Two small nits then LGTM

View changes since this review

tgross35 · 2026-01-30T20:02:02Z

library/core/src/num/f128.rs

+    /// sqrt(5)
+    #[unstable(feature = "f128", issue = "116909")]
+    // Also, #[unstable(feature = "more_float_constants", issue = "146939")]
+    pub const SQRT_5: f128 = 2.23606797749978969640917366873127623544061835961152572427089_f128;
+
+    /// 1/sqrt(5)
+    #[unstable(feature = "f128", issue = "116909")]
+    // Also, #[unstable(feature = "more_float_constants", issue = "146939")]
+    pub const FRAC_1_SQRT_5: f128 =
+        0.447213595499957939281834733746255247088123671922305144854179_f128;


For f16 and f128, gate these under more_float_constants and leave the f128 gate in a comment. Bit safer since stabilizing this feature without f16/f128 would still not let you use these, but not the other way around.

tgross35 · 2026-01-30T20:08:16Z

library/core/src/num/f16.rs

+    /// sqrt(5)
+    #[unstable(feature = "f16", issue = "116909")]
+    // Also, #[unstable(feature = "more_float_constants", issue = "146939")]
+    pub const SQRT_5: f16 = 2.236067977499789696409173668731276235_f16;


Extremely minor nit: the SQRT_5 value is correct, but it has 37 significant digits while we use 36 significant digits for f16/f32/f64. Mind chopping one off?

tgross35

(updating status)

View changes since this review

rustbot · 2026-01-30T20:36:14Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-02-01T17:12:09Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

tgross35

Great, thank you!

@bors r+ rollup

View changes since this review

rust-bors · 2026-02-02T00:36:04Z

📌 Commit caaee92 has been approved by tgross35

It is now in the queue for this repository.

@tgross35

… r=tgross35 more float constants Add constants discussed in rust-lang#146939 rust-lang/libs-team#661 Retry of rust-lang#146934 r? @tgross35

Rollup of 5 pull requests Successful merges: - #151825 (more float constants) - #151958 (Add codegen test for SLP vectorization) - #151974 (Update documentation for `Result::ok()`) - #151978 (Query cleanups) - #151979 (Fix uninitialized UEFI globals in tests)

@tgross35

… r=tgross35 more float constants Add constants discussed in rust-lang#146939 rust-lang/libs-team#661 Retry of rust-lang#146934 r? @tgross35

Rollup of 5 pull requests Successful merges: - #151938 (Use `#![feature(adt_const_params)]` for static query flags) - #151825 (more float constants) - #151974 (Update documentation for `Result::ok()`) - #151978 (Query cleanups) - #151979 (Fix uninitialized UEFI globals in tests)

@tgross35

… r=tgross35 more float constants Add constants discussed in rust-lang#146939 rust-lang/libs-team#661 Retry of rust-lang#146934 r? @tgross35

…uwer Rollup of 11 pull requests Successful merges: - #150992 (link modifier `export-symbols`: export all global symbols from selected uptream c static libraries) - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive) - #151938 (Use `#![feature(adt_const_params)]` for static query flags) - #151172 (Use default field values in a few more cases) - #151825 (more float constants) - #151870 (regression test for alias-relate changes in lub) - #151902 (explain why we dont skip some of this work when there are field projections) - #151974 (Update documentation for `Result::ok()`) - #151978 (Query cleanups) - #151979 (Fix uninitialized UEFI globals in tests) - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)

@tgross35

… r=tgross35 more float constants Add constants discussed in rust-lang#146939 rust-lang/libs-team#661 Retry of rust-lang#146934 r? @tgross35

…uwer Rollup of 12 pull requests Successful merges: - #149596 (resolve: Report more visibility-related early resolution ambiguities for imports) - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive) - #151938 (Use `#![feature(adt_const_params)]` for static query flags) - #151172 (Use default field values in a few more cases) - #151825 (more float constants) - #151870 (regression test for alias-relate changes in lub) - #151872 (Add inline syntax for diagnostic messages) - #151902 (explain why we dont skip some of this work when there are field projections) - #151909 (Skip overlapping spans in argument error suggestions) - #151978 (Query cleanups) - #151979 (Fix uninitialized UEFI globals in tests) - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)

@tgross35

Rollup merge of #151825 - joshuarayton:more-float-constants, r=tgross35 more float constants Add constants discussed in #146939 rust-lang/libs-team#661 Retry of #146934 r? @tgross35

rustbot assigned tgross35 Jan 29, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 29, 2026

This comment has been minimized.

Sign in to view

jieyouxu mentioned this pull request Jan 29, 2026

rustdoc-gui tests sporadically failing #93784

Open

joshuarayton force-pushed the more-float-constants branch from efa31c1 to 403ff9b Compare January 30, 2026 15:44

This comment has been minimized.

Sign in to view

tgross35 reviewed Jan 30, 2026

View reviewed changes

tgross35 requested changes Jan 30, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 30, 2026

more float constants: sqrt(5), 1/sqrt(5)

caaee92

joshuarayton force-pushed the more-float-constants branch from 403ff9b to caaee92 Compare February 1, 2026 17:12

tgross35 approved these changes Feb 2, 2026

View reviewed changes

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 2, 2026

jhpratt mentioned this pull request Feb 2, 2026

Rollup of 5 pull requests #151984

Closed

jhpratt mentioned this pull request Feb 2, 2026

Rollup of 5 pull requests #151987

Closed

JonathanBrouwer mentioned this pull request Feb 2, 2026

Rollup of 11 pull requests #151997

Closed

This was referenced Feb 2, 2026

Rollup of 11 pull requests #152005

Closed

Rollup of 12 pull requests #152006

Merged

rust-bors bot merged commit f0355cc into rust-lang:main Feb 3, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 3, 2026

rust-timer added a commit that referenced this pull request Feb 3, 2026

Unrolled build for #151825

2a7b7e6

Rollup merge of #151825 - joshuarayton:more-float-constants, r=tgross35 more float constants Add constants discussed in #146939 rust-lang/libs-team#661 Retry of #146934 r? @tgross35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

more float constants#151825

more float constants#151825
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
joshuarayton:more-float-constants

joshuarayton commented Jan 29, 2026 •

edited by rustbot

Loading

Uh oh!

This comment has been minimized.

joshuarayton commented Jan 29, 2026

Uh oh!

This comment has been minimized.

tgross35 left a comment •

edited by rustbot

Loading

Uh oh!

tgross35 Jan 30, 2026

Uh oh!

tgross35 Jan 30, 2026

Uh oh!

tgross35 left a comment •

edited by rustbot

Loading

Uh oh!

rustbot commented Jan 30, 2026

Uh oh!

rustbot commented Feb 1, 2026

Uh oh!

tgross35 left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors bot commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

joshuarayton commented Jan 29, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

joshuarayton commented Jan 29, 2026

Uh oh!

This comment has been minimized.

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgross35 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

tgross35 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jan 30, 2026

Uh oh!

rustbot commented Feb 1, 2026

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors bot commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joshuarayton commented Jan 29, 2026 •

edited by rustbot

Loading

tgross35 left a comment •

edited by rustbot

Loading

tgross35 left a comment •

edited by rustbot

Loading

tgross35 left a comment •

edited by rustbot

Loading