Borrowck: simplify diagnostics for placeholders#151863
Open
amandasystems wants to merge 2 commits intorust-lang:mainfrom
Open
Borrowck: simplify diagnostics for placeholders#151863amandasystems wants to merge 2 commits intorust-lang:mainfrom
amandasystems wants to merge 2 commits intorust-lang:mainfrom
Conversation
This essentially folds the call to `region_from_element` into `RegionInferenceContext`, and simplifies the error variant for this case. It also clarifies the type information on the methods called to emphasise the fact that they only ever use placeholder regions in the diagnostics, and completely ignore any other element.
rustbot
added
S-waiting-on-review
amandasystems
changed the title
lcnr
reviewed
Feb 3, 2026
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
Author
I should have addressed it now! The test failure seems spurious to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This folds the call to
region_from_elementintoRegionInferenceContext, and simplifies the error variant for this case to only talk about regions as opposed to elements. This is the only case where aRegionElementleaks out of region inference, so now they can be considered internal to region inference (though that currently isn't expressed). It also clarifies the type information on the methods called to emphasise the fact that they only ever use placeholder regions in the diagnostics completely ignore any other element.It also adds a bunch of FIXMEs to some fishy statements that conjure universes from what seems like arbitrary integers.
This was lifted from #142623.
r? @lcnr