Rollup of 5 pull requests by jhpratt · Pull Request #151891 · rust-lang/rust

jhpratt · 2026-01-31T03:52:23Z

Successful merges:

core: add Option::get_or_try_insert_with #143650 (core: add Option::get_or_try_insert_with)
Remove duplicated code in slice/index.rs #151726 (Remove duplicated code in slice/index.rs)
Add shift_{left,right} on slices #151812 (Add shift_{left,right} on slices)
Implement BinaryHeap::pop_if() #151829 (Implement BinaryHeap::pop_if())
Fix typo for Maybe dangling docs #151838 (Fix typo for Maybe dangling docs)

Co-authored-by: kennytm <kennytm@gmail.com>

Looks like `const fn` is far enough along now that we can just not have these two copies any more, and have one call the other.

Boxe's -> Box's

cc tracking issue 151772

…y_insert_with-143648, r=jhpratt core: add Option::get_or_try_insert_with Implementation for rust-lang#143648

…=jhpratt Remove duplicated code in `slice/index.rs` Looks like `const fn` is far enough along now that we can just not have these two copies any more, and have one call the other.

Add `shift_{left,right}` on slices ACP approval: rust-lang/libs-team#717 (comment) cc tracking issue rust-lang#151772

…hpratt,joboet Implement `BinaryHeap::pop_if()` Implementation of rust-lang#151828

Fix typo for Maybe dangling docs Boxe's -> Box's

jhpratt · 2026-01-31T03:52:34Z

@bors r+ rollup=never p=5

rust-bors · 2026-01-31T03:52:38Z

📌 Commit 4b850fa has been approved by jhpratt

It is now in the queue for this repository.

rust-bors · 2026-01-31T09:44:51Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 7m 24s
Pushing 1e9be1b to main...

rust-timer · 2026-01-31T09:46:16Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#143650	core: add Option::get_or_try_insert_with	`cd26116902f27fc1cb9979bf6541ac09550babc3` (link)
#151726	Remove duplicated code in `slice/index.rs`	`7beb1222c8d8208e56140a529b9d2aaa4ddcee4a` (link)
#151812	Add `shift_{left,right}` on slices	`d7fc7813b44a0e9b3017f89a41449b847a55bb88` (link)
#151829	Implement `BinaryHeap::pop_if()`	`ee32d3154a21b2509b0f6482b708bd3f870bfda8` (link)
#151838	Fix typo for Maybe dangling docs	`7103966d08cca6ab4c342c732c535cfac8863338` (link)

previous master: 310ae8ca77

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-01-31T09:48:00Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 310ae8c (parent) -> 1e9be1b (this PR)

Test differences

Show 402 test diffs

Stage 1

collections::binary_heap::test_pop_if: [missing] -> pass (J1)
slice::test_shift_left: [missing] -> pass (J1)
slice::test_shift_right: [missing] -> pass (J1)

Stage 2

collections::binary_heap::test_pop_if: [missing] -> pass (J0)
slice::test_shift_left: [missing] -> pass (J0)
slice::test_shift_right: [missing] -> pass (J0)

Additionally, 396 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1e9be1b77fe89d9757d6179973b2fc970c6e83b7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-various: 7226.4s -> 6169.0s (-14.6%)
dist-apple-various: 3310.3s -> 3744.9s (+13.1%)
dist-various-2: 2232.1s -> 2390.4s (+7.1%)
dist-aarch64-msvc: 5975.9s -> 6386.6s (+6.9%)
i686-gnu-2: 5052.4s -> 5381.7s (+6.5%)
aarch64-msvc-1: 6811.3s -> 7240.7s (+6.3%)
x86_64-mingw-1: 9600.2s -> 10194.1s (+6.2%)
aarch64-msvc-2: 6242.8s -> 5915.9s (-5.2%)
dist-aarch64-linux: 6395.9s -> 6690.1s (+4.6%)
aarch64-gnu: 7541.5s -> 7213.8s (-4.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-31T10:27:18Z

Finished benchmarking commit (1e9be1b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.2%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	1
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[-2.0%, 2.4%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.1%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.7%]	7
Regressions ❌ (secondary)	0.2%	[0.0%, 0.3%]	5
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.1%, 0.7%]	8

Bootstrap: 474.479s -> 474.929s (0.09%)
Artifact size: 397.88 MiB -> 397.85 MiB (-0.01%)

lolbinarycat and others added 12 commits August 5, 2025 12:40

core: add Option::get_or_try_insert_with

b8955c5

Co-authored-by: kennytm <kennytm@gmail.com>

Remove duplicated code in slice/index.rs

50a9b17

Looks like `const fn` is far enough along now that we can just not have these two copies any more, and have one call the other.

Implement BinaryHeap::pop_if()

9928723

Fix typo for Maybe dangling docs

959595f

Boxe's -> Box's

Add shift_{left,right} on slices

4264da6

cc tracking issue 151772

Address review comments and fix tests

bae7a19

Use Bound::copied instead of Bound::cloned

a3f169c

Rollup merge of rust-lang#143650 - lolbinarycat:core-option_get_or_tr…

e142458

…y_insert_with-143648, r=jhpratt core: add Option::get_or_try_insert_with Implementation for rust-lang#143648

Rollup merge of rust-lang#151726 - scottmcm:delete-duplicated-code, r…

b60d3d9

…=jhpratt Remove duplicated code in `slice/index.rs` Looks like `const fn` is far enough along now that we can just not have these two copies any more, and have one call the other.

Rollup merge of rust-lang#151812 - scottmcm:slice-shift, r=jhpratt

4e21b69

Add `shift_{left,right}` on slices ACP approval: rust-lang/libs-team#717 (comment) cc tracking issue rust-lang#151772

Rollup merge of rust-lang#151829 - max-heller:binary-heap-pop-if, r=j…

f4c2816

…hpratt,joboet Implement `BinaryHeap::pop_if()` Implementation of rust-lang#151828

Rollup merge of rust-lang#151838 - ionicmc-rs:patch-1, r=jhpratt

4b850fa

Fix typo for Maybe dangling docs Boxe's -> Box's

rust-bors bot added the rollup A PR which is a rollup label Jan 31, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 31, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 31, 2026

rust-bors bot merged commit 1e9be1b into rust-lang:main Jan 31, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Jan 31, 2026

This was referenced Jan 31, 2026

Optimize indexing slices and strs with inclusive ranges #145024

Open

Add methods to split off array chunks from slices #150117

Open

jhpratt deleted the rollup-cG0AjgK branch February 3, 2026 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests#151891

Rollup of 5 pull requests#151891
rust-bors[bot] merged 12 commits intorust-lang:mainfrom
jhpratt:rollup-cG0AjgK

jhpratt commented Jan 31, 2026

Uh oh!

jhpratt commented Jan 31, 2026

Uh oh!

rust-bors bot commented Jan 31, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 31, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 31, 2026

Uh oh!

github-actions bot commented Jan 31, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

jhpratt commented Jan 31, 2026

Uh oh!

jhpratt commented Jan 31, 2026

Uh oh!

rust-bors bot commented Jan 31, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 31, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 31, 2026

Uh oh!

github-actions bot commented Jan 31, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jan 31, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants