Rollup of 5 pull requests#151924
Merged
rust-bors[bot] merged 12 commits intorust-lang:mainfrom Feb 1, 2026
Merged
Conversation
…d-allocation-box-ref, r=petrochenkov Skip unused_allocation lint when method takes &Box<Self> Fixes rust-lang#151846
Constify `fmt::from_fn` See <rust-lang#117729 (comment)>.
…shorthand-gate, r=JonathanBrouwer Feature-gate `mut ref` patterns in struct pattern field shorthand Tracking issue for `mut_ref` (and other parts of Match Ergonomics 2024): rust-lang#123076 rust-lang#123080 introduced `mut ref`[^1] patterns (for by-reference bindings where the binding itself is mutable), feature-gated behind the `mut_ref` feature, except for in struct pattern shorthand, where the feature gating was missing. Thus, `mut ref` patterns in struct pattern shorthand has been unintentionally stable for ~18 months (since 1.79.0 ([compiler explorer](https://rust.godbolt.org/z/4WTrvhboT))). This PR adds feature-gating for `mut ref` patterns in struct pattern shorthand. Since this is reverting an accidental stabilization, this probably needs a crater run and a T-lang FCP? Some alternative possibilities: * Do nothing (let the inconsistency exist until `feature(mut_ref)` is stabilized) * Document the existing behavior * Do a FCW instead of fully feature-gating * Stabilize `feature(mut_ref)` CC rust-lang#123080 (comment) CC @Nadrieril [^1]: everything in this description also applies analogously to `mut ref mut` patterns.
Reorganizing `tests/ui/issues` 10 tests [4/N] part of rust-lang#133895 r? Kivooeo
Re-export `hashbrown::hash_table` from `rustc_data_structures` We don't always re-export shared dependencies, but for `hashbrown::hash_table` I think it makes sense, for a few reasons: - The lower-level `HashTable` type is already part of the public API of `rustc_data_structures` via the `ShardedHashMap` type alias, and other compiler crates currently depend on being able to access its internal hash tables. - The `Cargo.toml` entry for `hashbrown` is non-trivial, making it harder to keep in sync and harder to move between crates as needed. - [And we currently aren't using `[workspace.dependencies]` for various reasons.](rust-lang#146113) - It's fine for other compiler crates to use `hash_table` specifically (with care), but they probably shouldn't be using the higher-level `hashbrown::HashMap` and `hashbrown::HashSet` types directly, because they should prefer the various map/set aliases defined by `rustc_data_structures`. Re-exporting only `hash_table` helps to discourage use of those other types. There should be no change to compiler behaviour.
rustbot
added
A-query-system
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
This was referenced Feb 1, 2026
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 905b926967 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 905b926 (parent) -> a1db344 (this PR) Test differencesShow 44 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a1db344c0829cb682df4174e9370b60915751605 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (a1db344): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 1.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 477.374s -> 476.042s (-0.28%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
fmt::from_fn#150300 (Constifyfmt::from_fn)mut refpatterns in struct pattern field shorthand #151102 (Feature-gatemut refpatterns in struct pattern field shorthand)tests/ui/issues10 tests [4/N] #151866 (Reorganizingtests/ui/issues10 tests [4/N] )hashbrown::hash_tablefromrustc_data_structures#151890 (Re-exporthashbrown::hash_tablefromrustc_data_structures)r? @ghost
Create a similar rollup