Rename and split some modules in the query system

[Zoxc]

This renames rustc_query_system::query::plumbing to execution and splits rustc_middle::query::plumbing into macros and system modules. This reduces the modules named plumbing in the query system from 3 to 1.

[rustbot]

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Zoxc]

@bors try @rust-timer queue

[Zoxc]

cc @nnethercote @Zalathar

[rust-bors]

💔 Test for 99b5429 failed: CI

[Zalathar]

I like the motivation (not having three plumbing modules, and splitting things up a bit), but I'm concerned that these particular names/splits might end up being differently-confusing instead of better.

I'll try to go into more detail later when I have time.

[nnethercote]

r? @Zalathar

[Zoxc]

I think the execution one is ok, as that is the main supporting part for execution queries. I'm not too worried about the other being side grades, given that we probably want some reorganization if we merge rustc_query_system anyway.

[Zoxc]

@bors try @rust-timer queue

[rust-bors]

☔ The latest upstream changes (presumably #152006) made this pull request unmergeable. Please resolve the merge conflicts.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 5e694ae (5e694aecf48600c15db5b4d41607abd70813dad6, parent: f60a0f1bcc5a2a6dd8eb2d2021da79b40f5fbae9)

[rust-timer]

Finished benchmarking commit (5e694ae): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.1%	[2.4%, 3.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[2.4%, 3.7%]	2

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.1%, 4.6%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	10
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	10

Bootstrap: 470.454s -> 469.646s (-0.17%)
Artifact size: 397.65 MiB -> 397.72 MiB (0.02%)