Port rustc_reservation_impl to the new attribute parser#152180
Port rustc_reservation_impl to the new attribute parser#152180jdonszelmann wants to merge 1 commit intorust-lang:mainfrom
rustc_reservation_impl to the new attribute parser#152180Conversation
|
Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
A-attributes
| RustcReallocator, | ||
|
|
||
| /// Represents `#[rustc_reservation_impl]` | ||
| RustcReservationImpl(Span, Option<Symbol>), |
There was a problem hiding this comment.
I don't think the argument for this should be optional, the template is template!(NameValueStr: "reservation message") and I don't see it used without an argument anywhere
There was a problem hiding this comment.
the template is wrong (and I updated it), old code assumes its optional (which was never checked) and some tests do use it without
There was a problem hiding this comment.
I think the only place that still uses it optionally is a random rust-analyzer test, from what I can find.
I have some doubts about how correct the logic in rustc_trait_selection is if we don't have a message, there the attribute seems to be ignored if it has no message.
There was a problem hiding this comment.
Hmmm, it looked like that was only for diagnostics, but fair lemme make it required
|
@rustbot author |
rustbot
removed
the
S-waiting-on-review
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
|
☔ The latest upstream changes (presumably #152213) made this pull request unmergeable. Please resolve the merge conflicts. |
3 participants
r? @JonathanBrouwer