Convert to inline diagnostics in rustc_const_eval#152186
Convert to inline diagnostics in rustc_const_eval#152186GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
rustc_const_eval#152186Conversation
|
Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred to constck cc @fee1-dead
cc @rust-lang/wg-const-eval Some changes occurred to the CTFE machinery |
| DanglingIntPointer { addr: 0, .. } => inline_fluent!("{$operation -> | ||
| [MemoryAccess] memory access failed | ||
| [InboundsPointerArithmetic] in-bounds pointer arithmetic failed |
There was a problem hiding this comment.
Here and in many other places, the indentation is rather broken, making this quite hard to read. Is there a way to avoid that?
There was a problem hiding this comment.
On my PRs I manually indented all of these to align with the surrounding code, is very possible to fix :)
| @@ -1,10 +1,12 @@ | |||
| //! Manages calling a concrete function (with known MIR body) with argument passing, | |||
| //! and returning the return value to the caller. | |||
| //! and returning the return value to the caller.use rustc_errors::inline_fluent; | |||
There was a problem hiding this comment.
Something seems to have gone wrong here...
| = note: see issue #143874 <https://github.com/rust-lang/rust/issues/143874> for more information | ||
| = help: add `#![feature(const_trait_impl)]` to the crate attributes to enable | ||
| = note: this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date | ||
| = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no` |
There was a problem hiding this comment.
Why did this diagnostic change?
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@rustbot author |
|
☔ The latest upstream changes (presumably #152213) made this pull request unmergeable. Please resolve the merge conflicts. |
Part of #151366.
r? @JonathanBrouwer