Convert to inline diagnostics in rustc_parse#152235
Convert to inline diagnostics in rustc_parse#152235JonathanBrouwer wants to merge 4 commits intorust-lang:mainfrom
rustc_parse#152235Conversation
|
cc @davidtwco, @TaKO8Ki |
9e60262 to
cac92f3
Compare
cac92f3 to
4c4734e
Compare
|
If this is such a common operation, why don't we have PSess::empty(). That might be nicer actually |
|
I thought about it, but in a few days after the other crates are translated I can just remove the argument from |
| //@ needs-subprocess | ||
|
|
||
| // FIXME(151366) Currently `-Ztranslate-additional-ftl` is currently broken | ||
| //@ ignore-test |
There was a problem hiding this comment.
@jdonszelmann I accidentally broke the unstable -Ztranslate-additional-ftl option. This option can be used to override translation messages. This is already broken on nightly, it's just that the only test using this option happened to use rustc_parse.
I should be able to repair this with a little bit of effort, might take me a few days and this PR is very brittle, so would prefer to do this in a separate PR. I added this to the tracking issue so it is not forgotten. You can r+ if you agree with this approach
This comment has been minimized.
This comment has been minimized.
2d88985 to
0a83d32
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
☔ The latest upstream changes (presumably #152264) made this pull request unmergeable. Please resolve the merge conflicts. |
This was the most annoying one by far, had to make a few changes to the representation of two errors (no user-facing changes tho), these changes are in separate commits for clarity :)
For #151366
r? @jdonszelmann