[BETA]: parse array lengths without stripping const blocks#152237
Open
BoxyUwU wants to merge 1 commit intorust-lang:betafrom
Open
[BETA]: parse array lengths without stripping const blocks#152237BoxyUwU wants to merge 1 commit intorust-lang:betafrom
BoxyUwU wants to merge 1 commit intorust-lang:betafrom
Conversation
BoxyUwU
added
the
beta-nominated
rustbot
added
S-waiting-on-review
Collaborator
|
|
Collaborator
|
BoxyUwU
added
beta-nominated
oli-obk
approved these changes
Feb 6, 2026
BoxyUwU
force-pushed
the
beta_parse_array_lengths_normally
branch
from
7745534 to
01703e3
Compare
Collaborator
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
rustbot
added
the
T-rustfmt
Member
Author
|
(added the rustfmt tests) |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids rust-lang/rustfmt#6788
When parsing
const { ... }in array lengths we were stripping the const block and just parsing a block expression which is wrong. This PR reverts the behaviour back to the (previously stable) logic of just parsing an anon const.This PR breaks
min_generic_const_argsbut that doesn't matter its an unstable feature :) I've just deleted the mGCA tests which were affected by this. A proper fix for this is in #152234 but I don't think that should be backported as it's too involved.cc @rust-lang/rustfmt
r? oli-obk