Canonicalize free regions from inputs as placeholders in root univ#155487
Canonicalize free regions from inputs as placeholders in root univ#155487ShoyuVanilla wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Canonicalize free regions from inputs as placeholders in root univ
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (e39d9d1): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.8%, secondary 3.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -3.2%, secondary 0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 493.313s -> 494.404s (0.22%) |
|
r? lcnr |
| = note: closure with signature `for<'a> fn(&'a &'2 str) -> bool` must implement `FnOnce<(&&'1 str,)>`, for any lifetime `'1`... | ||
| = note: ...but it actually implements `FnOnce<(&&'2 str,)>`, for some specific lifetime `'2` | ||
| = note: closure with signature `for<'a> fn(&'a &'0 str) -> bool` must implement `FnOnce<(&&'1 str,)>`, for any two lifetimes `'0` and `'1`... | ||
| = note: ...but it actually implements `FnOnce<(&&str,)>` |
There was a problem hiding this comment.
We have lots of those ...but it actually implements X for some specific lifetime '?x -> ...but it actually implements X for some specific lifetime diagnostic drifts due to the canonicalized region being placeholders rather than region vars.
I think this is somewhat regressive. Would it make sense to fix them somehow?
Context: The box named coroutine witness Send lifetime requirements now considered by leakcheck this roadmap
Fixes #106569
Prerequisite of #155749