-Znext-solver Eager normalization outside of solver #155767
-Znext-solver Eager normalization outside of solver #155767adwinwhite wants to merge 9 commits intorust-lang:mainfrom
-Znext-solver Eager normalization outside of solver #155767Conversation
|
does this fix #151308 ? |
This comment has been minimized.
This comment has been minimized.
Yes, it probably fixes a bunch of issues. And unfix some issues fixed by the next solver? Unsure about that. |
34677fc to
e4b9746
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
`-Znext-solver` Eager normalization outside of solver
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (59cc905): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.5%, secondary -1.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 491.487s -> 483.564s (-1.61%) |
This PR adds a normalization routine for the next solver that behaves the same as the normalization in the old solver.
And it's used to normalize eagerly outside of the next solver.
This is part 2 of modifying the next solver to support eager normalization.
Those test changes are all wording changes, duplicating some errors or reducing some duplicates. But I could have overlooked something.
Notably it fixes the first example of rust-lang/trait-system-refactor-initiative#191, but not the remaining cases.
It's probably easier to review commit by commit.
WIP: maybe remove old
deeply_normalizer? @ghost