Build bootstrap with an explicit target#155771
Build bootstrap with an explicit target#155771chenyukang wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
This sounds like a hack to make bootstrap match a specific kind of Cargo config. We should instead ask Cargo where was the generated binary stored, or use |
8d9b418 to
dfe540e
Compare
dfe540e to
7e0430f
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
oh, I did something wrong on Git and closed it. |
This comment has been minimized.
This comment has been minimized.
12db296 to
d46bb0d
Compare
This comment has been minimized.
This comment has been minimized.
d46bb0d to
6985a7e
Compare
This is not trying to guess an arbitrary Cargo output path. We explicitly pass --target self.build, so the bootstrap binary location follows Cargo’s normal target-dir layout under CARGO_TARGET_DIR//debug. This relies on Cargo’s standard target-dir layout. I tried to use By “ask Cargo where the generated binary was stored”, do you mean using Cargo’s JSON messages and reading the compiler-artifact.executable field? |
Fixes #155651