Skip to content

privacy: document unordered visibility limit #155792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SynapLink wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

privacy: document unordered visibility limit #155792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions compiler/rustc_middle/src/middle/privacy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,11 @@ impl<Id: Eq + Hash> EffectiveVisibilities<Id> {
if !(inherited_effective_vis_at_prev_level == inherited_effective_vis_at_level
&& level != l)
{
// FIXME: figure out why unordered visibilities occur here,
// and what the behavior for them should be.
// Restricted visibilities form a tree, so restrictions to sibling modules
// are unordered. That can happen here when effective visibility is inherited
// through one module, but the nominal visibility limit comes from another.
// There is no single `Visibility` that represents their intersection, so
// preserve the inherited visibility instead of applying the limit.
calculated_effective_vis = if let Some(max_vis) = max_vis
&& inherited_effective_vis_at_level.partial_cmp(max_vis, tcx)
== Some(Ordering::Greater)
Expand Down
Loading