Add AArch64 features to whitelist#48570
Merged
bors merged 2 commits intorust-lang:masterfrom Mar 2, 2018
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
Member
|
r=me, thanks! Looks like there's a travis failure though? |
Amanieu
force-pushed
the
aarch64_features
branch
2 times, most recently
from
7fdc596 to
3e2c81c
Compare
Member
Author
|
It should be fixed now. |
Member
|
@bors: r+ |
Collaborator
|
📌 Commit 3e2c81c has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
LGTM. We spoke about this on IRC and doing the same thing that clang and gcc do is the only reasonable thing that can be done here for the time being. If we ever get a backend with finer-grained control we can always add finer-grained features. Run-time feature detection would need to some of these as a bundle in |
Member
|
@bors: rollup |
Collaborator
|
☔ The latest upstream changes (presumably #48608) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
It isn't a valid LLVM feature for this architecture.
Amanieu
force-pushed
the
aarch64_features
branch
from
3e2c81c to
f756ad3
Compare
Member
Author
|
Fixed merge conflict. |
Member
|
@bors: r+ |
Collaborator
|
📌 Commit f756ad3 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
pushed a commit
to Manishearth/rust
that referenced
this pull request
Mar 1, 2018
…chton Add AArch64 features to whitelist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @alexcrichton