Merged
Conversation
Users coming from other languages (namely C and C++) often expect to use a -Wall flag. Rustc doesn't support that, and previously it simply printed that it didn't recognize the "all" lint. This change makes rustc print out a help message, explaining: - Why there is no -Wall flag - How to view all the available warnings - Point out that the most commonly used warning is -Wunused - Instead of using a command-line flag, the user should consider a !#[warn(unused)] directive in the root of their crate.
See this page for details about FPXX: https://dmz-portal.mips.com/wiki/MIPS_O32_ABI_-_FR0_and_FR1_Interlinking Using FPXX is the most compatible floating point mode available and allows the generated code to work in both FR0 and FR1 modes of the processor. Using MSA (MIPS SIMD) requires FR1, so to use any MSA code we need a compatible floating point mode. This commit also sets nooddspreg (disabling the use of odd numbered single precision float registers) as recommended when enabling FPXX.
On 32-bit MIPS, enabling MSA requires also enabling the 64-bit FPU.
The reference to -Wunused was removed, and some phrasing was changed.
Looks like LLD doesn't support this yet, so always try to use the OS before we fall back to using `@`
Resolves rust-lang#48070. The bug itself was fixed by rust-lang#48770, but that PR didn't add a test for it.
Contributor
|
Some changes occurred in HTML/CSS. |
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
@bors r+ p=11 |
Collaborator
|
📌 Commit b1e90d1 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit b1e90d19a90a0f3213ed7beece35ad98addee3a4 with merge d4a891f0ce93b24b2f93e448a23ed26b1575d710... |
Collaborator
|
💔 Test failed - status-travis |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-bors
Collaborator
|
📌 Commit 25e20df has been approved by |
Collaborator
|
🔒 Merge conflict |
bors
added
S-waiting-on-author
…, r=estebank Add info message for -Wall command Users coming from other languages (namely C and C++) often expect to use a -Wall flag. Rustc doesn't support that, and previously it simply printed that it didn't recognize the "all" lint. This change makes rustc print out a help message, explaining: - Why there is no -Wall flag - How to view all the available warnings - Point out that the most commonly used warning is -Wunused - Instead of using a command-line flag, the user should consider a !#[warn(unused)] directive in the root of their crate. I tried to keep the language consistent with the other usage help. Comment if I should change anything. closes rust-lang#10234, if accepted.
…uietMisdreavus Fix blink when main theme is selected r? @QuietMisdreavus
Remove some unnecessary IdxSet methods This replaces `IdxSet:: reset_to_empty` with `IdxSet:: clear`, and `IdxSet::elems`/`IdxSet::each_bit` with `IdxSet::iter`. Based on some [comments on #rustc](https://botbot.me/mozilla/rustc/2018-01-23/?msg=96063396). r? @pnkfelix
…llaumeGomez
tweak code fences in the rustdoc book
You can stack backticks to create "big code fences" if you're documenting some markdown and need to have code fences inside your code fences. This is especially important in this spot in the Rustdoc Book, because we're showing that using no language specifier on your code blocks is interpreted as using `rust`, but the code blocks here lose their code fences!
`````````markdown
``````markdown
Just showing some recursion, nbd.
```rust
println!("sup");
```
``````
(If you have edit powers in the rust-lang/rust repo, hit the edit button to view the source and see even more recursion :P)
`````````
…tMisdreavus Add missing examples r? @QuietMisdreavus
Move librustc_typeck READMEs to rustc guide cc rust-lang/rustc-dev-guide#2 and rust-lang#48478 Don't merge this before rust-lang/rustc-dev-guide#85 r? @nikomatsakis
…aelwoerister rustc: Don't invoke `lld` with an `@`-file Looks like LLD doesn't support this yet, so always try to use the OS before we fall back to using `@` cc rust-lang#48948
…atsakis Add a test for rust-lang#48070 Resolves rust-lang#48070. The bug itself was fixed by rust-lang#48770, but that PR didn't add a test for it. r? @nikomatsakis
Clarify usage message for --remap-path-prefix.
…on, r=michaelwoerister Speed up SVH computation by using Fingerprint::combine() Fix rust-lang#47297
…rister fix rust-lang#48816 don't print help on indirect compiler ICE rust-lang#48816 (comment)
bump mipsel isa leval and enable fpxx This PR: * Bumps the default ISA level of the mipsel targets to `mips32r2`. The big endian mips targets are already built with `mips32r2`. This is the usual baseline for the MIPS ISA these days used by other projects, although it does drop support for the 4K processor (which was the only processor released with mips32 r1). Debian no longer supports pre-R2 processors. Using R2 also improves code generation in FPXX in certain circumstances. * Enables the FPXX floating point ABI[1] on 32-bit hard-float targets by default. This ABI adds some extra restrictions to the existing ABI which allows code to run on the two main floating point modes found on MIPS (FR0 and FR1) and remains compatible with the FR32 ABI currently in use. All code within an executable (including all shared libraries) must be compiled with FPXX/FP64 to be able to use MSA on 32-bit MIPS. * Enables the "nooddspreg" feature with FPXX. This feature is usually enabled whenever FPXX is. It also helps workaround some issues on Loongson processors. I'm hoping this will fix some test failures mentioned in rust-lang#39013. * Adds the `fp64` feature to the MIPS whitelist. This feature must be enabled to use MSA on 32-bit MIPS, otherwise LLVM will complain. [1] See https://dmz-portal.mips.com/wiki/MIPS_O32_ABI_-_FR0_and_FR1_Interlinking
Member
Author
Collaborator
|
📌 Commit beab2e6 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lldwith an@-file #48981, Add a test for #48070 #48988, Clarify usage message for --remap-path-prefix. #48991, Speed up SVH computation by using Fingerprint::combine() #48966, fix #48816 don't print help on indirect compiler ICE #48993, bump mipsel isa leval and enable fpxx #48874