Merged
Conversation
Contributor
|
r? @KodrAus (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
7 tasks
kennytm
added
T-libs-api
Member
|
@bors: r+ 🎉 |
Collaborator
|
📌 Commit f7197fb has been approved by |
bors
added
S-waiting-on-bors
kennytm
reviewed
May 16, 2018
Member
There was a problem hiding this comment.
Huh, this is strange. cc @GuillaumeGomez @QuietMisdreavus @Phlosioneer (#49196)
I thought #49123 has been fixed?
Contributor
Author
There was a problem hiding this comment.
Oh, this is a rebase of an old branch, this change is probably not necessary anymore. Removed.
It is now an implementation detail of ptr::NonNull and num::NonZero*
Tracking issue: rust-lang#49137
Member
|
@bors r=alexcrichton |
Collaborator
|
📌 Commit 89d9ca9 has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
May 16, 2018
Stabilize num::NonZeroU* Tracking issue: rust-lang#49137
bors
added a commit
that referenced
this pull request
May 17, 2018
Rollup of 17 pull requests Successful merges: - #50170 (Implement From for more types on Cow) - #50638 (Don't unconditionally set CLOEXEC twice on every fd we open on Linux) - #50656 (Fix `fn main() -> impl Trait` for non-`Termination` trait) - #50669 (rustdoc: deprecate `#![doc(passes, plugins, no_default_passes)]`) - #50726 (read2: Use inner function instead of closure) - #50728 (Fix rustdoc panic with `impl Trait` in type parameters) - #50736 (env: remove unwrap in examples in favor of try op) - #50740 (Remove LazyBTreeMap.) - #50752 (Add missing error codes in libsyntax-ext asm) - #50779 (Make mutable_noalias and arg_align_attributes be tracked) - #50787 (Fix run-make wasm tests) - #50788 (Fix an ICE when casting a nonexistent const) - #50789 (Ensure libraries built in stage0 have unique metadata) - #50793 (tidy: Add a check for empty UI test files) - #50797 (fix a typo in signed-integer::from_str_radix()) - #50808 (Stabilize num::NonZeroU*) - #50809 (GitHub: Stop treating Cargo.lock as a generated file.) Failed merges:
This was referenced May 19, 2018
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 20, 2021
…nnytm fix 'const-stable since' for NonZeroU*::new_unchecked For the unsigned `NonZero` types, `new_unchecked` was const-stable from the start with rust-lang#50808. Fix the docs to accurately reflect that. I think this `since` is also incorrect: ```rust #[stable(feature = "from_nonzero", since = "1.31.0")] impl From<$Ty> for $Int { ``` The signed nonzero types were only stabilized in 1.34, so that `From` impl certainly didn't exist before. But I had enough of digging through git histories after I figured out when `new_unchecked` became const-stable...^^
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 21, 2021
…nnytm fix 'const-stable since' for NonZeroU*::new_unchecked For the unsigned `NonZero` types, `new_unchecked` was const-stable from the start with rust-lang#50808. Fix the docs to accurately reflect that. I think this `since` is also incorrect: ```rust #[stable(feature = "from_nonzero", since = "1.31.0")] impl From<$Ty> for $Int { ``` The signed nonzero types were only stabilized in 1.34, so that `From` impl certainly didn't exist before. But I had enough of digging through git histories after I figured out when `new_unchecked` became const-stable...^^
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Apr 21, 2021
…nnytm fix 'const-stable since' for NonZeroU*::new_unchecked For the unsigned `NonZero` types, `new_unchecked` was const-stable from the start with rust-lang#50808. Fix the docs to accurately reflect that. I think this `since` is also incorrect: ```rust #[stable(feature = "from_nonzero", since = "1.31.0")] impl From<$Ty> for $Int { ``` The signed nonzero types were only stabilized in 1.34, so that `From` impl certainly didn't exist before. But I had enough of digging through git histories after I figured out when `new_unchecked` became const-stable...^^
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Apr 21, 2021
…nnytm fix 'const-stable since' for NonZeroU*::new_unchecked For the unsigned `NonZero` types, `new_unchecked` was const-stable from the start with rust-lang#50808. Fix the docs to accurately reflect that. I think this `since` is also incorrect: ```rust #[stable(feature = "from_nonzero", since = "1.31.0")] impl From<$Ty> for $Int { ``` The signed nonzero types were only stabilized in 1.34, so that `From` impl certainly didn't exist before. But I had enough of digging through git histories after I figured out when `new_unchecked` became const-stable...^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #49137