Conversation
f9a15aa to
5233a12
Compare
|
@bors try |
Make causal tracking lazy Closes #51710 r? @nikomatsakis
|
cc @Mark-Simulacrum — once this try build is done, would be great to get perf results |
|
☀️ Test successful - status-travis |
|
cc @Mark-Simulacrum ok, bors try is done, perf run please 😁 |
|
r=me but I'd like to see a perf run first |
|
I think I forgot to leave a comment -- https://perf.rust-lang.org/compare.html?start=57dd722606028cafde656a66edc3206b82cd3bab&end=f3375ed0f41c0e04b61e51e54df12456d7a57bbf&stat=instructions%3Au is done. Since perf is positive across the board, @bors r=nikomatsakis |
|
📌 Commit 5233a12 has been approved by |
|
☔ The latest upstream changes (presumably #51855) made this pull request unmergeable. Please resolve the merge conflicts. |
5233a12 to
2964c66
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
2964c66 to
71f25b4
Compare
|
@bors r= |
|
📌 Commit 71f25b4 has been approved by `` |
|
@bors r+ |
|
📌 Commit 71f25b4 has been approved by |
…tsakis Make causal tracking lazy Closes #51710 r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
|
Didn't this PR partially regress the diagnostic quality of the test for #47646 ? I'm referring in particular to this: 0957ede#diff-46590a131be6d28cb3935ef7907f3ec4L7 (and likewise here 0957ede#diff-46590a131be6d28cb3935ef7907f3ec4L14 ) |
Closes #51710
r? @nikomatsakis