Added new lines to .gitignore.#52615
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
.gitignore
Outdated
There was a problem hiding this comment.
maybe TAGS and TAGS.*? this "open-ended glob" makes me a touch nervous for some silly reason
.gitignore
Outdated
There was a problem hiding this comment.
I wind up with mir_dump directories scattered al over (e.g., often in src/test/ui) -- maybe we can make this a more general case? I forget what leading / means though.
There was a problem hiding this comment.
IIRC, the / just makes it match from the root of the repository. I've removed the / so it should match anywhere in the tree.
.gitignore
Outdated
There was a problem hiding this comment.
It might make sense to add this to your personal ~/.gitignore (that is where I have e.g. *~, which rules out emacs backup files). But I don't really mind putting it here also.
There was a problem hiding this comment.
I'll do that, I forgot that's a thing you could do. I'll leave it here though because it doesn't hurt.
davidtwco
force-pushed
the
add-to-gitignore
branch
from
8f7aa99 to
c645ecd
Compare
|
@bors r=nikomatsakis,Mark-Simulacrum rollup |
|
📌 Commit c645ecd has been approved by |
bors
added
S-waiting-on-bors
…atsakis,Mark-Simulacrum Added new lines to .gitignore. There are a handful of files that I often find in my local working directories that I never want to commit that aren't covered in the `.gitignore` file: `/mir_dump`: Default output location from `-Z mir-dump=all` for a specific test, I can't think of a reason why this should ever be commited. `tags*`/`TAGS*`: I use `vim-gutentags` which outputs `tags` and `tags.temp` which I don't want commited. I also collapsed the `TAGS`, `TAGS.vi`, `TAGS.emacs` into `TAGS*`. `Session.vim`: I use `vim-obsession` to save my current session in Vim, it outputs a `Session.vim` file, this also shouldn't be commited.
Rollup of 11 pull requests Successful merges: - #51807 (Deprecation of str::slice_unchecked(_mut)) - #52051 (mem::swap the obvious way for types smaller than the SIMD optimization's block size) - #52465 (Add CI test harness for `thumb*` targets. [IRR-2018-embedded]) - #52507 (Reword when `_` couldn't be inferred) - #52508 (Document that Unique::empty() and NonNull::dangling() aren't sentinel values) - #52521 (Fix links in rustdoc book.) - #52581 (Avoid using `#[macro_export]` for documenting builtin macros) - #52582 (Typo) - #52587 (Add missing backtick in UniversalRegions doc comment) - #52594 (Run the error index tool against the sysroot libdir) - #52615 (Added new lines to .gitignore.)
I don't think that's enough of a justification to leave these files as junk in everyones working dir. If you have some files you want to ignore, just add them to Cc #63307 |
6 participants
There are a handful of files that I often find in my local working directories that I never want to commit that aren't covered in the
.gitignorefile:/mir_dump:Default output location from
-Z mir-dump=allfor a specific test, I can't think of a reason why this should ever be commited.tags*/TAGS*:I use
vim-gutentagswhich outputstagsandtags.tempwhich I don't want commited. I also collapsed theTAGS,TAGS.vi,TAGS.emacsintoTAGS*.Session.vim:I use
vim-obsessionto save my current session in Vim, it outputs aSession.vimfile, this also shouldn't be commited.