Upgrade LLVM to trunk, still version 8#55835
Merged
bors merged 7 commits intorust-lang:masterfrom Nov 26, 2018
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
rust-highfive
added
the
S-waiting-on-review
Member
Author
|
@bors: try |
Collaborator
bors
added a commit
that referenced
this pull request
Nov 10, 2018
Upgrade LLVM to trunk, still version 8 This commit upgrades the LLVM/LLD/compiler-rt submodules used to the current trunk versions in upstream. Some activity has happened on the wasm SIMD side of things as well as LLD which we'd like to pick up!
Collaborator
|
💔 Test failed - status-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
added
S-waiting-on-author
alexcrichton
force-pushed
the
llvm-upgrade
branch
from
67053e5 to
224ec5c
Compare
Member
Author
|
@bors: try Gotta prime those caches |
Collaborator
|
⌛ Trying commit 224ec5c3a984f1a98dc9a2cd08ef2ae005471d63 with merge dbda7ea8913700f3c33951571c2cad2ea416d88e... |
Member
Author
|
@rust-timer build dbda7ea8913700f3c33951571c2cad2ea416d88e |
Collaborator
|
Success: Queued dbda7ea8913700f3c33951571c2cad2ea416d88e with parent 42959a2, comparison URL. |
Collaborator
|
☔ The latest upstream changes (presumably #54864) made this pull request unmergeable. Please resolve the merge conflicts. |
Collaborator
|
Finished benchmarking try commit dbda7ea8913700f3c33951571c2cad2ea416d88e |
Member
Author
|
Well by golly gee those are some good numbers, surprising! |
Contributor
|
Those are some very nice results! At least the improvements on inflate are primarilty due to https://reviews.llvm.org/D53245 -- this used to spend ~25% of the time applying DomTree updates in JumpThreading and now no longer does. |
alexcrichton
force-pushed
the
llvm-upgrade
branch
from
1ff0bef to
28d7334
Compare
Member
Author
|
Rebased! I've done some (hopefully) thorough testing locally and I've discovered... amazingly zero regressions! Should be ready to go! |
Contributor
|
Hi Alex, Thanks for dealing with this. It should have really been me doing the work, since I spawned the discussion! I was wondering: do you have a way to check for performance regressions? Thanks |
Contributor
|
Ah yes, I see you have a benchmarking bot :) Neat. |
Member
Author
|
@vext01 oh no worries! I ended up wanting to do it for unrelated reasons anyway and figured I could help bootstrap the process at least, I didn't expect it to go so smoothly, but I'm sure bors will have a thing or two to say about that |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 28d73341204480bbbd82b189ee84f839bf8dd208 has been approved by |
bors
removed
the
S-waiting-on-author
Our mangling scheme is not C++'s, so tell LLD to not demangle anything so we can handle Rust-specific demangling ourselves.
This should handle recent symbol visibility changes happening, although we'll likely want to tweak this in the future!
alexcrichton
force-pushed
the
llvm-upgrade
branch
from
629a9ed to
7215963
Compare
Member
Author
|
Oops, forgot to disable LLDB @bors: r=nikomatsakis |
Collaborator
|
📌 Commit 7215963 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Nov 26, 2018
Upgrade LLVM to trunk, still version 8 This commit upgrades the LLVM/LLD/compiler-rt submodules used to the current trunk versions in upstream. Some activity has happened on the wasm SIMD side of things as well as LLD which we'd like to pick up!
Collaborator
|
💔 Test failed - status-travis |
bors
added
S-waiting-on-review
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
Author
|
@bors: retry |
bors
added
S-waiting-on-bors
Member
Collaborator
bors
added a commit
that referenced
this pull request
Nov 26, 2018
Upgrade LLVM to trunk, still version 8 This commit upgrades the LLVM/LLD/compiler-rt submodules used to the current trunk versions in upstream. Some activity has happened on the wasm SIMD side of things as well as LLD which we'd like to pick up!
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Contributor
|
Final perf results from the landing are here. Very nice results, mostly on opt builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit upgrades the LLVM/LLD/compiler-rt submodules used to the current trunk versions in upstream. Some activity has happened on the wasm SIMD side of things as well as LLD which we'd like to pick up!