Rollup of 19 pull requests#55902
Closed
emilyalbini wants to merge 61 commits intorust-lang:masterfrom
Closed
Conversation
…ent's terminating semicolon.
…ock's tail (if present).
(I opted to rely on compare-mode=nll rather than opt into `#![feature(nll)]`, mostly to make it easy to observe the interesting differences between the AST-borrwock diagnostic and the NLL one.)
…d documented) methods.
… of PATH.
This restores the previous behavior where if env_clear() or env_remove("PATH") was used we fall back to a default PATH of "/bin:/usr/bin"
miri: accept extern types in structs if they are the only field Fixes rust-lang#55541 Cc @oli-obk @eddyb rust-lang#43467
…k-Simulacrum Format BtreeMap::range_mut example Before:  After: 
… r=alexcrichton Avoid converting bytes to UTF-8 strings to print, just pass bytes to stdout/err r? @nikomatsakis
…pans-for-temps-and-their-drops, r=davidtwco More precise spans for temps and their drops This PR has two main enhancements: 1. when possible during code generation for a statement (like `expr();`), pass along the span of a statement, and then attribute the drops of temporaries from that statement to the statement's end-point (which will be the semicolon if it is a statement that is terminating by a semicolon). 2. when evaluating a block expression into a MIR temp, use the span of the block's tail expression (rather than the span of whole block including its statements and curly-braces) for the span of the temp. Each of these individually increases the precision of our diagnostic output; together they combine to make a much clearer picture about the control flow through the spans. Fix rust-lang#54382
…xcrichton Add mem::forget_unsized() for forgetting unsized values ~~Allows passing values of `T: ?Sized` types to `mem::drop` and `mem::forget`.~~ Adds `mem::forget_unsized()` that accepts `T: ?Sized`. I had to revert the PR that removed the `forget` intrinsic and replaced it with `ManuallyDrop`: rust-lang#40559 We can't use `ManuallyDrop::new()` here because it needs `T: Sized` and we don't have support for unsized return values yet (will we ever?). r? @eddyb
…r=alexcrichton Fixes rust-lang#55775 -- fixed regression in Command::exec's handling of PATH. This restores the previous behavior where if env_clear() or env_remove() was used, the parent's PATH would be consulted. r? @alexcrichton
… r=pnkfelix rustdoc: don't inline `pub use some_crate` unless directly asked to cc rust-lang#52509 (fixes it? i'm not sure about my comment summoning the docs team) When rustdoc encounters a `pub use` statement for an item from another crate, it will eagerly inline its contents into your crate. This somewhat clashes with the new paths behavior in Rust 2018, in which crates are implicitly linked and re-exported with `pub use` instead of `pub extern crate`. In rust 2015, `pub extern crate` would only create a single line for its re-export in the docs, so i'm making it do the same with `pub use some_crate;`. The exact new behavior is like this: *If rustdoc sees a `pub use` statement, and the item being imported is the root of another crate, it will only inline it if `#[doc(inline)]` is provided.* I made it only avoid crate roots because otherwise it would stop inlining any module, which may or may not be what people want.
…k-Simulacrum Move `static_assert!` into librustc_data_structures
…rellt-matchbar, r=eddyb Make PhantomData #[structural_match] fixes rust-lang#55028 This makes `PhantomData<T>` structurally matchable, irrespective of whether `T` is, per the discussion on this week's language team meeting (the general consensus was that this was a bug-fix). All types containing `PhantomData<T>` and which used `#[derive(PartialEq, Eq)]` and were previously not `#[structural_match]` only because of `PhantomData<T>` will now be `#[structural_match]`. r? @nikomatsakis
…alexcrichton Fix TLS errors when downloading stage0 While attempting to test rust-lang#49878 on Windows I hit the following error when attempting to download stage0. ``` The request was aborted: Could not create SSL/TLS secure channel ``` Instead of using the shell, we can just use `urllib`, which seems to fix the issue.
add FromIterator<A> to Box<[A]>
Rewrite `...` as `..=` as a `MachineApplicable` 2018 idiom lint Fixes rust-lang#51043.
Fix a typo in std::panic
…wiser Fix typos.
string: Add documentation for `From` impls Hi this is part of rust-lang#51430. I'm a first time contributor, so I started with a small task adding a bit of documentation for From impls.
save-analysis: Don't panic for macro-generated use globs Follow-up to rust-lang@c2bb7ca - as before, ignore the use globs in macro expansions. Fixes rust-lang/rls#1117. Closes rust-lang#55480. r? @nrc
…mpls, r=Mark-Simulacrum Reference count `crate_inherent_impls`s return value. The repeated cloning of the result in `inherent_impls` queries has quite an impact on crates with many inherent trait implementations. For instance on https://github.com/jmesmon/stm32f429, `cargo check` went from 75 seconds to 38 seconds on my machine.
miri: for uniformity, also move memory_deallocated to AllocationExtra r? @oli-obk
global allocators: add a few comments These comments answer some questions that came up when I tried to understand how the control flow works for the global allocator, `Global` and `System`. r? @alexcrichton
Member
Author
|
@bors r+ p=5 |
Collaborator
|
📌 Commit 0532755 has been approved by |
bors
added
the
S-waiting-on-bors
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
Author
|
@bors r- |
bors
added
S-waiting-on-author
Member
Author
|
Caused by #55805. Don't have time to fix the PR right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Command::exec's PATH resolution #55775 -- fixed regression in Command::exec's handling of PATH.)pub use some_crateunless directly asked to #55804 (rustdoc: don't inlinepub use some_crateunless directly asked to)static_assert!into librustc_data_structures #55805 (Movestatic_assert!into librustc_data_structures)...as..=as aMachineApplicable2018 idiom lint #55852 (Rewrite...as..=as aMachineApplicable2018 idiom lint)Fromimpls #55874 (string: Add documentation forFromimpls)crate_inherent_implss return value. #55882 (Reference countcrate_inherent_implss return value.)Failed merges:
r? @ghost