Use derive macro for HashStable#56864
Merged
bors merged 3 commits intorust-lang:masterfrom Mar 13, 2019
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
stable-hash-macro
branch
2 times, most recently
from
fa13d01 to
8067955
Compare
Contributor
Author
bjorn3
reviewed
Dec 16, 2018
Member
|
Looks promising! |
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
stable-hash-macro
branch
from
8067955 to
4482fd6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Jan 11, 2019
[WIP] Allocate HIR on an arena Blocked on #56864
Dylan-DPC-zz
added
S-blocked
Zoxc
force-pushed
the
stable-hash-macro
branch
from
436166c to
87dca52
Compare
This comment has been minimized.
This comment has been minimized.
Zoxc
force-pushed
the
stable-hash-macro
branch
from
87dca52 to
4f03dfb
Compare
This comment has been minimized.
This comment has been minimized.
bors
added a commit
that referenced
this pull request
Mar 8, 2019
Create a derive macro for HashStable and allow proc macros in rustc A combination of #56864 and #56795. There were complications with using `serde_derive` as rustc doesn't know which crate to use for the host when there is a serde_derive in the sysroot and cargo passes another on the command line built from crates.io. r? @eddyb (for proc macro changes) @alexcrichton (for rustbuild changes) @michaelwoerister (for the macro itself)
src/librustc/hir/mod.rs
Outdated
Member
There was a problem hiding this comment.
This seems to be missing a projection attribute.
src/librustc/hir/mod.rs
Outdated
Member
|
Beautiful, thanks @Zoxc! r=me with the two nits addressed. @rust-lang/compiler, please marvel at the diff stats of this PR |
Contributor
Author
|
@bors r=michaelwoerister |
Collaborator
|
📌 Commit bc3a84a has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit bc3a84a with merge 09cf073a10bb65a550dd3082e2a7511a7d43dd8f... |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Contributor
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Mar 13, 2019
Use derive macro for HashStable Blocked on #56795
Collaborator
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on #56795