Move spin_loop_hint to core::hint module by clarfonthey · Pull Request #56996 · rust-lang/rust

clarfonthey · 2018-12-19T21:44:29Z

As mentioned in #55002. The new name is kept unstable to decide whether the function should have _hint in its name.

rust-highfive · 2018-12-19T21:44:33Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2018-12-20T03:31:35Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0a1fbb34:start=1545276305527646940,finish=1545276389072489264,duration=83544842324
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
    100% |████████████████████████████████| 51kB 10.6MB/s 
Collecting botocore==1.12.69 (from awscli)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/72/ba/a188505f67a78a686aa24d8511a18cb5a8bb27705c9d1b1bb81bee97a138/botocore-1.12.69-py2.py3-none-any.whl (5.2MB)
    0% |                                | 10kB 39.7MB/s eta 0:00:01
    0% |▏                               | 20kB 39.0MB/s eta 0:00:01
    0% |▏                               | 30kB 43.4MB/s eta 0:00:01
    0% |▎                               | 40kB 38.4MB/s eta 0:00:01
---
187088 ./obj/build/cache/2018-12-09
160388 ./obj/build/bootstrap/debug/incremental
153280 ./src/tools/clang
144288 ./obj/build/bootstrap/debug/incremental/bootstrap-2x7szixskz2uj
144284 ./obj/build/bootstrap/debug/incremental/bootstrap-2x7szixskz2uj/s-f7r67yu4ze-rpr10o-3g9jcdhvsk79m
111164 ./obj/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends
107420 ./src/tools/lldb
95108 ./src/tools/clang/test
89968 ./src/llvm-emscripten/test/CodeGen
---
travis_time:end:23d82a0a:start=1545276692104189928,finish=1545276692109010868,duration=4820940
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:066e9370
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01349e5c
travis_time:start:01349e5c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-12-26T19:58:49Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:38b46aa8:start=1545854025139190070,finish=1545854026128466485,duration=989276415
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
187088 ./obj/build/cache/2018-12-09
160388 ./obj/build/bootstrap/debug/incremental
153288 ./src/tools/clang
144288 ./obj/build/bootstrap/debug/incremental/bootstrap-2x7szixskz2uj
144284 ./obj/build/bootstrap/debug/incremental/bootstrap-2x7szixskz2uj/s-f7yjl29yi9-esuwm7-2o68jogcg2xpo
111164 ./obj/build/x86_64-unknown-linux-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu/codegen-backends
107416 ./src/tools/lldb
95116 ./src/tools/clang/test
90408 ./.git

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

KodrAus · 2019-01-01T22:56:02Z

sad trombone

@bors retry

clarfonthey · 2019-01-03T00:10:46Z

I honestly don't know how to fix the error here. I was under the impression that you could set the stability of an export differently from the original, but that might have changed.

bors · 2019-01-09T01:14:00Z

☔ The latest upstream changes (presumably #56407) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2019-01-09T02:48:35Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:09ed7d20:start=1547001746166781524,finish=1547001748289823824,duration=2123042300
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
[00:05:49]    Compiling jobserver v0.1.12
[00:05:49]    Compiling memmap v0.6.2
[00:05:50]    Compiling rand v0.6.1
[00:05:50]    Compiling parking_lot_core v0.3.0
[00:05:50] error[E0658]: use of unstable library feature 'renamed_spin_loop' (see issue #55002)
[00:05:50]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/parking_lot_core-0.3.0/src/spinwait.rs:10:5
[00:05:50] 10 | use std::sync::atomic::spin_loop_hint;
[00:05:50]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:05:50]    |
[00:05:50]    = help: add #![feature(renamed_spin_loop)] to the crate attributes to enable
[00:05:50]    = help: add #![feature(renamed_spin_loop)] to the crate attributes to enable
[00:05:50] 
[00:05:50] error[E0658]: use of unstable library feature 'renamed_spin_loop' (see issue #55002)
[00:05:50]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/parking_lot_core-0.3.0/src/spinwait.rs:61:9
[00:05:50] 61 |         spin_loop_hint()
[00:05:50]    |         ^^^^^^^^^^^^^^
[00:05:50]    |
[00:05:50]    = help: add #![feature(renamed_spin_loop)] to the crate attributes to enable

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

KodrAus · 2019-01-09T21:56:10Z

It's a bit unfortunate.

How about we punt on the feature gate, decide in #55002 whether the name should be core::hint::spin_loop or core::hint::spin_loop_hint (throwing my hat in with core::hint::spin_loop), and go from there?

KodrAus · 2019-01-09T21:57:23Z

src/libcore/sync/atomic.rs

Any reason not to deprecate this one?

Because if the other name is unstable, then you can't actually use the replacement.

Ah of course :) I'd already put myself in the mindset that this would be stable.

clarfonthey · 2019-01-09T22:11:27Z

Do you think that it would be worthwhile simply doing an FCP here to name the replacement spin_loop? Not really sure how we can initiate conversation on this short of starting an FCP.

I can update the PR to make the renamed version instantly stable and deprecate the old one, if that's desired.

KodrAus · 2019-01-09T22:56:53Z

Do you think that it would be worthwhile simply doing an FCP here to name the replacement spin_loop?

Sure, let's do that 👍 @rfcbot doesn't actually like me though so I'll just give the libs team a ping.

cc @rust-lang/libs what do you think about deprecating core::sync::atomic::spin_loop_hint in favour of core::hint::spin_loop?

If we don't want the insta-stable core::hint::spin_loop function then we might just have to do some more shimming shenanigans to make the core::sync::atomic::spin_loop_hint function internally call core::hint::spin_loop.

clarfonthey · 2019-01-09T23:03:52Z

That's a good idea-- I'll update the PR to do that regardless and we can decide whether to insta-stabilise or not.

alexcrichton · 2019-01-10T01:22:59Z

I think it's fine to deprecate the one in atomic, and we'd want to schedule its deprecation to at least 2 releases after the stabilization of this new function (and possibly 3-4 releases)

kennytm · 2019-01-15T09:24:38Z

@bors retry

rust-highfive · 2019-01-15T11:02:06Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:06c5070f:start=1547544036668993722,finish=1547544110427254251,duration=73758260529
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:12:14] 
[01:12:14] running 118 tests
[01:12:39] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii..........i...ii...i.......ii.i.i.i 100/118
[01:12:44] ......iii.i.....ii
[01:12:44] 
[01:12:44]  finished in 29.867
[01:12:44] travis_fold:end:test_debuginfo

---
[01:39:52] travis_fold:end:stage0-linkchecker

[01:39:52] travis_time:end:stage0-linkchecker:start=1547550110119868230,finish=1547550112081692327,duration=1961824097

[01:39:56] std/hint/fn.spin_loop.html:3: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/thread/fn.yield_now.html
[01:39:59] core/hint/fn.spin_loop.html:3: broken link - /checkout/obj/build/x86_64-unknown-linux-gnu/std/thread/fn.yield_now.html
[01:40:00] thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:39:9
[01:40:00] 
[01:40:00] 
[01:40:00] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:40:00] expected success, got: exit code: 101
[01:40:00] expected success, got: exit code: 101
[01:40:00] 
[01:40:00] 
[01:40:00] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:40:00] Build completed unsuccessfully in 0:39:22
[01:40:00] make: *** [check] Error 1
[01:40:00] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:08ffd828
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Jan 15 11:02:00 UTC 2019
---
travis_time:end:0c504482:start=1547550121979173460,finish=1547550121984730642,duration=5557182
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:02d2d84c
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!chetravis_time:end:02d2d84c:start=1547550121989581918,finish=1547550122049724122,duration=60142204
travis_fold:start:after_failure.5
travis_time:start:10859e80
travis_time:start:10859e80
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:13fd3388
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

clarfonthey · 2019-01-15T21:45:02Z

Fixed broken link; should be ready to merge now. Also if someone could add the appropriate tags to the tracking issue I'd appreciate it.

KodrAus · 2019-01-16T19:04:11Z

@bors r+

Thanks @clarcharr! I'll update the tracking issue.

bors · 2019-01-16T19:04:12Z

📌 Commit 24ca530 has been approved by KodrAus

Move spin_loop_hint to core::hint module As mentioned in rust-lang#55002. The new name is kept unstable to decide whether the function should have `_hint` in its name.

bors · 2019-01-18T07:36:22Z

⌛ Testing commit 24ca530 with merge 38650b6...

Move spin_loop_hint to core::hint module As mentioned in #55002. The new name is kept unstable to decide whether the function should have `_hint` in its name.

bors · 2019-01-18T10:24:10Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: KodrAus
Pushing 38650b6 to master...

rust-highfive assigned KodrAus Dec 19, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 19, 2018

This comment has been minimized.

Sign in to view

clarfonthey force-pushed the spin_loop_hint branch from eb29deb to 80c67d3 Compare December 19, 2018 21:54

This comment has been minimized.

Sign in to view

clarfonthey force-pushed the spin_loop_hint branch from 80c67d3 to 2e48674 Compare December 20, 2018 03:22

clarfonthey force-pushed the spin_loop_hint branch from 2e48674 to 28f8c72 Compare December 26, 2018 19:52

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2019

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 3, 2019

clarfonthey force-pushed the spin_loop_hint branch from 28f8c72 to 48e732b Compare January 9, 2019 02:40

KodrAus reviewed Jan 9, 2019

View reviewed changes

clarfonthey force-pushed the spin_loop_hint branch 5 times, most recently from dfc1289 to 10696c6 Compare January 10, 2019 14:03

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 15, 2019

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 15, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2019

Move spin_loop_hint to core::hint module

24ca530

clarfonthey force-pushed the spin_loop_hint branch from 10696c6 to 24ca530 Compare January 15, 2019 21:44

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 15, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2019

Centril mentioned this pull request Jan 17, 2019

Rollup of 19 pull requests #57687

Closed

Centril mentioned this pull request Jan 17, 2019

Rollup of 19 pull requests #57688

Closed

Centril mentioned this pull request Jan 17, 2019

Rollup of 18 pull requests #57690

Closed

bors added a commit that referenced this pull request Jan 18, 2019

Auto merge of #56996 - clarcharr:spin_loop_hint, r=KodrAus

38650b6

Move spin_loop_hint to core::hint module As mentioned in #55002. The new name is kept unstable to decide whether the function should have `_hint` in its name.

bors merged commit 24ca530 into rust-lang:master Jan 18, 2019

clarfonthey deleted the spin_loop_hint branch January 31, 2019 05:46

Uh oh!

Conversation

clarfonthey commented Dec 19, 2018

Uh oh!

rust-highfive commented Dec 19, 2018

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-highfive commented Dec 20, 2018

Uh oh!

rust-highfive commented Dec 26, 2018

Uh oh!

KodrAus commented Jan 1, 2019

Uh oh!

clarfonthey commented Jan 3, 2019

Uh oh!

bors commented Jan 9, 2019

Uh oh!

rust-highfive commented Jan 9, 2019

Uh oh!

KodrAus commented Jan 9, 2019

Uh oh!

KodrAus Jan 9, 2019

Choose a reason for hiding this comment

Uh oh!

clarfonthey Jan 9, 2019

Choose a reason for hiding this comment

Uh oh!

KodrAus Jan 9, 2019

Choose a reason for hiding this comment

Uh oh!

clarfonthey commented Jan 9, 2019

Uh oh!

KodrAus commented Jan 9, 2019

Uh oh!

clarfonthey commented Jan 9, 2019

Uh oh!

alexcrichton commented Jan 10, 2019

Uh oh!

kennytm commented Jan 15, 2019

Uh oh!

rust-highfive commented Jan 15, 2019

Uh oh!

clarfonthey commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KodrAus commented Jan 16, 2019

Uh oh!

bors commented Jan 16, 2019

Uh oh!

bors commented Jan 18, 2019

Uh oh!

bors commented Jan 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

clarfonthey commented Jan 15, 2019 •

edited

Loading