Deduplicate mismatched delimiter errors#57944
Merged
bors merged 11 commits intorust-lang:masterfrom Feb 9, 2019
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
estebank
commented
Jan 28, 2019
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
unclosed-delim-the-quickening
branch
from
d31c1e1 to
0880f43
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
unclosed-delim-the-quickening
branch
from
b26d032 to
40ad7c3
Compare
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
unclosed-delim-the-quickening
branch
from
40ad7c3 to
8fbc738
Compare
Contributor
Author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Delay unmatched delimiter errors until after the parser has run to deduplicate them when parsing and attempt recovering intelligently.
estebank
force-pushed
the
unclosed-delim-the-quickening
branch
from
f8926b2 to
6e62129
Compare
Contributor
Author
|
CC @davidtwco @zackmdavis @euclio @oli-obk who might have comments on the approach/idea/result. |
oli-obk
reviewed
Feb 7, 2019
Contributor
|
@bors try |
Collaborator
Contributor
|
@rust-timer build dbcc2e8 the last PR was a big perf hit, so let's check this before we merge |
Collaborator
|
Success: Queued dbcc2e8 with parent ad43389, comparison URL. |
Collaborator
|
Finished benchmarking try commit dbcc2e8 |
Contributor
Author
|
@bors r=oli-obk as per our in person conversation. |
Collaborator
|
📌 Commit c54b230 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
💔 Test failed - checks-travis |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
kennytm
added
S-waiting-on-author
Contributor
Author
|
@bors r=oli-obk |
Collaborator
|
📌 Commit fb3c4fb has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Feb 9, 2019
This was referenced Mar 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delay unmatched delimiter errors until after the parser has run to deduplicate them when parsing and attempt recovering intelligently.
Second attempt at #54029, follow up to #53949. Fix #31528.