Misc refactorings to rustc_codegen_ssa#58846
Merged
bors merged 18 commits intorust-lang:masterfrom Mar 30, 2019
Merged
Conversation
rust-highfive
added
the
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #59178) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
r? @oli-obk |
Member
|
Sorry about the delays, please ping me in IRC/Discord PMs (or Zulip, but its UI/UX make it harder to use), if I don't see notifications, I'm still digging myself out of the backlog, but I am around! |
eddyb
reviewed
Mar 28, 2019
eddyb
reviewed
Mar 28, 2019
src/librustc_codegen_llvm/builder.rs
Outdated
Member
|
r=me with the comment fixed |
…ods from cg_ssa This introduces the static_panic_msg trait method to StaticBuilderMethods.
declare_local still takes &FunctionDebugContext, because of borrowck errors
`count_insn` is no longer called for inline asm, because it is private to builder.rs
bjorn3
force-pushed
the
misc_cg_ssa_refactor
branch
from
5e303dd to
35705de
Compare
Member
Author
|
Rebased and fixed comment. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 35705de has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike #56636 this doesn't split
BuilderMethodsinto a lot of traits. That makes this PR twice as small and the split turned out to not be very useful anyway.r? @eddyb