Rollup of 14 pull requests by kennytm · Pull Request #58866 · rust-lang/rust

kennytm · 2019-03-02T06:55:27Z

Successful merges:

Have all methods of Filter and FilterMap use internal iteration #58730 (Have all methods of Filter and FilterMap use internal iteration)
ManuallyDrop != MaybeUninit #58780 (ManuallyDrop != MaybeUninit)
Replace s with self in docs for str methods taking self. #58782 (Replace s with self in docs for str methods taking self.)
allow specifying attributes for tool lints #58785 (allow specifying attributes for tool lints)
Ensure record_layout_for_printing() is inlined. #58802 (Ensure record_layout_for_printing() is inlined.)
Fixed a syntax error in the pin docs #58821 (Fixed a syntax error in the pin docs)
tidy: deny(rust_2018_idioms) #58830 (tidy: deny(rust_2018_idioms))
Revert switching to GCP on AppVeyor #58832 (Revert switching to GCP on AppVeyor)
tools/rustbook: deny(rust_2018_idioms) #58833 (tools/rustbook: deny(rust_2018_idioms))
tools/remote-test-{client,server}: deny(rust_2018_idioms) #58835 (tools/remote-test-{client,server}: deny(rust_2018_idioms))
Fix typo in Vec#resize_with documentation #58838 (Fix typo in Vec#resize_with documentation)
Forbid duplicating Cargo as a dependency #58842 (Forbid duplicating Cargo as a dependency)
Update toolchain to build NetBSD release #58852 (Update toolchain to build NetBSD release)
Fix C-variadic function printing #58865 (Fix C-variadic function printing)

This reduces instruction counts for the `ctfe-stress-2` benchmark by about 1%.

Co-Authored-By: RalfJung <post@ralfj.de>

…alexcrichton" This reverts commit fd42f24, reversing changes made to 0e25a68.

This allows us to remove the "allow old toolchains" flag we pass to LLVM, ensuring that we'll be up to date when LLVM needs us to be!

kennytm · 2019-03-02T06:55:42Z

@bors r+ p=17

bors · 2019-03-02T06:55:42Z

📌 Commit 8e234677376bef933384e38f102c104c0220c273 has been approved by kennytm

kennytm · 2019-03-02T07:01:14Z

@bors r+

Removed #58829 (prevent rolling up Cargo.lock changes)

bors · 2019-03-02T07:01:15Z

📌 Commit 1b06687d600456dcbcd3767266874e40a1d2df84 has been approved by kennytm

bors · 2019-03-02T07:34:04Z

⌛ Testing commit 1b06687d600456dcbcd3767266874e40a1d2df84 with merge 6d68d7e2ef88b1b058dacff005d31cc0c70e0467...

bors · 2019-03-02T08:40:07Z

💔 Test failed - checks-travis

rust-highfive · 2019-03-02T08:40:08Z

The job test-various of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:04:03] failures:
[01:04:03] 
[01:04:03] ---- [ui] ui/asm/invalid-inline-asm-2.rs stdout ----
[01:04:03] 
[01:04:03] error: Error: expected failure status (Some(1)) but received status None.
[01:04:03] status: signal: 6
[01:04:03] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/asm/invalid-inline-asm-2.rs" "-Zthreads=1" "--target=wasm32-unknown-unknown" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/invalid-inline-asm-2/a.wasm" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/wasm32-unknown-unknown/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/invalid-inline-asm-2/auxiliary" "-A" "unused"
[01:04:03] ------------------------------------------
[01:04:03] 
[01:04:03] ------------------------------------------
[01:04:03] stderr:
[01:04:03] stderr:
[01:04:03] ------------------------------------------
[01:04:03] rustc: /checkout/src/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7671: void llvm::SelectionDAGBuilder::visitInlineAsm(llvm::ImmutableCallSite): Assertion `OpInfo.isIndirect && "Memory output must be indirect operand"' failed.
[01:04:03] ------------------------------------------
[01:04:03] 
[01:04:03] thread '[ui] ui/asm/invalid-inline-asm-2.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:04:03] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:04:03] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:04:03] 
[01:04:03] ---- [ui] ui/asm/invalid-inline-asm.rs stdout ----
[01:04:03] 
[01:04:03] error: Error: expected failure status (Some(1)) but received status None.
[01:04:03] status: signal: 6
[01:04:03] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/asm/invalid-inline-asm.rs" "-Zthreads=1" "--target=wasm32-unknown-unknown" "--error-format" "json" "-Zui-testing" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/invalid-inline-asm/a.wasm" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/wasm32-unknown-unknown/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/asm/invalid-inline-asm/auxiliary" "-A" "unused"
[01:04:03] ------------------------------------------
[01:04:03] 
[01:04:03] ------------------------------------------
[01:04:03] stderr:
[01:04:03] stderr:
[01:04:03] ------------------------------------------
[01:04:03] rustc: /checkout/src/llvm-project/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7828: void llvm::SelectionDAGBuilder::visitInlineAsm(llvm::ImmutableCallSite): Assertion `(OpInfo.ConstraintType == TargetLowering::C_RegisterClass || OpInfo.ConstraintType == TargetLowering::C_Register) && "Unknown constraint type!"' failed.
[01:04:03] ------------------------------------------
[01:04:03] 
[01:04:03] thread '[ui] ui/asm/invalid-inline-asm.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:04:03] 
---
[01:04:03] 
[01:04:03] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:04:03] 
[01:04:03] 
[01:04:03] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/wasm32-unknown-unknown/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-wasm32-unknown-unknown" "--mode" "ui" "--target" "wasm32-unknown-unknown" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--nodejs" "/node-v9.2.0-linux-x64/bin/node" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/wasm32-unknown-unknown/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "8.0.0\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:04:03] 
[01:04:03] 
[01:04:03] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target wasm32-unknown-unknown src/test/run-make src/test/ui src/test/run-pass src/test/compile-fail src/test/mir-opt src/test/codegen-units src/libcore
[01:04:03] Build completed unsuccessfully in 1:00:09
---
travis_time:end:026ec242:start=1551515975467016619,finish=1551515975485065803,duration=18049184
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:19e82cd0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:start:crashlog
obj/cores/core.544.!checkout!obj!build!x86_64-unknown-linux-gnu!stage2!bin!rustc
[New LWP 568]
[New LWP 544]
[New LWP 547]
[New LWP 555]
[New LWP 556]
[New LWP 567]
warning: Could not load shared library symbols for 8 libraries, e.g. /lib/x86_64-linux-gnu/libc.so.6.
Use the "info sharedlibrary" command to see the complete listing.
Do you need "set solib-search-path" or "set sysroot"?
Core was generated by `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc /checkout/src/tes'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f0afaa58e97 in ?? ()
[Current thread is 1 (LWP 568)]
#0  0x00007f0afaa58e97 in ?? ()
#1  0x0000000000000000 in ?? ()
travis_fold:start:crashlog
travis_fold:start:crashlog
obj/cores/core.546.!checkout!obj!build!x86_64-unknown-linux-gnu!stage2!bin!rustc
[New LWP 570]
[New LWP 548]
[New LWP 546]
[New LWP 561]
[New LWP 562]
warning: Could not load shared library symbols for 8 libraries, e.g. /lib/x86_64-linux-gnu/libc.so.6.
Use the "info sharedlibrary" command to see the complete listing.
Do you need "set solib-search-path" or "set sysroot"?
Core was generated by `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc /checkout/src/tes'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fc25b400e97 in ?? ()
[Current thread is 1 (LWP 570)]
#0  0x00007fc25b400e97 in ?? ()
#1  0x0000000000000000 in ?? ()
travis_time:end:19e82cd0:start=1551515975490035975,finish=1551515979208557680,duration=3718521705
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1e62896c
travis_time:start:1e62896c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0011a69c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-03-02T16:06:39Z

⌛ Testing commit b9b4b6742c40f7aefe7b38b082144a8d38aa9230 with merge da6aabe1d71107dab4a75270d5ca6a1e2e185146...

bors · 2019-03-02T19:07:17Z

💔 Test failed - checks-travis

rust-highfive · 2019-03-02T19:07:19Z

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:01:21] 
[00:01:21] Total download size: 4.9 M
[00:01:21] Downloading Packages:
[00:01:24] --------------------------------------------------------------------------------
[00:01:24] Total                                           1.7 MB/s | 4.9 MB     00:02     
[00:01:24] warning: rpmts_HdrFromFdno: Header V3 DSA signature: NOKEY, key ID e8562897
[00:01:24] Importing GPG key 0xE8562897 "CentOS-5 Key (CentOS 5 Official Signing Key) <centos-5-key@centos.org>" from /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-5
[00:01:24] Running Transaction Test
[00:01:24] Finished Transaction Test
[00:01:24] Transaction Test Succeeded
[00:01:24] Running Transaction
---
[00:04:07] + hide_output make install
[00:04:07] + set +x
[00:04:28] shared.sh: line 1:   352 Terminated              bash -c "while true; do sleep 30; echo \$(date) - building ...; done"
[00:04:28] + cd ..
[00:04:28] ./build-openssl.sh: line 16:  4115 Terminated              bash -c "while true; do sleep 30; echo \$(date) - building ...; done"  (wd: /tmp/openssl-1.0.2k)
[00:04:28] + rm -rf openssl-1.0.2k
[00:04:28] + ln -nsf /etc/pki/tls/cert.pem /rustroot/ssl/
[00:04:29]  ---> 96ae4cc86c10
[00:04:29] Step 14/41 : COPY dist-x86_64-linux/build-curl.sh /tmp/
[00:04:29]  ---> d1a73e62d001
[00:04:29] Step 15/41 : RUN ./build-curl.sh
[00:04:29] Step 15/41 : RUN ./build-curl.sh
[00:04:29]  ---> Running in 4cd63043304b
[00:04:30] + source shared.sh
[00:04:30] + VERSION=7.51.0
[00:04:30] + curl http://cool.haxx.se/download/curl-7.51.0.tar.bz2
[00:04:31]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[00:04:31]                                  Dload  Upload   Total   Spent    Left  Speed
[00:04:33] 
  0 2509k    0 14215    0     0   9320      0  0:04:35  0:00:01  0:04:34  9320
  0 2509k    0 14215    0     0   9320      0  0:04:35  0:00:01  0:04:34  9320
  2 2509k    2 59559    0     0  33588      0  0:01:16  0:00:01  0:01:15  177k
 81 2509k   81 2053k    0     0   756k      0  0:00:03  0:00:02  0:00:01 1712k
100 2509k  100 2509k    0     0   874k      0  0:00:02  0:00:02 --:--:-- 1857k
[00:04:33] + mkdir curl-build
[00:04:33] + cd curl-build
[00:04:33] + hide_output ../curl-7.51.0/configure --prefix=/rustroot --with-ssl=/rustroot --disable-sspi --disable-gopher --disable-smtp --disable-smb --disable-imap --disable-pop3 --disable-tftp --disable-telnet --disable-manual --disable-dict --disable-rtsp --disable-ldaps --disable-ldap
[00:04:57] + hide_output make -j10
[00:04:57] + set +x
[00:05:10] shared.sh: line 1:    13 Terminated              bash -c "while true; do sleep 30; echo \$(date) - building ...; done"
[00:05:10] + hide_output make install
---
 88 67.8M   88 59.7M    0     0  6758k      0  0:00:10  0:00:09  0:00:01 7095k
 99 67.8M   99 67.2M    0     0  6851k      0  0:00:10  0:00:10 --:--:-- 7499k
100 67.8M  100 67.8M    0     0  6863k      0  0:00:10  0:00:10 --:--:-- 8245k
[00:09:02] + cd gcc-5.5.0
[00:09:02] + sed -i 's|ftp://gcc\.gnu\.org/|http://gcc.gnu.org/|g' ./contrib/download_prerequisites
[00:09:02] --2019-03-02 16:16:57--  http://gcc.gnu.org/pub/gcc/infrastructure/mpfr-2.4.2.tar.bz2
[00:09:03] Resolving gcc.gnu.org... 209.132.180.131
[00:09:03] Connecting to gcc.gnu.org|209.132.180.131|:80... connected.
[00:09:03] HTTP request sent, awaiting response... 200 OK
---
[01:13:07]  ---> e8cb5579a0ce
[01:13:07] Step 25/41 : RUN ./build-clang.sh
[01:13:07]  ---> Running in e10584463d73
[01:13:08] + source shared.sh
[01:13:08] + LLVM=llvmorg-8.0.0-rc2
[01:13:08] + mkdir llvm-project
[01:13:08] + cd llvm-project
[01:13:08] + curl -L https://github.com/llvm/llvm-project/archive/llvmorg-8.0.0-rc2.tar.gz
[01:13:08] + tar xzf - --strip-components=1
[01:13:08]                                  Dload  Upload   Total   Spent    Left  Speed
[01:13:08] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   136    0   136    0     0    634      0 --:--:-- --:--:-- --:--:--   715
---
[01:13:26] + cd clang-build
[01:13:26] + INC=/rustroot/include
[01:13:26] + INC=/rustroot/include:/rustroot/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/include-fixed
[01:13:26] + INC=/rustroot/include:/rustroot/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/include-fixed:/usr/include
[01:13:26] + hide_output cmake ../llvm -DCMAKE_C_COMPILER=/rustroot/bin/gcc -DCMAKE_CXX_COMPILER=/rustroot/bin/g++ -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/rustroot -DLLVM_TARGETS_TO_BUILD=X86 '-DLLVM_ENABLE_PROJECTS=clang;lld' -DC_INCLUDE_DIRS=/rustroot/include:/rustroot/lib/gcc/x86_64-unknown-linux-gnu/5.5.0/include-fixed:/usr/include
[01:13:56] Sat Mar 2 17:21:50 UTC 2019 - building ...
[01:14:06] + hide_output make -j10
[01:14:06] + set +x
[01:14:36] Sat Mar 2 17:22:30 UTC 2019 - building ...
---
[02:38:36]  ---> b540de67493e
[02:38:36] Step 32/41 : RUN ./build-perl.sh
[02:38:36]  ---> Running in fdc0ef45a65b
[02:38:36] + source shared.sh
[02:38:36] + curl https://www.cpan.org/src/5.0/perl-5.28.0.tar.gz
[02:38:36]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[02:38:36]                                  Dload  Upload   Total   Spent    Left  Speed
[02:38:38] 
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0 17.0M    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 64 17.0M   64 11.0M    0     0  8377k      0  0:00:02  0:00:01  0:00:01 8800k
100 17.0M  100 17.0M    0     0  10.5M      0  0:00:01  0:00:01 --:--:-- 11.0M
[02:38:38] + cd perl-5.28.0
[02:38:38] + CC=gcc
[02:38:38] + CFLAGS='-I /rustroot/include -fgnu89-inline'
[02:38:38] + hide_output ./configure.gnu
[02:38:38] + set +x
[02:39:08] Sat Mar 2 18:47:02 UTC 2019 - building ...
[02:39:19] + hide_output make -j10
---
[02:57:55] [RUSTC-TIMING] rustc_metadata test:false 181.343
[02:58:36] [RUSTC-TIMING] rustc_typeck test:false 221.872
[02:59:15]    Compiling rustc_lint v0.0.0 (/checkout/src/librustc_lint)
[02:59:17]    Compiling rustc_traits v0.0.0 (/checkout/src/librustc_traits)
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

kennytm · 2019-03-02T20:15:56Z

@bors retry

bors · 2019-03-02T22:02:58Z

⌛ Testing commit b9b4b6742c40f7aefe7b38b082144a8d38aa9230 with merge 3bba8d7c89f8f90f2157b3bbe72bea178a222277...

bors · 2019-03-03T01:03:44Z

💔 Test failed - checks-travis

rust-highfive · 2019-03-03T01:03:45Z

The job i686-gnu of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[02:57:14]    Compiling ansi_term v0.11.0
[02:57:14]    Compiling difference v2.0.0
[02:57:15]    Compiling pretty_assertions v0.5.1
[02:57:15]    Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Fix C-variadic function printing There is no longer a need to append the string `", ..."` to a functions args as `...` is parsed as an argument and will appear in the functions arguments. Fixes: rust-lang#58853

kennytm · 2019-03-03T05:58:36Z

@bors r+

Removed #58464 (already merged)
Added #58865

bors · 2019-03-03T05:58:37Z

📌 Commit 946e670 has been approved by kennytm

bors · 2019-03-03T08:47:58Z

⌛ Testing commit 946e670 with merge f565cdd...

Rollup of 14 pull requests Successful merges: - #58730 (Have all methods of Filter and FilterMap use internal iteration) - #58780 (ManuallyDrop != MaybeUninit) - #58782 (Replace `s` with `self` in docs for str methods taking self.) - #58785 (allow specifying attributes for tool lints) - #58802 (Ensure `record_layout_for_printing()` is inlined.) - #58821 (Fixed a syntax error in the pin docs) - #58830 (tidy: deny(rust_2018_idioms)) - #58832 (Revert switching to GCP on AppVeyor) - #58833 (tools/rustbook: deny(rust_2018_idioms)) - #58835 (tools/remote-test-{client,server}: deny(rust_2018_idioms)) - #58838 (Fix typo in Vec#resize_with documentation) - #58842 (Forbid duplicating Cargo as a dependency) - #58852 (Update toolchain to build NetBSD release) - #58865 (Fix C-variadic function printing)

bors · 2019-03-03T11:41:46Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: kennytm
Pushing f565cdd to master...

timvermeulen and others added 18 commits February 25, 2019 16:44

Have all methods of Filter and FilterMap use internal iteration

1fd2f16

Add relevant benchmarks

8884771

Improve existing benchmarks to prevent extreme optimizations

ec2e4ba

Add trailing newline

88bd624

ManuallyDrop != MaybeUninit

4e7d4c7

Replace s with self in docs for str methods taking self.

b70a953

improve readability

f92c204

allow specifying attributes for tool lints

a998b1f

Ensure record_layout_for_printing() is inlined.

fbdece4

This reduces instruction counts for the `ctfe-stress-2` benchmark by about 1%.

Update src/libcore/mem.rs

0c1a38c

Co-Authored-By: RalfJung <post@ralfj.de>

Fixed a syntax error in the pin docs

96be181

tidy: deny(rust_2018_idioms)

3391f6c

Revert "Auto merge of rust-lang#58597 - pietroalbini:appveyor-gce, r=…

805145f

…alexcrichton" This reverts commit fd42f24, reversing changes made to 0e25a68.

tools/rustbook: deny(rust_2018_idioms)

260b091

tools/remote-test-{client,server}: deny(rust_2018_idioms)

c259489

Fix typo in Vec#resize_with documentation

670a4d6

Forbid duplicating Cargo as a dependency

c3aab14

Update toolchain to build NetBSD release

a7d17bf

This allows us to remove the "allow old toolchains" flag we pass to LLVM, ensuring that we'll be up to date when LLVM needs us to be!

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 2, 2019

kennytm force-pushed the rollup branch from 8e23467 to 1b06687 Compare March 2, 2019 07:00

kennytm changed the title ~~Rollup of 17 pull requests~~ Rollup of 16 pull requests Mar 2, 2019

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 2, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 2, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2019

Alexander Regueiro and others added 2 commits March 3, 2019 02:58

Nit

379cd29

Rollup merge of rust-lang#58865 - dlrobertson:fix-varargs, r=alexreg

946e670

Fix C-variadic function printing There is no longer a need to append the string `", ..."` to a functions args as `...` is parsed as an argument and will appear in the functions arguments. Fixes: rust-lang#58853

kennytm force-pushed the rollup branch from b9b4b67 to 946e670 Compare March 3, 2019 05:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 3, 2019

bors merged commit 946e670 into rust-lang:master Mar 3, 2019

bors mentioned this pull request Mar 3, 2019

Fix links in String deref docs for str::escape methods #58596

Closed

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Uh oh!

Conversation

kennytm commented Mar 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kennytm commented Mar 2, 2019

Uh oh!

bors commented Mar 2, 2019

Uh oh!

kennytm commented Mar 2, 2019

Uh oh!

bors commented Mar 2, 2019

Uh oh!

bors commented Mar 2, 2019

Uh oh!

bors commented Mar 2, 2019

Uh oh!

rust-highfive commented Mar 2, 2019

Uh oh!

bors commented Mar 2, 2019

Uh oh!

bors commented Mar 2, 2019

Uh oh!

rust-highfive commented Mar 2, 2019

Uh oh!

kennytm commented Mar 2, 2019

Uh oh!

bors commented Mar 2, 2019

Uh oh!

bors commented Mar 3, 2019

Uh oh!

rust-highfive commented Mar 3, 2019

Uh oh!

kennytm commented Mar 3, 2019

Uh oh!

bors commented Mar 3, 2019

Uh oh!

bors commented Mar 3, 2019

Uh oh!

bors commented Mar 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

kennytm commented Mar 2, 2019 •

edited

Loading