Do not accidentally treat multi-segment meta-items as single-segment by petrochenkov · Pull Request #58899 · rust-lang/rust

petrochenkov · 2019-03-03T17:41:18Z

Fixes #55168 and many other regressions from #50030

Basically, attributes like #[any::prefix::foo] were commonly interpreted as #[foo] due to name() successfully returning the last segment (this applies to nested things as well #[attr(any::prefix::foo)]).

rust-highfive · 2019-03-03T17:41:23Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2019-03-03T17:56:58Z

@bors try

bors · 2019-03-03T17:57:10Z

⌛ Trying commit f922e0d with merge 290ac7b29f41ff9fa5232f9a1116ea71a3501063...

bors · 2019-03-03T20:40:11Z

☀️ Try build successful - checks-travis
Build commit: 290ac7b29f41ff9fa5232f9a1116ea71a3501063

petrochenkov · 2019-03-03T21:42:02Z

@craterbot run start=master#c0086b9e8972fef9fd4af24bae20d45021ed06c6 end=try#290ac7b29f41ff9fa5232f9a1116ea71a3501063 mode=check-only

craterbot · 2019-03-03T21:42:05Z

👌 Experiment pr-58899 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-03-05T01:39:56Z

🚧 Experiment pr-58899 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-03-05T01:39:59Z

🚨 Experiment pr-58899 has encountered an error: invalid type: map, expected a tuple of size 2
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Mark-Simulacrum · 2019-03-05T04:21:11Z

@craterbot retry

craterbot · 2019-03-05T04:21:12Z

🛠️ Experiment pr-58899 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-03-05T04:21:13Z

🚧 Experiment pr-58899 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-03-05T04:21:15Z

🚨 Experiment pr-58899 has encountered an error: invalid type: map, expected a tuple of size 2
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Mark-Simulacrum · 2019-03-05T04:34:01Z

@craterbot retry

craterbot · 2019-03-05T04:34:03Z

🛠️ Experiment pr-58899 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-03-05T04:34:05Z

🚧 Experiment pr-58899 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-03-06T13:10:24Z

🎉 Experiment pr-58899 is completed!
📊 0 regressed and 0 fixed (50551 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2019-03-06T21:45:55Z

Oh, great, no regressions.

petrochenkov · 2019-03-06T21:59:39Z

I'm going to beta-nominate the first three commits (https://github.com/rust-lang/rust/pull/58899/files/cd71788b8cbc55eb89a391eb65bcc6cb27c5a107) despite the size.
The regression these commits fix has large scope and backward-compatibility implications, so it would be good to fix it sooner.

Remove methods `Attribute::span` and `MetaItem::span` duplicating public fields

petrochenkov · 2019-03-16T20:38:23Z

@bors r=estebank

bors · 2019-03-16T20:38:24Z

📌 Commit 2fd4cbb has been approved by estebank

bors · 2019-03-16T20:48:48Z

⌛ Testing commit 2fd4cbb with merge 7cf074a...

Do not accidentally treat multi-segment meta-items as single-segment Fixes #55168 and many other regressions from #50030 Basically, attributes like `#[any::prefix::foo]` were commonly interpreted as `#[foo]` due to `name()` successfully returning the last segment (this applies to nested things as well `#[attr(any::prefix::foo)]`).

bors · 2019-03-17T00:00:01Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing 7cf074a to master...

petrochenkov · 2019-03-17T16:02:26Z

Backport candidate prepared in #59259

Rustup Supersedes #3889 Addresses some review comments from previous PR and rustups to rust-lang/rust#58899

Turns out, this was never supposed to be supported in the first place. - rust-lang/rust#58899

[beta] Do not accidentally treat multi-segment meta-items as single-segment Partial backport of #58899 to beta

rust-highfive assigned eddyb Mar 3, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2019

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2019

petrochenkov mentioned this pull request Mar 3, 2019

proc_macro_derive(attributes(path::to)) both does and doesn't work #55168

Closed

petrochenkov force-pushed the derval2 branch from 9ec600f to f922e0d Compare March 3, 2019 17:56

Mark-Simulacrum mentioned this pull request Mar 5, 2019

Update machine setup docs rust-lang/crater#402

Closed

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 6, 2019

petrochenkov added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 6, 2019

Centril added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 7, 2019

petrochenkov added 4 commits March 16, 2019 23:13

syntax: Introduce Ident::can_be_raw

6ad55b3

Rename MetaItem::ident to MetaItem::path

63116d3

Refactor away NestedMetaItemKind

0cf9613

Remove methods `Attribute::span` and `MetaItem::span` duplicating public fields

Fix rebase

2fd4cbb

petrochenkov force-pushed the derval2 branch from e34708b to 2fd4cbb Compare March 16, 2019 20:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 16, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 17, 2019

bors merged commit 2fd4cbb into rust-lang:master Mar 17, 2019

bors mentioned this pull request Mar 17, 2019

Tweak some diagnostic spans #59084

Merged

mati865 mentioned this pull request Mar 17, 2019

Rustup rust-lang/rust-clippy#3889

Closed

petrochenkov mentioned this pull request Mar 17, 2019

[beta] Do not accidentally treat multi-segment meta-items as single-segment #59259

Merged

petrochenkov removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 17, 2019

mati865 mentioned this pull request Mar 18, 2019

Rustup rust-lang/rust-clippy#3893

Merged

bors added a commit to rust-lang/rust-clippy that referenced this pull request Mar 18, 2019

Auto merge of #3893 - mati865:rustup, r=oli-obk

4895097

Rustup Supersedes #3889 Addresses some review comments from previous PR and rustups to rust-lang/rust#58899

bors added a commit to rust-lang/rust-clippy that referenced this pull request Mar 18, 2019

Auto merge of #3893 - mati865:rustup, r=oli-obk

a7e0c0b

Rustup Supersedes #3889 Addresses some review comments from previous PR and rustups to rust-lang/rust#58899

bors added a commit to rust-lang/rust-clippy that referenced this pull request Mar 18, 2019

Auto merge of #3893 - mati865:rustup, r=oli-obk

849ac1d

Rustup Supersedes #3889 Addresses some review comments from previous PR and rustups to rust-lang/rust#58899

bors added a commit to rust-lang/rust-clippy that referenced this pull request Mar 18, 2019

Auto merge of #3893 - mati865:rustup, r=oli-obk

6a0a197

Rustup Supersedes #3889 Addresses some review comments from previous PR and rustups to rust-lang/rust#58899

bors added a commit to rust-lang/rust-clippy that referenced this pull request Mar 18, 2019

Auto merge of #3893 - mati865:rustup, r=oli-obk

92612c9

Rustup Supersedes #3889 Addresses some review comments from previous PR and rustups to rust-lang/rust#58899

shepmaster added a commit to shepmaster/snafu that referenced this pull request Mar 23, 2019

Remove the unstable snafu::display attribute

126ec98

Turns out, this was never supposed to be supported in the first place. - rust-lang/rust#58899

shepmaster mentioned this pull request Mar 23, 2019

Remove the unstable snafu::display attribute shepmaster/snafu#39

Merged

shepmaster added a commit to shepmaster/snafu that referenced this pull request Mar 23, 2019

Remove the unstable snafu::display attribute

b914b9d

Turns out, this was never supposed to be supported in the first place. - rust-lang/rust#58899

bors added a commit that referenced this pull request Mar 26, 2019

Auto merge of #59259 - petrochenkov:bderval, r=estebank

88acdb5

[beta] Do not accidentally treat multi-segment meta-items as single-segment Partial backport of #58899 to beta

Uh oh!

Conversation

petrochenkov commented Mar 3, 2019

Uh oh!

rust-highfive commented Mar 3, 2019

Uh oh!

petrochenkov commented Mar 3, 2019

Uh oh!

bors commented Mar 3, 2019

Uh oh!

bors commented Mar 3, 2019

Uh oh!

petrochenkov commented Mar 3, 2019

Uh oh!

craterbot commented Mar 3, 2019

Uh oh!

craterbot commented Mar 5, 2019

Uh oh!

craterbot commented Mar 5, 2019

Uh oh!

Mark-Simulacrum commented Mar 5, 2019

Uh oh!

craterbot commented Mar 5, 2019

Uh oh!

craterbot commented Mar 5, 2019

Uh oh!

craterbot commented Mar 5, 2019

Uh oh!

Mark-Simulacrum commented Mar 5, 2019

Uh oh!

craterbot commented Mar 5, 2019

Uh oh!

craterbot commented Mar 5, 2019

Uh oh!

craterbot commented Mar 6, 2019

Uh oh!

petrochenkov commented Mar 6, 2019

Uh oh!

petrochenkov commented Mar 6, 2019

Uh oh!

petrochenkov commented Mar 16, 2019

Uh oh!

bors commented Mar 16, 2019

Uh oh!

bors commented Mar 16, 2019

Uh oh!

bors commented Mar 17, 2019

Uh oh!

petrochenkov commented Mar 17, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants