dist-powerpc64le-linux: Update binutils version#58991
dist-powerpc64le-linux: Update binutils version#58991ajdlinux wants to merge 1 commit intorust-lang:masterfrom
Conversation
Update to recent binutils to avoid a linker bug that causes crashes when linking against OpenSSL. Closes: rust-lang#57345 Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Hi @ajdlinux, sorry to have sniped your efforts!
The likely difference is that we have Lines 47 to 57 in 88f755f But that assertion is worrying! I'll file a new bug about it, at least... |
|
Haha I'm just glad someone else was looking at this, the broken cargo builds have been causing me a bit of grief in recent days. Thanks for opening the other issue! |
Update to recent binutils to avoid a linker bug that causes crashes when
linking against OpenSSL.
Closes: #57345
Signed-off-by: Andrew Donnellan andrew.donnellan@au1.ibm.com
Hi, I'm a first time contributor!
I've been unable to test this, because for some reason I'm seeing a failure when running
./src/ci/docker/run.sh dist-powerpc64le-linux, with or without this patch, on two different machines, even though the ppc64le builds currently seem to be running fine in Travis.Would appreciate if someone else could test this + tell me what I'm doing wrong with running the CI scripts. It does appear to be fetching the new binutils tarball though.