Rollup of 13 pull requests by Centril · Pull Request #59050 · rust-lang/rust

Centril · 2019-03-09T16:18:30Z

Successful merges:

Use early unwraps instead of bubbling up errors just to unwrap in the end #58518 (Use early unwraps instead of bubbling up errors just to unwrap in the end)
rustdoc: add option to calculate "documentation coverage" #58626 (rustdoc: add option to calculate "documentation coverage")
rust-lldb: fix crash when printing empty string #58629 (rust-lldb: fix crash when printing empty string)
MaybeUninit: add read_initialized, add examples #58660 (MaybeUninit: add read_initialized, add examples)
fixes rust-lang#52482 #58670 (fixes Refactor away the TypeckTables::cast_kinds field #52482)
look for python2 symlinks before bootstrap python #58676 (look for python2 symlinks before bootstrap python)
Refactor passes and pass execution to be more parallel #58679 (Refactor passes and pass execution to be more parallel)
Make Unique::as_ptr, NonNull::dangling and NonNull::cast const #58750 (Make Unique::as_ptr, NonNull::dangling and NonNull::cast const)
Mention unwind(aborts) in diagnostics for #[unwind] #58762 (Mention unwind(aborts) in diagnostics for #[unwind])
Add as_slice() to slice::IterMut and vec::Drain #58924 (Add as_slice() to slice::IterMut and vec::Drain)
Actually publish miri in the manifest #58990 (Actually publish miri in the manifest)
std: Delete a by-definition spuriously failing test #59018 (std: Delete a by-definition spuriously failing test)
Expose new_sub_parser_from_file #59045 (Expose new_sub_parser_from_file)

Failed merges:

r? @ghost

Also remove a no-longer accurate comments

…the others

Co-Authored-By: RalfJung <post@ralfj.de>

Simplify input validation for `#[unwind]`, add tests

…ategy

Make `Unique::as_ptr` const without feature attribute as it's unstable Make `NonNull::dangling` and `NonNull::cast` const with `feature = "const_ptr_nonnull"`

The old logic would incorrectly look for "python2.exe" when searching for "python2.7.exe".

Before this commit, if you're running x.py directly on a system where `python` is symlinked to Python 3, then the `python` config option will default to a Python 3 interpreter. This causes debuginfo tests to fail with an opaque error message, since they have a hard requirement on Python 2. This commit modifies the Python probe behavior to look for python2.7 and python2 *before* using the interpreter used to execute `x.py`.

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const

@Mark-Simulacrum

Mention `unwind(aborts)` in diagnostics for `#[unwind]` Simplify input validation for `#[unwind]`, add tests cc rust-lang#58760 r? @Mark-Simulacrum

Add as_slice() to slice::IterMut and vec::Drain In indexmap-rs/indexmap#88, we found that there was no easy way to implement `Debug` for our `IterMut` and `Drain` iterators. Those are built on `slice::IterMut` and `vec::Drain`, which implement `Debug` themselves, but have no other way to access their data. With a new `as_slice()` method, we can read the data and customize its presentation.

Actually publish miri in the manifest

std: Delete a by-definition spuriously failing test This commit deletes the `connect_timeout_unbound` test from the standard library which, unfortunately, is by definition eventually going to be a spuriously failing test. There's no way to reserve a port as unbound so we can rely on ecosystem testing for this feature for now. Closes rust-lang#52590

…rom_file, r=Centril Expose new_sub_parser_from_file This function is useful when external tools like rustfmt want to parse internal files without parsing a whole crate. cc rust-lang/rustfmt#3427.

Centril · 2019-03-09T16:18:44Z

@bors r+ p=13

bors · 2019-03-09T16:18:45Z

📌 Commit 4eb762a has been approved by Centril

bors · 2019-03-09T16:19:16Z

⌛ Testing commit 4eb762a with merge 7246b214d44ef56dfd213b3e3e2f13f61c7051f4...

bors · 2019-03-09T18:20:07Z

💔 Test failed - checks-travis

rust-highfive · 2019-03-09T18:20:08Z

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:57:50] test string::test_str_clear ... ok
[01:57:50] test string::test_str_truncate ... ok
[01:57:50] test string::test_str_truncate_split_codepoint ... ok
[01:57:50] test string::test_str_truncate_invalid_len ... ok
[01:57:50] died due to signal 11
[01:57:50] 
[01:57:50] 
[01:57:50] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:57:50] expected success, got: exit code: 3
---
travis_time:end:229bcbde:start=1552155515306833429,finish=1552155515316593672,duration=9760243
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:17b987be
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:02b551fc
travis_time:start:02b551fc
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:236dc66c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2019-03-09T18:21:43Z

@bors retry

bors · 2019-03-09T18:22:13Z

⌛ Testing commit 4eb762a with merge 26b4cb4...

@ghost

Rollup of 13 pull requests Successful merges: - #58518 (Use early unwraps instead of bubbling up errors just to unwrap in the end) - #58626 (rustdoc: add option to calculate "documentation coverage") - #58629 (rust-lldb: fix crash when printing empty string) - #58660 (MaybeUninit: add read_initialized, add examples) - #58670 (fixes #52482) - #58676 (look for python2 symlinks before bootstrap python) - #58679 (Refactor passes and pass execution to be more parallel) - #58750 (Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const) - #58762 (Mention `unwind(aborts)` in diagnostics for `#[unwind]`) - #58924 (Add as_slice() to slice::IterMut and vec::Drain) - #58990 (Actually publish miri in the manifest) - #59018 (std: Delete a by-definition spuriously failing test) - #59045 (Expose new_sub_parser_from_file) Failed merges: r? @ghost

bors · 2019-03-09T21:24:06Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 26b4cb4 to master...

RalfJung and others added 30 commits February 22, 2019 22:37

Add MaybeUninit::read_uninitialized

13ffbee

Also remove a no-longer accurate comments

also add examples to MaybeUninit::into_initialized

dc570fb

misc tweaks

10f511d

examples for as[_mut]_ptr

48aa59e

examples for MaybeUninit::zeroed

084ee7a

avoid unnecessary use of MaybeUninit::get_ref, and expand comment on …

d10366f

…the others

make MaybeUninit Copy

aa4a9b0

Apply suggestions from code review

53c0275

Co-Authored-By: RalfJung <post@ralfj.de>

expand type name

ac2284b

fix link

8ce9b86

remark that the rules are unfinished

a5e2d0c

show how to set with ptr::write

be8d728

prefer into_initialized over read_initialited

6d32e5a

Mention unwind(aborts) in diagnostics for #[unwind]

b11502f

Simplify input validation for `#[unwind]`, add tests

Validate #[unwind] syntax regardless of platform-specific panic str…

dc00a8a

…ategy

Make Unique::as_ptr, NonNull::dangling and NonNull::cast const

797d8ea

Make `Unique::as_ptr` const without feature attribute as it's unstable Make `NonNull::dangling` and `NonNull::cast` const with `feature = "const_ptr_nonnull"`

add option to calculate documentation coverage

009c91a

tabs -> spaces

9e98a25

count fewer items in calculate-doc-coverage

fc94593

refactor: combine item count numbers into a new struct

95500c0

print doc coverage as a table of individual item types

5eb1ab5

add a coverage mode for private items

a3a2559

tweak wording of extern types

3ce19b4

add tests for doc coverage

63bdd29

update docs for doc coverage

80b4919

track items per-file instead of per-type

1b63543

tweak docs for rustdoc's --show-coverage

74cf1ad

update rustdoc coverage tests with new table layout

515dbe7

fix an issue with path probing on Windows

5360ded

The old logic would incorrectly look for "python2.exe" when searching for "python2.7.exe".

Centril added 6 commits March 9, 2019 17:18

Rollup merge of rust-lang#58750 - TimDiekmann:master, r=oli-obk

f1e317b

Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const

Rollup merge of rust-lang#58762 - petrochenkov:unwind, r=Mark-Simulacrum

79873f7

Mention `unwind(aborts)` in diagnostics for `#[unwind]` Simplify input validation for `#[unwind]`, add tests cc rust-lang#58760 r? @Mark-Simulacrum

Rollup merge of rust-lang#58990 - oli-obk:miri_manifest, r=alexcrichton

f67efe9

Actually publish miri in the manifest

Rollup merge of rust-lang#59045 - topecongiro:expose-new_sub_parser_f…

4eb762a

…rom_file, r=Centril Expose new_sub_parser_from_file This function is useful when external tools like rustfmt want to parse internal files without parsing a whole crate. cc rust-lang/rustfmt#3427.

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 9, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 9, 2019

bors merged commit 4eb762a into rust-lang:master Mar 9, 2019

This was referenced Mar 9, 2019

Stabilise disable minification #56359

Closed

Combine all builtin late lints and make lint checking parallel #58019

Merged

Refactor tools/build-mainfest #58995

Merged

Filter away test annotations from UI test output #59044

Merged

Centril deleted the rollup branch March 10, 2019 09:16

ehuss mentioned this pull request Mar 22, 2019

unused_variables lint fires for E0005 error #59357

Open

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 13 pull requests#59050

Rollup of 13 pull requests#59050
bors merged 67 commits intorust-lang:masterfrom
Centril:rollup

Centril commented Mar 9, 2019

Uh oh!

Centril commented Mar 9, 2019

Uh oh!

bors commented Mar 9, 2019

Uh oh!

bors commented Mar 9, 2019

Uh oh!

bors commented Mar 9, 2019

Uh oh!

rust-highfive commented Mar 9, 2019

Uh oh!

Centril commented Mar 9, 2019

Uh oh!

bors commented Mar 9, 2019

Uh oh!

bors commented Mar 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

Centril commented Mar 9, 2019

Uh oh!

Centril commented Mar 9, 2019

Uh oh!

bors commented Mar 9, 2019

Uh oh!

bors commented Mar 9, 2019

Uh oh!

bors commented Mar 9, 2019

Uh oh!

rust-highfive commented Mar 9, 2019

Uh oh!

Centril commented Mar 9, 2019

Uh oh!

bors commented Mar 9, 2019

Uh oh!

bors commented Mar 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants