Moved issue tests to subdirs and normalised names by alexreg · Pull Request #59120 · rust-lang/rust

alexreg · 2019-03-12T00:49:47Z

Consistency, decluttering, ease of navigation :-)

Centril · 2019-03-12T00:53:17Z

The reorganization here makes sense so I'd r+ myself but I'll let someone from T-compiler OK this...

bors · 2019-03-12T01:11:48Z

☔ The latest upstream changes (presumably #59044) made this pull request unmergeable. Please resolve the merge conflicts.

estebank · 2019-03-12T01:51:06Z

r=me after rebasing

rust-highfive · 2019-03-12T02:13:07Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:2294a8e6:start=1552351866253667459,finish=1552351867343357056,duration=1089689597
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[00:02:06] Successfully built b2d081f21945
[00:02:06] Successfully tagged rust-ci:latest
[00:02:06] Built container sha256:b2d081f21945dba0e311f4d10a763e4c0522073c932b998807ded93b5bfb6863
[00:02:06] Uploading finished image to s3://rust-lang-ci-sccache2/docker/62c93bf697156b017a22966f8ca731737ea7d0a974527596f0b565ab0f2afc82bfdb4433a508c739a9c55c3a8b92cc9175c86be6278091d791c98549912f4d89
[00:02:56] upload failed: - to s3://rust-lang-ci-sccache2/docker/62c93bf697156b017a22966f8ca731737ea7d0a974527596f0b565ab0f2afc82bfdb4433a508c739a9c55c3a8b92cc9175c86be6278091d791c98549912f4d89 Unable to locate credentials

[00:02:56] travis_time:end:09a2baf6:start=1552351903990574833,finish=1552352054171351882,duration=150180777049
[CI_JOB_NAME=x86_64-gnu-llvm-6.0]
[00:02:56] [CI_JOB_NAME=x86_64-gnu-llvm-6.0]
---
[01:18:20] .................................................................................................... 700/5448
[01:18:25] .................................................................................................... 800/5448
[01:18:30] ................................................................................................i... 900/5448
[01:18:36] ............i....................................................................................... 1000/5448
[01:18:39] ERROR 2019-03-12T02:09:57Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/e0119/auxiliary/issue_23563_a.rs` source not found"
[01:18:40] .........................iiiii..........................................................F........... 1100/5448
[01:18:46] .................................................................................................... 1300/5448
[01:18:49] .................................................................................................... 1400/5448
[01:18:52] .................................................................................................... 1500/5448
[01:18:55] .................................................................................................... 1600/5448
[01:18:55] .................................................................................................... 1600/5448
[01:18:59] ..............................i..................................................................... 1700/5448
[01:19:03] .................................................................................................... 1800/5448
[01:19:08] .................................................................................................... 1900/5448
[01:19:11] .................................................................................................... 2000/5448
[01:19:15] .........................................................i.......................................... 2100/5448
[01:19:17] ERROR 2019-03-12T02:10:35Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/issues/auxiliary/use_from_trait_xc.rs` source not found"
[01:19:20] .......................................F............................................................ 2200/5448
[01:19:29] .................................................................................................... 2400/5448
[01:19:34] .................................................................................................... 2500/5448
[01:19:37] .................................................................................................... 2600/5448
[01:19:42] .................................................................................................... 2700/5448
[01:19:42] .................................................................................................... 2700/5448
[01:19:47] .................................................................................................... 2800/5448
[01:19:51] .................................................................................................... 2900/5448
[01:19:56] ...................................F................................................................ 3000/5448
[01:20:05] .................................................................................................... 3200/5448
[01:20:09] ..........................................................................i......................... 3300/5448
[01:20:13] .................................................................................................... 3400/5448
[01:20:17] ................................................ii...i..ii.......................................... 3500/5448
[01:20:17] ................................................ii...i..ii.......................................... 3500/5448
[01:20:22] .................................................................................................... 3600/5448
[01:20:26] .................................................................................................... 3700/5448
[01:20:30] ..........................................................ii........................................ 3800/5448
[01:20:32] ............................................................................i....................... 3900/5448
[01:20:35] .................................................................................................... 4000/5448
[01:20:37] ..................................i................................................................. 4100/5448
[01:20:41] .................................................................................................... 4200/5448
[01:20:47] ERROR 2019-03-12T02:12:05Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/proc-macro/auxiliary/issue_38586.rs` source not found"
[01:20:48] ERROR 2019-03-12T02:12:06Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/proc-macro/auxiliary/issue_50493.rs` source not found"
[01:20:54] ...............................................................F.F.................................. 4300/5448
[01:21:01] .................................................................................................... 4500/5448
[01:21:01] .................................................................................................... 4500/5448
[01:21:02] ERROR 2019-03-12T02:12:20Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/resolve/auxiliary/issue_19452_aux.rs` source not found"
[01:21:02] ERROR 2019-03-12T02:12:20Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/resolve/auxiliary/issue_3907.rs` source not found"
[01:21:02] ERROR 2019-03-12T02:12:20Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/resolve/auxiliary/issue_3907.rs` source not found"
[01:21:05] ........F..........FF........................................................................i...... 4600/5448
[01:21:17] .................................................................................................... 4800/5448
[01:21:20] .................................................................................................... 4900/5448
[01:21:25] .................................................................................................... 5000/5448
[01:21:29] .................................................................................................... 5100/5448
---
[01:21:41] failures:
[01:21:41] 
[01:21:41] ---- [ui] ui/e0119/issue-23563.rs stdout ----
[01:21:41] 
[01:21:41] error: aux-build `/checkout/src/test/ui/e0119/auxiliary/issue_23563_a.rs` source not found
[01:21:41] thread '[ui] ui/e0119/issue-23563.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:21:41] 
[01:21:41] ---- [ui] ui/issues/issue-18986.rs stdout ----
[01:21:41] 
[01:21:41] 
[01:21:41] error: aux-build `/checkout/src/test/ui/issues/auxiliary/use_from_trait_xc.rs` source not found
[01:21:41] thread '[ui] ui/issues/issue-18986.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:21:41] ---- [ui] ui/issues/issue-56411.rs stdout ----
[01:21:41] diff of stderr:
[01:21:41] 
[01:21:41] 
[01:21:41] - error[E0255]: the name `issue_56411_aux` is defined multiple times
[01:21:41] -   --> $DIR/issue-56411.rs:5:21
[01:21:41] + error[E0583]: file not found for module `issue_56411_aux`
[01:21:41] 3    |
[01:21:41] 3    |
[01:21:41] - LL |             mod $name;
[01:21:41] -    |             ---------- previous definition of the module `issue_56411_aux` here
[01:21:41] - LL |             pub use self::$name;
[01:21:41] -    |                     |
[01:21:41] -    |                     |
[01:21:41] -    |                     `issue_56411_aux` reimported here
[01:21:41] - ...
[01:21:41] - ...
[01:21:41] 12 LL | import!(issue_56411_aux);
[01:21:41] -    | ------------------------- in this macro invocation
[01:21:41] 14    |
[01:21:41] 14    |
[01:21:41] -    = note: `issue_56411_aux` must be defined only once in the type namespace of this module
[01:21:41] +    = help: name the file either issue_56411_aux.rs or issue_56411_aux/mod.rs inside the directory "$DIR"
[01:21:41] 16 
[01:21:41] - error[E0365]: `issue_56411_aux` is private, and cannot be re-exported
[01:21:41] -    |
[01:21:41] -    |
[01:21:41] - LL |             pub use self::$name;
[01:21:41] -    |                     ^^^^^^^^^^^ re-export of private `issue_56411_aux`
[01:21:41] - ...
[01:21:41] - LL | import!(issue_56411_aux);
[01:21:41] -    | ------------------------- in this macro invocation
[01:21:41] -    |
[01:21:41] -    = note: consider declaring type or module `issue_56411_aux` with `pub`
[01:21:41] + error: aborting due to previous error
[01:21:41] - error: aborting due to 2 previous errors
[01:21:41] - 
[01:21:41] - Some errors occurred: E0255, E0365.
[01:21:41] - For more information about an error, try `rustc --explain E0255`.
[01:21:41] - For more information about an error, try `rustc --explain E0255`.
[01:21:41] + For more information about this error, try `rustc --explain E0583`.
[01:21:41] 32 
[01:21:41] 
[01:21:41] 
[01:21:41] The actual stderr differed from the expected stderr.
[01:21:41] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-56411/issue-56411.stderr
[01:21:41] To update references, rerun the tests and pass the `--bless` flag
[01:21:41] To only update this specific test, also pass `--test-args issues/issue-56411.rs`
[01:21:41] error: 1 errors occurred comparing output.
[01:21:41] status: exit code: 1
[01:21:41] status: exit code: 1
[01:21:41] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-56411.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-56411/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-56411/auxiliary" "-A" "unused"
[01:21:41] ------------------------------------------
[01:21:41] 
[01:21:41] ------------------------------------------
[01:21:41] stderr:
[01:21:41] stderr:
[01:21:41] ------------------------------------------
[01:21:41] {"message":"file not found for module `issue_56411_aux`","code":{"code":"E0583","explanation":"\nA file wasn't found for an out-of-line module.\n\nErroneous code example:\n\n```ignore (compile_fail not working here; see Issue #43707)\nmod file_that_doesnt_exist; // error: file not found for module\n\nfn main() {}\n```\n\nPlease be sure that a file corresponding to the module exists. If you\nwant to use a module named `file_that_doesnt_exist`, you need to have a file\nnamed `file_that_doesnt_exist.rs` or `file_that_doesnt_exist/mod.rs` in the\nsame directory.\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-56411.rs","byte_start":303,"byte_end":318,"line_start":13,"line_end":13,"column_start":9,"column_end":24,"is_primary":true,"text":[{"text":"import!(issue_56411_aux);","highlight_start":9,"highlight_end":24}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"name the file either issue_56411_aux.rs or issue_56411_aux/mod.rs inside the directory \"/checkout/src/test/ui/issues\"","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0583]: file not found for module `issue_56411_aux`\n  --> /checkout/src/test/ui/issues/issue-56411.rs:13:9\n   |\nLL | import!(issue_56411_aux);\n   |         ^^^^^^^^^^^^^^^\n   |\n   = help: name the file either issue_56411_aux.rs or issue_56411_aux/mod.rs inside the directory \"/checkout/src/test/ui/issues\"\n\n"}
[01:21:41] {"message":"For more information about this error, try `rustc --explain E0583`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0583`.\n"}
[01:21:41] 
[01:21:41] ------------------------------------------
[01:21:41] 
[01:21:41] 
[01:21:41] thread '[ui] ui/issues/issue-56411.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3295:9
[01:21:41] 
[01:21:41] ---- [ui] ui/proc-macro/issue-38586.rs stdout ----
[01:21:41] 
[01:21:41] error: aux-build `/checkout/src/test/ui/proc-macro/auxiliary/issue_38586.rs` source not found
[01:21:41] thread '[ui] ui/proc-macro/issue-38586.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:21:41] ---- [ui] ui/proc-macro/issue-50493.rs stdout ----
[01:21:41] 
[01:21:41] 
[01:21:41] error: aux-build `/checkout/src/test/ui/proc-macro/auxiliary/issue_50493.rs` source not found
[01:21:41] thread '[ui] ui/proc-macro/issue-50493.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:21:41] ---- [ui] ui/resolve/issue-19452.rs stdout ----
[01:21:41] 
[01:21:41] 
[01:21:41] error: aux-build `/checkout/src/test/ui/resolve/auxiliary/issue_19452_aux.rs` source not found
[01:21:41] thread '[ui] ui/resolve/issue-19452.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:21:41] ---- [ui] ui/resolve/issue-3907-2.rs stdout ----
[01:21:41] 
[01:21:41] 
[01:21:41] error: aux-build `/checkout/src/test/ui/resolve/auxiliary/issue_3907.rs` source not found
[01:21:41] thread '[ui] ui/resolve/issue-3907-2.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:21:41] ---- [ui] ui/resolve/issue-3907.rs stdout ----
[01:21:41] 
[01:21:41] 
[01:21:41] error: aux-build `/checkout/src/test/ui/resolve/auxiliary/issue_3907.rs` source not found
[01:21:41] thread '[ui] ui/resolve/issue-3907.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:21:41] 
[01:21:41] failures:
[01:21:41]     [ui] ui/e0119/issue-23563.rs
[01:21:41]     [ui] ui/issues/issue-18986.rs
---
[01:21:41] 
[01:21:41] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:21:41] 
[01:21:41] 
[01:21:41] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:21:41] 
[01:21:41] 
[01:21:41] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:21:41] Build completed unsuccessfully in 0:04:56
[01:21:41] Build completed unsuccessfully in 0:04:56
[01:21:41] make: *** [check] Error 1
[01:21:41] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:03af65ba
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Mar 12 02:13:00 UTC 2019
---
travis_time:end:0386fc62:start=1552356782330011173,finish=1552356782335126260,duration=5115087
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:151c2720
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0119ab8c
travis_time:start:0119ab8c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:053c35ca
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-03-12T03:50:23Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:05278e78:start=1552358360530461908,finish=1552358361450247703,duration=919785795
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[01:08:30] .................................................................................................... 1800/5448
[01:08:33] .................................................................................................... 1900/5448
[01:08:37] .................................................................................................... 2000/5448
[01:08:40] .........................................................i.......................................... 2100/5448
[01:08:41] ERROR 2019-03-12T03:48:13Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/issues/auxiliary/use-from-trait-xc.rs` source not found"
[01:08:44] .......................................F............................................................ 2200/5448
[01:08:51] .................................................................................................... 2400/5448
[01:08:56] .................................................................................................... 2500/5448
[01:08:59] .................................................................................................... 2600/5448
[01:09:03] .................................................................................................... 2700/5448
[01:09:03] .................................................................................................... 2700/5448
[01:09:07] .................................................................................................... 2800/5448
[01:09:11] .................................................................................................... 2900/5448
[01:09:13] ERROR 2019-03-12T03:48:44Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/issues/auxiliary/issue-56411-aux.rs` source not found"
[01:09:15] ..................................F................................................................. 3000/5448
[01:09:22] .................................................................................................... 3200/5448
[01:09:26] ..........................................................................i......................... 3300/5448
[01:09:29] .................................................................................................... 3400/5448
[01:09:33] ................................................ii...i..ii.......................................... 3500/5448
---
[01:10:46] failures:
[01:10:46] 
[01:10:46] ---- [ui] ui/issues/issue-18986.rs stdout ----
[01:10:46] 
[01:10:46] error: aux-build `/checkout/src/test/ui/issues/auxiliary/use-from-trait-xc.rs` source not found
[01:10:46] thread '[ui] ui/issues/issue-18986.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:10:46] 
[01:10:46] ---- [ui] ui/issues/issue-56411.rs stdout ----
[01:10:46] 
[01:10:46] 
[01:10:46] error: aux-build `/checkout/src/test/ui/issues/auxiliary/issue-56411-aux.rs` source not found
[01:10:46] thread '[ui] ui/issues/issue-56411.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:10:46] 
[01:10:46] failures:
[01:10:46]     [ui] ui/issues/issue-18986.rs
[01:10:46]     [ui] ui/issues/issue-56411.rs
[01:10:46]     [ui] ui/issues/issue-56411.rs
[01:10:46] 
[01:10:46] test result: FAILED. 5424 passed; 2 failed; 22 ignored; 0 measured; 0 filtered out
[01:10:46] 
[01:10:46] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:10:46] 
[01:10:46] 
[01:10:46] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:10:46] 
[01:10:46] 
[01:10:46] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:10:46] Build completed unsuccessfully in 0:04:13
[01:10:46] Build completed unsuccessfully in 0:04:13
[01:10:46] Makefile:48: recipe for target 'check' failed
[01:10:46] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1b0ca550
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Mar 12 03:50:18 UTC 2019
---
travis_time:end:08ab29d7:start=1552362619595006212,finish=1552362619602356295,duration=7350083
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:05aac2d8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0e9bad94
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-03-12T06:10:49Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:02b7ddc3:start=1552366181588906449,finish=1552366183827518846,duration=2238612397
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[01:17:51] .........................iiiii...................................................................... 1100/5448
[01:17:54] .................................................................................................... 1200/5448
[01:17:57] .................................................................................................... 1300/5448
[01:18:00] .................................................................................................... 1400/5448
[01:18:01] ERROR 2019-03-12T06:07:56Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/auxiliary/pub_and_stability.rs` source not found"
[01:18:03] ........................F........................................................................... 1500/5448
[01:18:09] ..............................i..................................................................... 1700/5448
[01:18:13] .................................................................................................... 1800/5448
[01:18:18] .................................................................................................... 1900/5448
[01:18:21] .................................................................................................... 2000/5448
[01:18:21] .................................................................................................... 2000/5448
[01:18:25] .........................................................i.......................................... 2100/5448
[01:18:27] ERROR 2019-03-12T06:08:22Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/issues/auxiliary/use-from-trait-xc.rs` source not found"
[01:18:29] .......................................F............................................................ 2200/5448
[01:18:38] .................................................................................................... 2400/5448
[01:18:43] .................................................................................................... 2500/5448
[01:18:47] .................................................................................................... 2600/5448
[01:18:51] .................................................................................................... 2700/5448
[01:18:51] .................................................................................................... 2700/5448
[01:18:56] .................................................................................................... 2800/5448
[01:19:00] .................................................................................................... 2900/5448
[01:19:02] ERROR 2019-03-12T06:08:57Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/issues/auxiliary/issue-56411-aux.rs` source not found"
[01:19:05] ..................................F................................................................. 3000/5448
[01:19:08] .................................................................................................... 3100/5448
[01:19:11] ERROR 2019-03-12T06:09:07Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/lint/auxiliary/stability-cfg2.rs` source not found"
[01:19:12] ERROR 2019-03-12T06:09:07Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/lint/auxiliary/stability-cfg2.rs` source not found"
[01:19:13] ........................................................................F......F.................... 3200/5448
[01:19:21] .................................................................................................... 3400/5448
[01:19:25] ................................................ii...i..ii.......................................... 3500/5448
[01:19:29] .................................................................................................... 3600/5448
[01:19:33] .................................................................................................... 3700/5448
[01:19:33] .................................................................................................... 3700/5448
[01:19:37] ..........................................................ii........................................ 3800/5448
[01:19:38] ERROR 2019-03-12T06:09:33Z: compiletest::runtest: fatal error, panic: "aux-build `/checkout/src/test/ui/auxiliary/orphan_check_diagnostics.rs` source not found"
[01:19:40] .............F..............................................................i....................... 3900/5448
[01:19:44] ..................................i................................................................. 4100/5448
[01:19:48] .................................................................................................... 4200/5448
[01:20:01] .................................................................................................... 4300/5448
[01:20:05] .................................................................................................... 4400/5448
---
[01:20:48] failures:
[01:20:48] 
[01:20:48] ---- [ui] ui/explore-issue-38412.rs stdout ----
[01:20:48] 
[01:20:48] error: aux-build `/checkout/src/test/ui/auxiliary/pub_and_stability.rs` source not found
[01:20:48] thread '[ui] ui/explore-issue-38412.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:20:48] 
[01:20:48] ---- [ui] ui/issues/issue-18986.rs stdout ----
[01:20:48] 
[01:20:48] 
[01:20:48] error: aux-build `/checkout/src/test/ui/issues/auxiliary/use-from-trait-xc.rs` source not found
[01:20:48] thread '[ui] ui/issues/issue-18986.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:20:48] ---- [ui] ui/issues/issue-56411.rs stdout ----
[01:20:48] 
[01:20:48] 
[01:20:48] error: aux-build `/checkout/src/test/ui/issues/auxiliary/issue-56411-aux.rs` source not found
[01:20:48] thread '[ui] ui/issues/issue-56411.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:20:48] ---- [ui] ui/lint/lint-stability-deprecated.rs stdout ----
[01:20:48] 
[01:20:48] 
[01:20:48] error: aux-build `/checkout/src/test/ui/lint/auxiliary/stability-cfg2.rs` source not found
[01:20:48] thread '[ui] ui/lint/lint-stability-deprecated.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:20:48] ---- [ui] ui/lint/lint-stability.rs stdout ----
[01:20:48] 
[01:20:48] 
[01:20:48] error: aux-build `/checkout/src/test/ui/lint/auxiliary/stability-cfg2.rs` source not found
[01:20:48] thread '[ui] ui/lint/lint-stability.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:20:48] ---- [ui] ui/orphan-check-diagnostics.rs stdout ----
[01:20:48] 
[01:20:48] 
[01:20:48] error: aux-build `/checkout/src/test/ui/auxiliary/orphan_check_diagnostics.rs` source not found
[01:20:48] thread '[ui] ui/orphan-check-diagnostics.rs' panicked at 'fatal error', src/tools/compiletest/src/runtest.rs:2040:9
[01:20:48] 
[01:20:48] failures:
[01:20:48]     [ui] ui/explore-issue-38412.rs
[01:20:48]     [ui] ui/issues/issue-18986.rs
---
[01:20:48] 
[01:20:48] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:20:48] 
[01:20:48] 
[01:20:48] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:20:48] 
[01:20:48] 
[01:20:48] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:20:48] Build completed unsuccessfully in 0:04:45
[01:20:48] Build completed unsuccessfully in 0:04:45
[01:20:48] Makefile:48: recipe for target 'check' failed
[01:20:48] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:2c14ac13
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Mar 12 06:10:43 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

petrochenkov · 2019-03-12T06:49:36Z

The issues directories in run-pass and ui test suites were created to reduce number of tests in a single directory and avoid e.g. issues with GitHub displaying the file list.
So they are rather necessary evil than something that other tests suits have to be consistent with.

The end goal for the issues directories is to not exist at all, with individual tests moved to their language-feature-specific subdirectories.

estebank · 2019-03-12T17:47:23Z

The only thing I'd add to what @petrochenkov said is that having issue-* files should be reserved for actual bugs, be only regression tests for a specific case, while more general things/regression tests for features should have an actual name in the file that is descriptive.

alexreg · 2019-03-12T17:54:17Z

Sounds fair enough. Since that may not happen for a while though, and will take a fair bit of effort, I think this is a good stop-gap solution.

petrochenkov · 2019-03-12T19:02:19Z

A stop-gap solution shouldn't go into the opposite direction from the end goal, IMO.

rust-highfive · 2019-03-12T19:09:09Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:2e95471f:start=1552413317894481996,finish=1552413320200390527,duration=2305908531
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
Setting environment variables from .travis.yml
---
[01:11:44] .................................................................................................... 2600/5449
[01:11:48] .................................................................................................... 2700/5449
[01:11:53] .................................................................................................... 2800/5449
[01:11:57] .................................................................................................... 2900/5449
[01:12:01] .......................................F............................................................ 3000/5449
[01:12:08] .................................................................................................... 3200/5449
[01:12:12] ..........................................................................i......................... 3300/5449
[01:12:15] .................................................................................................... 3400/5449
[01:12:19] ................................................ii...i..ii.......................................... 3500/5449
---
[01:13:19] .................................................................................................... 5000/5449
[01:13:22] .................................................................................................... 5100/5449
[01:13:26] .................................................................................................... 5200/5449
[01:13:28] .................................................................................................... 5300/5449
[01:13:31] .............................................F.........................................i............ 5400/5449
[01:13:33] failures:
[01:13:33] 
[01:13:33] ---- [ui] ui/issues/issue-56411.rs stdout ----
[01:13:33] diff of stderr:
[01:13:33] diff of stderr:
[01:13:33] 
[01:13:33] - error[E0255]: the name `issue_56411_aux` is defined multiple times
[01:13:33] -   --> $DIR/issue-56411.rs:7:21
[01:13:33] + error[E0583]: file not found for module `issue_56411_aux`
[01:13:33] 3    |
[01:13:33] 3    |
[01:13:33] - LL |             mod $name;
[01:13:33] -    |             ---------- previous definition of the module `issue_56411_aux` here
[01:13:33] - LL |             pub use self::$name;
[01:13:33] -    |                     |
[01:13:33] -    |                     |
[01:13:33] -    |                     `issue_56411_aux` reimported here
[01:13:33] - ...
[01:13:33] - ...
[01:13:33] 12 LL | import!(issue_56411_aux);
[01:13:33] -    | ------------------------- in this macro invocation
[01:13:33] 14    |
[01:13:33] 14    |
[01:13:33] -    = note: `issue_56411_aux` must be defined only once in the type namespace of this module
[01:13:33] +    = help: name the file either issue_56411_aux.rs or issue_56411_aux/mod.rs inside the directory "$DIR"
[01:13:33] 16 
[01:13:33] - error[E0365]: `issue_56411_aux` is private, and cannot be re-exported
[01:13:33] -    |
[01:13:33] -    |
[01:13:33] - LL |             pub use self::$name;
[01:13:33] -    |                     ^^^^^^^^^^^ re-export of private `issue_56411_aux`
[01:13:33] - ...
[01:13:33] - LL | import!(issue_56411_aux);
[01:13:33] -    | ------------------------- in this macro invocation
[01:13:33] -    |
[01:13:33] -    = note: consider declaring type or module `issue_56411_aux` with `pub`
[01:13:33] + error: aborting due to previous error
[01:13:33] - error: aborting due to 2 previous errors
[01:13:33] - 
[01:13:33] - Some errors occurred: E0255, E0365.
[01:13:33] - For more information about an error, try `rustc --explain E0255`.
[01:13:33] - For more information about an error, try `rustc --explain E0255`.
[01:13:33] + For more information about this error, try `rustc --explain E0583`.
[01:13:33] 32 
[01:13:33] 
[01:13:33] 
[01:13:33] The actual stderr differed from the expected stderr.
[01:13:33] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-56411/issue-56411.stderr
[01:13:33] To update references, rerun the tests and pass the `--bless` flag
[01:13:33] To only update this specific test, also pass `--test-args issues/issue-56411.rs`
[01:13:33] error: 1 errors occurred comparing output.
[01:13:33] status: exit code: 1
[01:13:33] status: exit code: 1
[01:13:33] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-56411.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-56411/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-56411/auxiliary" "-A" "unused"
[01:13:33] ------------------------------------------
[01:13:33] 
[01:13:33] ------------------------------------------
[01:13:33] stderr:
[01:13:33] stderr:
[01:13:33] ------------------------------------------
[01:13:33] {"message":"file not found for module `issue_56411_aux`","code":{"code":"E0583","explanation":"\nA file wasn't found for an out-of-line module.\n\nErroneous code example:\n\n```ignore (compile_fail not working here; see Issue #43707)\nmod file_that_doesnt_exist; // error: file not found for module\n\nfn main() {}\n```\n\nPlease be sure that a file corresponding to the module exists. If you\nwant to use a module named `file_that_doesnt_exist`, you need to have a file\nnamed `file_that_doesnt_exist.rs` or `file_that_doesnt_exist/mod.rs` in the\nsame directory.\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/issues/issue-56411.rs","byte_start":336,"byte_end":351,"line_start":15,"line_end":15,"column_start":9,"column_end":24,"is_primary":true,"text":[{"text":"import!(issue_56411_aux);","highlight_start":9,"highlight_end":24}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"name the file either issue_56411_aux.rs or issue_56411_aux/mod.rs inside the directory \"/checkout/src/test/ui/issues\"","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0583]: file not found for module `issue_56411_aux`\n  --> /checkout/src/test/ui/issues/issue-56411.rs:15:9\n   |\nLL | import!(issue_56411_aux);\n   |         ^^^^^^^^^^^^^^^\n   |\n   = help: name the file either issue_56411_aux.rs or issue_56411_aux/mod.rs inside the directory \"/checkout/src/test/ui/issues\"\n\n"}
[01:13:33] {"message":"For more information about this error, try `rustc --explain E0583`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0583`.\n"}
[01:13:33] 
[01:13:33] ------------------------------------------
[01:13:33] 
---
[01:13:33] 54 error: unused doc comment
[01:13:33] -   --> $DIR/useless_comment.rs:28:5
[01:13:33] +   --> $DIR/useless-comment.rs:28:5
[01:13:33] 56    |
[01:13:33] 57 LL |     #[doc = "foo"]
[01:13:33] 
[01:13:33] 61    |     - rustdoc does not generate documentation for expressions
[01:13:33] 62 
[01:13:33] 63 error: unused doc comment
[01:13:33] 63 error: unused doc comment
[01:13:33] -   --> $DIR/useless_comment.rs:29:5
[01:13:33] +   --> $DIR/useless-comment.rs:29:5
[01:13:33] 65    |
[01:13:33] 66 LL |     #[doc = "bar"]
[01:13:33] 
[01:13:33] 69    |     - rustdoc does not generate documentation for expressions
[01:13:33] 70 
[01:13:33] 71 error: unused doc comment
---
[01:13:33] 81 error: unused doc comment
[01:13:33] -   --> $DIR/useless_comment.rs:35:13
[01:13:33] +   --> $DIR/useless-comment.rs:35:13
[01:13:33] 83    |
[01:13:33] 84 LL |     let x = /** comment */ 47;
[01:13:33] 85    |             ^^^^^^^^^^^^^^ -- rustdoc does not generate documentation for expressions
[01:13:33] 86 
[01:13:33] 87 error: unused doc comment
[01:13:33] -   --> $DIR/useless_comment.rs:37:5
[01:13:33] +   --> $DIR/useless-comment.rs:37:5
[01:13:33] +   --> $DIR/useless-comment.rs:37:5
[01:13:33] 89    |
[01:13:33] 90 LL |       /// dox
[01:13:33] 91    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:13:33] 
[01:13:33] 
[01:13:33] The actual stderr differed from the expected stderr.
[01:13:33] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/useless-comment/useless-comment.stderr
[01:13:33] To update references, rerun the tests and pass the `--bless` flag
[01:13:33] To only update this specific test, also pass `--test-args useless-comment.rs`
[01:13:33] error: 1 errors occurred comparing output.
[01:13:33] status: exit code: 1
[01:13:33] status: exit code: 1
[01:13:33] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/useless-comment.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/useless-comment/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/useless-comment/auxiliary" "-A" "unused"
[01:13:33] ------------------------------------------
[01:13:33] 
[01:13:33] ------------------------------------------
[01:13:33] stderr:
[01:13:33] stderr:
[01:13:33] ------------------------------------------
[01:13:33] {"message":"unused doc comment","code":{"code":"unused_doc_comments","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":138,"byte_end":145,"line_start":10,"line_end":10,"column_start":1,"column_end":8,"is_primary":false,"text":[{"text":"mac!();","highlight_start":1,"highlight_end":8}],"label":"rustdoc does not generate documentation for macro expansions","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":101,"byte_end":137,"line_start":9,"line_end":9,"column_start":1,"column_end":37,"is_primary":true,"text":[{"text":"/// foo //~ ERROR unused doc comment","highlight_start":1,"highlight_end":37}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"lint level defined here","code":null,"level":"note","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":43,"byte_end":62,"line_start":3,"line_end":3,"column_start":9,"column_end":28,"is_primary":true,"text":[{"text":"#![deny(unused_doc_comments)]","highlight_start":9,"highlight_end":28}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":null},{"message":"to document an item produced by a macro, the macro must produce the documentation as part of its expansion","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: unused doc comment\n  --> /checkout/src/test/ui/useless-comment.rs:9:1\n   |\nLL | /// foo //~ ERROR unused doc comment\n   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nLL | mac!();\n   | ------- rustdoc does not generate documentation for macro expansions\n   |\nnote: lint level defined here\n  --> /checkout/src/test/ui/useless-comment.rs:3:9\n   |\nLL | #![deny(unused_doc_comments)]\n   |         ^^^^^^^^^^^^^^^^^^^\n   = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion\n\n"}
[01:13:33] {"message":"unused doc comment","code":{"code":"unused_doc_comments","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":201,"byte_end":212,"line_start":14,"line_end":14,"column_start":5,"column_end":16,"is_primary":false,"text":[{"text":"    let x = 12;","highlight_start":5,"highlight_end":16}],"label":"rustdoc does not generate documentation for statements","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":162,"byte_end":196,"line_start":13,"line_end":13,"column_start":5,"column_end":39,"is_primary":true,"text":[{"text":"    /// a //~ ERROR unused doc comment","highlight_start":5,"highlight_end":39}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused doc comment\n  --> /checkout/src/test/ui/useless-comment.rs:13:5\n   |\nLL |     /// a //~ ERROR unused doc comment\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nLL |     let x = 12;\n   |     ----------- rustdoc does not generate documentation for statements\n\n"}
[01:13:33] {"message":"unused doc comment","code":{"code":"unused_doc_comments","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":303,"byte_end":394,"line_start":19,"line_end":23,"column_start":5,"column_end":6,"is_primary":false,"text":[{"text":"    match x {","highlight_start":5,"highlight_end":14},{"text":"        /// c //~ ERROR unused doc comment","highlight_start":1,"highlight_end":43},{"text":"        1 => {},","highlight_start":1,"highlight_end":17},{"text":"        _ => {}","highlight_start":1,"highlight_end":16},{"text":"    }","highlight_start":1,"highlight_end":6}],"label":"rustdoc does not generate documentation for expressions","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":218,"byte_end":298,"line_start":16,"line_end":18,"column_start":5,"column_end":23,"is_primary":true,"text":[{"text":"    /// multi-line //~ unused doc comment","highlight_start":5,"highlight_end":42},{"text":"    /// doc comment","highlight_start":1,"highlight_end":20},{"text":"    /// that is unused","highlight_start":1,"highlight_end":23}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused doc comment\n  --> /checkout/src/test/ui/useless-comment.rs:16:5\n   |\nLL | /     /// multi-line //~ unused doc comment\nLL | |     /// doc comment\nLL | |     /// that is unused\n   | |______________________^\nLL | /     match x {\nLL | |         /// c //~ ERROR unused doc comment\nLL | |         1 => {},\nLL | |         _ => {}\nLL | |     }\n   | |_____- rustdoc does not generate documentation for expressions\n\n"}
[01:13:33] {"message":"unused doc comment","code":{"code":"unused_doc_comments","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":364,"byte_end":371,"line_start":21,"line_end":21,"column_start":9,"column_end":16,"is_primary":false,"text":[{"text":"        1 => {},","highlight_start":9,"highlight_end":16}],"label":"rustdoc does not generate documentation for match arms","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":321,"byte_end":355,"line_start":20,"line_end":20,"column_start":9,"column_end":43,"is_primary":true,"text":[{"text":"        /// c //~ ERROR unused doc comment","highlight_start":9,"highlight_end":43}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused doc comment\n  --> /checkout/src/test/ui/useless-comment.rs:20:9\n   |\nLL |         /// c //~ ERROR unused doc comment\n   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nLL |         1 => {},\n   |         ------- rustdoc does not generate documentation for match arms\n\n"}
[01:13:33] {"message":"unused doc comment","code":{"code":"unused_doc_comments","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":441,"byte_end":450,"line_start":26,"line_end":26,"column_start":5,"column_end":14,"is_primary":false,"text":[{"text":"    unsafe {}","highlight_start":5,"highlight_end":14}],"label":"rustdoc does not generate documentation for expressions","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":400,"byte_end":436,"line_start":25,"line_end":25,"column_start":5,"column_end":41,"is_primary":true,"text":[{"text":"    /// foo //~ ERROR unused doc comment","highlight_start":5,"highlight_end":41}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused doc comment\n  --> /checkout/src/test/ui/useless-comment.rs:25:5\n   |\nLL |     /// foo //~ ERROR unused doc comment\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nLL |     unsafe {}\n   |     --------- rustdoc does not generate documentation for expressions\n\n"}
[01:13:33] {"message":"unused doc comment","code":{"code":"unused_doc_comments","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":552,"byte_end":553,"line_start":30,"line_end":30,"column_start":5,"column_end":6,"is_primary":false,"text":[{"text":"    3;","highlight_start":5,"highlight_end":6}],"label":"rustdoc does not generate documentation for expressions","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":456,"byte_end":470,"line_start":28,"line_end":28,"column_start":5,"column_end":19,"is_primary":true,"text":[{"text":"    #[doc = \"foo\"] //~ ERROR unused doc comment","highlight_start":5,"highlight_end":19}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused doc comment\n  --> /checkout/src/test/ui/useless-comment.rs:28:5\n   |\nLL |     #[doc = \"foo\"] //~ ERROR unused doc comment\n   |     ^^^^^^^^^^^^^^\nLL |     #[doc = \"bar\"] //~ ERROR unused doc comment\nLL |     3;\n   |     - rustdoc does not generate documentation for expressions\n\n"}
[01:13:33] {"message":"unused doc comment","code":{"code":"unused_doc_comments","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":552,"byte_end":553,"line_start":30,"line_end":30,"column_start":5,"column_end":6,"is_primary":false,"text":[{"text":"    3;","highlight_start":5,"highlight_end":6}],"label":"rustdoc does not generate documentation for expressions","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":504,"byte_end":518,"line_start":29,"line_end":29,"column_start":5,"column_end":19,"is_primary":true,"text":[{"text":"    #[doc = \"bar\"] //~ ERROR unused doc comment","highlight_start":5,"highlight_end":19}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused doc comment\n  --> /checkout/src/test/ui/useless-comment.rs:29:5\n   |\nLL |     #[doc = \"bar\"] //~ ERROR unused doc comment\n   |     ^^^^^^^^^^^^^^\nLL |     3;\n   |     - rustdoc does not generate documentation for expressions\n\n"}
[01:13:33] {"message":"unused doc comment","code":{"code":"unused_doc_comments","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":601,"byte_end":608,"line_start":33,"line_end":33,"column_start":5,"column_end":12,"is_primary":false,"text":[{"text":"    mac!();","highlight_start":5,"highlight_end":12}],"label":"rustdoc does not generate documentation for macro expansions","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":560,"byte_end":596,"line_start":32,"line_end":32,"column_start":5,"column_end":41,"is_primary":true,"text":[{"text":"    /// bar //~ ERROR unused doc comment","highlight_start":5,"highlight_end":41}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"to document an item produced by a macro, the macro must produce the documentation as part of its expansion","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error: unused doc comment\n  --> /checkout/src/test/ui/useless-comment.rs:32:5\n   |\nLL |     /// bar //~ ERROR unused doc comment\n   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nLL |     mac!();\n   |     ------- rustdoc does not generate documentation for macro expansions\n   |\n   = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion\n\n"}
[01:13:33] {"message":"unused doc comment","code":{"code":"unused_doc_comments","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":637,"byte_end":639,"line_start":35,"line_end":35,"column_start":28,"column_end":30,"is_primary":false,"text":[{"text":"    let x = /** comment */ 47; //~ ERROR unused doc comment","highlight_start":28,"highlight_end":30}],"label":"rustdoc does not generate documentation for expressions","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":622,"byte_end":636,"line_start":35,"line_end":35,"column_start":13,"column_end":27,"is_primary":true,"text":[{"text":"    let x = /** comment */ 47; //~ ERROR unused doc comment","highlight_start":13,"highlight_end":27}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused doc comment\n  --> /checkout/src/test/ui/useless-comment.rs:35:13\n   |\nLL |     let x = /** comment */ 47; //~ ERROR unused doc comment\n   |             ^^^^^^^^^^^^^^ -- rustdoc does not generate documentation for expressions\n\n"}
[01:13:33] {"message":"unused doc comment","code":{"code":"unused_doc_comments","explanation":null},"level":"error","spans":[{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":716,"byte_end":724,"line_start":38,"line_end":40,"column_start":5,"column_end":6,"is_primary":false,"text":[{"text":"    {","highlight_start":5,"highlight_end":6},{"text":"","highlight_start":1,"highlight_end":1},{"text":"    }","highlight_start":1,"highlight_end":6}],"label":"rustdoc does not generate documentation for expressions","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"/checkout/src/test/ui/useless-comment.rs","byte_start":675,"byte_end":711,"line_start":37,"line_end":37,"column_start":5,"column_end":41,"is_primary":true,"text":[{"text":"    /// dox //~ ERROR unused doc comment","highlight_start":5,"highlight_end":41}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: unused doc comment\n  --> /checkout/src/test/ui/useless-comment.rs:37:5\n   |\nLL |       /// dox //~ ERROR unused doc comment\n   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nLL | /     {\nLL | |\nLL | |     }\n   | |_____- rustdoc does not generate documentation for expressions\n\n"}
[01:13:33] 
[01:13:33] ------------------------------------------
[01:13:33] 
[01:13:33] thread '[ui] ui/useless-comment.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:3301:9
---
[01:13:33] 
[01:13:33] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:496:22
[01:13:33] 
[01:13:33] 
[01:13:33] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:13:33] 
[01:13:33] 
[01:13:33] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:13:33] Build completed unsuccessfully in 0:04:18
[01:13:33] Build completed unsuccessfully in 0:04:18
[01:13:33] Makefile:48: recipe for target 'check' failed
[01:13:33] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0423adc8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue Mar 12 19:09:04 UTC 2019
Tue Mar 12 19:09:04 UTC 2019
Tue, 12 Mar 2019 19:09:04 GMT
travis_time:end:0423adc8:start=1552417744271401236,finish=1552417744440791502,duration=169390266
The command "date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
" exited with 0.
travis_fold:start:after_failure.1
tstrap/debug/incremental/bootstrap-5f86g9tk67ex/s-faa8wmxmhr-1fl2x2g-1qbirucj30d8p
138800 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release
138588 ./obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/release
135920 ./obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps
123628 ./src/llvm-project/llvm/test/CodeGen

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

varkor · 2019-03-12T19:15:05Z

I also don't think this is going in the right direction. There's nothing per se that relates any of the issue-#### tests: they have similar names simply because it's a canonical naming scheme for tests without better names. I'm all for tests being given more descriptive names, but only tests that are related should be grouped by directory like this.

Centril · 2019-03-12T19:22:27Z

I do think this is an improvement and I do think it advances @petrochenkov's goal (which I agree with) of:

The end goal for the issues directories is to not exist at all, with individual tests moved to their language-feature-specific subdirectories.

Specifically, what I like about this PR is not consistency but that it reduces the amount of files that are directly in compile-XX. Having fewer files there is better organization and makes it easier to navigate.

alexreg · 2019-03-12T19:26:37Z

@Centril Yeah, consistency was only one goal: decluttering the directories like compile-X and run-Z and ui is another big one. I'll update the description accordingly, since that was very much part of my motivation too. :-)

petrochenkov · 2019-03-12T19:49:57Z

foo_bar.rs -> foo-bar.rs is ok (that's the overwhelmingly prevailing convention).

ui/issue-N.rs -> ui/issues/issue-N.rs and run-pass/issue-N.rs -> run-pass/issues/issue-N.rs, is ok since the issues directories already exist in ui/run-pass, but it would be much more useful to classify them into the feature directories instead.

cc @QuietMisdreavus for the rustdoc changes, not sure about them.

Other changes are unnecessary churn, IMO. Other test suites are already small (so the GitHub display problem is not relevant for them), and tests from compile-fail in particular should be moved to UI (after fixing the blocking issues), rather than moved around.
As was noticed, grouping with issues is not semantic, so by itself it's no more useful than, e.g. grouping issues starting with a into a directory named a.

alexreg · 2019-03-13T05:55:46Z

@bors r=estebank p=1

bors · 2019-03-13T05:55:47Z

📌 Commit 44658ad3b75c63ab9fbcade376b4c783d4bb8d80 has been approved by estebank

bors · 2019-03-13T06:18:51Z

⌛ Testing commit 44658ad3b75c63ab9fbcade376b4c783d4bb8d80 with merge de1bbdb996703d26d6ccdc3f85b74bc48f4dd768...

petrochenkov · 2019-03-13T06:47:30Z

@bors r-

@alexreg, please do not abuse r+ rights

alexreg · 2019-03-13T14:14:31Z

Huh? I'd been given the go-ahead to do r=estebank. I admittedly should have waited until CI passed, but I had to leave, and tests were passing locally, so...

varkor · 2019-03-13T14:35:28Z

Huh? I'd been given the go-ahead to do r=estebank.

The point was that since the review approval was given, additional points of discussion have been raised for which there's not a clear consensus yet, and triggering bors is effectively choosing to ignore that.

petrochenkov · 2019-03-13T18:42:55Z

@alexreg
LGTM now.
Could you squash the commits to avoid affecting the history?

alexreg · 2019-03-13T21:10:08Z

@varkor r+?

varkor · 2019-03-13T21:24:14Z

@bors r+

bors · 2019-03-13T21:24:15Z

📌 Commit 84fc24fa14961a05ddf3a2279e53f1e988e4c754 has been approved by varkor

bors · 2019-03-13T21:58:45Z

⌛ Testing commit 84fc24fa14961a05ddf3a2279e53f1e988e4c754 with merge b4f102e6dfed6d6d015b63c7c867b303bb8c0bed...

bors · 2019-03-13T23:35:45Z

💔 Test failed - status-appveyor

estebank · 2019-03-13T23:40:56Z

error[E0583]: file not found for module `issue_12590_b`
 --> C:\projects\rust\src/test\pretty\issue-12590-c.rs:7:5
  |
7 | mod issue_12590_b;
  |     ^^^^^^^^^^^^^
  |
  = help: name the file either issue_12590_b.rs or issue_12590_b\mod.rs inside the directory "C:\projects\rust\src/test\pretty"
error: aborting due to previous error
For more information about this error, try `rustc --explain E0583`.

failures:
    [pretty] pretty\issue-12590-a.rs
    [pretty] pretty\issue-12590-c.rs
test result: FAILED. 51 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

alexreg · 2019-03-14T01:01:14Z

@estebank Thanks. I wonder how that got through my local tests and CI...

@bors r=varkor

bors · 2019-03-14T01:01:14Z

📌 Commit fe30743 has been approved by varkor

bors · 2019-03-14T01:28:26Z

⌛ Testing commit fe30743 with merge 0ad3207...

@Centril

Moved issue tests to subdirs and normalised names Consistency, decluttering, ease of navigation :-) r? @Centril

bors · 2019-03-14T04:15:03Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: varkor
Pushing 0ad3207 to master...

rust-highfive assigned Centril Mar 12, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2019

rust-highfive assigned varkor and unassigned Centril Mar 12, 2019

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2019

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2019

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2019

bors mentioned this pull request Mar 13, 2019

Revert "Don't generate minification variable if minification disabled" #59158

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 13, 2019

Moved issue tests to subdirs and normalised names.

fe30743

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 14, 2019

bors added a commit that referenced this pull request Mar 14, 2019

Auto merge of #59120 - alexreg:move-issue-tests-1, r=varkor

0ad3207

Moved issue tests to subdirs and normalised names Consistency, decluttering, ease of navigation :-) r? @Centril

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 14, 2019

bors merged commit fe30743 into rust-lang:master Mar 14, 2019

This was referenced Mar 14, 2019

Add outlives suggestions for some lifetime errors #58281

Merged

Enable NLL migrate mode on the 2015 edition #59114

Merged

Uh oh!

Conversation

alexreg commented Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Centril commented Mar 12, 2019

Uh oh!

bors commented Mar 12, 2019

Uh oh!

estebank commented Mar 12, 2019

Uh oh!

rust-highfive commented Mar 12, 2019

Uh oh!

rust-highfive commented Mar 12, 2019

Uh oh!

rust-highfive commented Mar 12, 2019

Uh oh!

petrochenkov commented Mar 12, 2019

Uh oh!

estebank commented Mar 12, 2019

Uh oh!

This comment has been minimized.

alexreg commented Mar 12, 2019

Uh oh!

petrochenkov commented Mar 12, 2019

Uh oh!

rust-highfive commented Mar 12, 2019

Uh oh!

varkor commented Mar 12, 2019

Uh oh!

Centril commented Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexreg commented Mar 12, 2019

Uh oh!

petrochenkov commented Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

alexreg commented Mar 13, 2019

Uh oh!

bors commented Mar 13, 2019

Uh oh!

bors commented Mar 13, 2019

Uh oh!

petrochenkov commented Mar 13, 2019

Uh oh!

alexreg commented Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

varkor commented Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

petrochenkov commented Mar 13, 2019

Uh oh!

alexreg commented Mar 13, 2019

Uh oh!

varkor commented Mar 13, 2019

Uh oh!

bors commented Mar 13, 2019

Uh oh!

bors commented Mar 13, 2019

Uh oh!

bors commented Mar 13, 2019

Uh oh!

estebank commented Mar 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexreg commented Mar 14, 2019

Uh oh!

bors commented Mar 14, 2019

Uh oh!

bors commented Mar 14, 2019

Uh oh!

bors commented Mar 14, 2019

Uh oh!

Reviewers

alexreg commented Mar 12, 2019 •

edited

Loading

Centril commented Mar 12, 2019 •

edited

Loading

petrochenkov commented Mar 12, 2019 •

edited

Loading

alexreg commented Mar 13, 2019 •

edited

Loading

varkor commented Mar 13, 2019 •

edited

Loading

estebank commented Mar 13, 2019 •

edited

Loading