Refactor TypeVariableOrigin

[varkor]

Removes some unused variants and extracts the common Span field.

As suggested in #59008 (comment).

r? @eddyb

[varkor]

Another question is whether we want to refractor the region origin enum in this way, although it'd probably involve adding dummy spans for whichever variants currently don't have them.

[nikomatsakis]

seems good to me -- I prefer this to a pair

[varkor]

@eddyb: I've refactored ConstVariableOrigin as well. The remaining question is whether RegionVariableOrigin should be similarly refactored.

[eddyb]

@bors r+

[bors]

📌 Commit 9a6da07507506fdd5ad9e4aeaca54e57c8df0fbc has been approved by eddyb

[bors]

⌛ Testing commit 9a6da07507506fdd5ad9e4aeaca54e57c8df0fbc with merge 0437440529f34ba7da7152d255e6ecd50599ce2a...

[bors]

💔 Test failed - checks-travis

[rust-highfive]

The job armhf-gnu of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:07:38]    Compiling syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
[00:07:41] error[E0433]: failed to resolve: use of undeclared type or module `TypeVariableOrigin`
[00:07:41]    --> src/librustc/infer/error_reporting/need_type_info.rs:125:24
[00:07:41]     |
[00:07:41] 125 |                 if let TypeVariableOrigin::TypeParameterDefinition(_, name) =
[00:07:41]     |                        ^^^^^^^^^^^^^^^^^^ use of undeclared type or module `TypeVariableOrigin`
[00:08:07] [RUSTC-TIMING] syntax_ext test:false 28.771
[00:08:11] error: aborting due to previous error
[00:08:11] 
[00:08:11] For more information about this error, try `rustc --explain E0433`.
---
travis_time:end:1f58dc20:start=1559738752451478294,finish=1559738752460398688,duration=8920394
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0267cdd2
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:178392a8
travis_time:start:178392a8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0d225eb7
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[varkor]

@bors r=eddyb

[bors]

📌 Commit 8577bb4 has been approved by eddyb

[varkor]

@bors r=eddyb

[bors]

📌 Commit 66b840c has been approved by eddyb

[bors]

⌛ Testing commit 66b840c with merge 0a8de479b588f24a85fe26658d9965724af95f02...

[bors]

💔 Test failed - checks-travis

[rust-highfive]

The job test-various of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:46:03] test time::tests::system_time_elapsed ... ok
[01:46:03] test time::tests::system_time_math ... ok
[01:46:04] test thread::tests::test_park_timeout_unpark_called_other_thread ... ok
[01:46:11] test sync::mpsc::tests::stress_recv_timeout_two_threads ... ok
[01:47:01] test process::tests::uid_works ... test process::tests::uid_works has been running for over 60 seconds
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[Centril]

@bors retry

[bors]

⌛ Testing commit 66b840c with merge 1bec46c...

[bors]

☀️ Test successful - checks-travis, status-appveyor
Approved by: eddyb
Pushing 1bec46c to master...