Skip to content

Update clippy#59965

Merged
bors merged 1 commit intorust-lang:masterfrom
Manishearth:clippyup
Apr 15, 2019
Merged

Update clippy#59965
bors merged 1 commit intorust-lang:masterfrom
Manishearth:clippyup

Conversation

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 14, 2019

One of our tests using the alloc crate broke because alloc was stabilized.

r? @oli-obk

@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 14, 2019

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2019
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Apr 14, 2019

Clippy broke again in the meantime: #59967 (comment)

@Manishearth
Copy link
Member Author

Manishearth commented Apr 14, 2019

Ah, more HirIDfication

@Manishearth
Copy link
Member Author

Manishearth commented Apr 14, 2019

(I'm on it)

@Manishearth
Copy link
Member Author

Manishearth commented Apr 14, 2019

rust-lang/rust-clippy#3961

@Manishearth
Copy link
Member Author

Manishearth commented Apr 14, 2019

Updated. r? anyone?

@Xanewok
Copy link
Contributor

Xanewok commented Apr 14, 2019

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Apr 14, 2019

📌 Commit feaf2ae has been approved by Xanewok

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 14, 2019
@bors
Copy link
Collaborator

bors commented Apr 14, 2019

⌛ Testing commit feaf2ae with merge 11ea66fa9edb031147b255f9e30a825b076253d2...

@bors
Copy link
Collaborator

bors commented Apr 14, 2019

⌛ Testing commit feaf2ae with merge c090ab4...

bors added a commit that referenced this pull request Apr 14, 2019
@bors
Auto merge of #59965 - Manishearth:clippyup, r=Xanewok
c090ab4 
Update clippy

One of our tests using the alloc crate broke because alloc was stabilized.

r? @oli-obk
@bors
Copy link
Collaborator

bors commented Apr 15, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Xanewok
Pushing c090ab4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 15, 2019
@bors bors merged commit feaf2ae into rust-lang:master Apr 15, 2019
@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 15, 2019

📣 Toolstate changed by #59965!

Tested on commit c090ab4.
Direct link to PR: #59965

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Apr 15, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#59965!
b03113f 
Tested on commit rust-lang/rust@c090ab4.
Direct link to PR: <rust-lang/rust#59965>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 rls on windows: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @nrc @Xanewok, @rust-lang/infra).
@Xanewok Xanewok mentioned this pull request Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Manishearth @rust-highfive @matthiaskrgr @Xanewok @bors @oli-obk