[WIP] Use Into::into in operator ?

[cuviper]

#38751 proposes using into for ?, and while commenters suggested problems with inference, I couldn't find any evidence where this was actually attempted -- so here we go!

[rust-highfive]

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

[cuviper]

So yes, it did break inference in quite a few places in librustc itself -- mostly where type-inferred closures are involved using ? within and on their result. These are possible to annotate, as shown here in followup commits, but might be painful for the ecosystem. Maybe the compiler can do better about inferring the identity case? It seems like it must be doing that for From already.

In librustc_metadata, a stranger error arises:

error[E0277]: `?` couldn't convert the error to `!`
   --> src/librustc_metadata/encoder.rs:106:33
    |
106 |         self.emit_usize(seq.len)?;
    |                                 ^
    |                                 |
    |                                 the trait `std::convert::From<()>` is not implemented for `!`
    |                                 in this expansion of `desugaring of `?``
    |                                 in this macro invocation
    |
    = note: the trait is implemented for `()`. Possibly this error has been caused by changes to Rust's type-inference algorithm (see: https://github.com/rust-lang/rust/issues/48950 for more info). Consider whether you meant to use the type `()` here instead.
    = note: required because of the requirements on the impl of `std::convert::Into<!>` for `()`
    = note: required by `std::convert::Into::into`

rust/src/librustc_metadata/encoder.rs

Lines 104 to 112 in 6968e77

	impl<'a, 'tcx, T> SpecializedEncoder<LazySeq<T>> for EncodeContext<'a, 'tcx> {
	fn specialized_encode(&mut self, seq: &LazySeq<T>) -> Result<(), Self::Error> {
	self.emit_usize(seq.len)?;
	if seq.len == 0 {
	return Ok(());
	}
	self.emit_lazy_distance(seq.position, LazySeq::<T>::min_size(seq.len))
	}
	}

AFAICT it should be both getting and returning Self::Error -- which is ! -- so I'm not sure where () is coming from. Perhaps this is some lurking issue with the never type?

[cuviper]

I found the same From<()> error in the commit message of b2cf9a0 -- cc @SimonSapin. It does go away if I opt that crate into #![feature(never_type)], so I've done that now, if only as a workaround for testing purposes.

[cuviper]

Now that I have a green check mark, I'm moving to S-waiting-on-team to evaluate feasibility, please.

[Centril]

I'd like to a see a crater run to see what sort of breakage we are talking about.

[Centril]

@bors try

[bors]

⌛ Trying commit a96f3b2 with merge 4605628...

[estebank]

This is a huge ergonomic regression 😟

[Centril]

Personally I'm not too bothered by this as Ok(1)? instead of Some(1)? is a silly thing to do; I don't know why Ok(1)? works in the first place...

[cuviper]

I guess inference can tell that the only possible From for NoneError is the blanket identity impl<T> From<T> for T, versus now inferring some T: Into<NoneError>.

[bors]

💔 Test failed - checks-travis

[rust-highfive]

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:0e1ddec8
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
[01:45:07]    Compiling strsim v0.7.0
[01:45:08]    Compiling hex v0.3.2
[01:45:08]    Compiling ansi_term v0.11.0
[01:45:08] error[E0282]: type annotations needed
[01:45:08]   --> /cargo/registry/src/github.com-1ecc6299db9ec823/ansi_term-0.11.0/src/ansi.rs:30:39
[01:45:08]    |
[01:45:08] 29 |             let mut write_char = |c| {

[01:45:08]    |                 -------------- consider giving `write_char` a type
[01:45:08] 30 |                 if written_anything { write!(f, ";")?; }
[01:45:08]    |                                       ^^^^^^^^^^^^^^^
[01:45:08]    |                                       |
[01:45:08]    |                                       cannot infer type
[01:45:08]    |                                       cannot infer type
[01:45:08]    |                                       in this expansion of `desugaring of `?``
[01:45:08] 
[01:45:08] error: aborting due to previous error
[01:45:08] 
[01:45:08] For more information about this error, try `rustc --explain E0282`.
[01:45:08] For more information about this error, try `rustc --explain E0282`.
[01:45:08] error: Could not compile `ansi_term`.
[01:45:10] error: build failed
[01:45:10] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/cargo/Cargo.toml" "--features" "rustc-workspace-hack/all-static" "--message-format" "json"
[01:45:10] expected success, got: exit code: 101
[01:45:10] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
---
travis_time:end:00e5df01:start=1558129959406603950,finish=1558129959431110558,duration=24506608
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:11588250
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:18753af9
travis_time:start:18753af9
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0e41aa2a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[cuviper]

Yeah... I'm thinking this won't go anywhere unless we can improve inference.

If that's feasible, I'm willing to explore it, but I could use some pointers.

[bors]

☔ The latest upstream changes (presumably #60949) made this pull request unmergeable. Please resolve the merge conflicts.

[jonas-schievink]

Triage: Should we just close this? The required inference changes would probably need to be discussed by T-compiler outside of this issue, and might even need an RFC (it doesn't seem clear how these changes would even look like).

[Centril]

I would be interested in cratering this PR to see what the fuller outcome is.

[JohnCSimon]

Ping from triage @cuviper This PR looks like conflicts just need to be resolved.

[cuviper]

Triage: Should we just close this?

Yeah, that's fine. At least now we have rough experimental data for #38751.