Merged
Conversation
This is duplicated in a few locations throughout the sysroot to work around issues with not exporting a macro in libstd but still wanting it available to sysroot crates to define blocks. Nowadays though we can simply depend on the `cfg-if` crate on crates.io, allowing us to use it from there!
Once::new() has been a stable const fn for a while now. Closes rust-lang#61746
Changes: ```` Fix wrong lifetime of TyCtxt travis: Wait at most 30 minutes for base test Typos and minor grammar corrections Adds lint for integer division redundant_closure_for_method_calls fixes: lint does not trigger when there is a difference in mutability lint does not trigger when the method belongs to a trait which is not implemebted directly (Deref) Fix implicit_return docs rustup https://github.com/rust-lang/rust/pull/61758/files Remove wrong lifetime from LintContext Workaround for rust-lang/rustfmt#3615 Fixing eta with respect to lazy evaluation. ````
Handle index out of bound errors during const eval without panic Fix rust-lang#61595
…fackler std: Remove internal definitions of `cfg_if!` macro This is duplicated in a few locations throughout the sysroot to work around issues with not exporting a macro in libstd but still wanting it available to sysroot crates to define blocks. Nowadays though we can simply depend on the `cfg-if` crate on crates.io, allowing us to use it from there!
…xcrichton Deprecate ONCE_INIT in future 1.38 release Once::new() has been a stable const fn for a while now. Closes rust-lang#61746
submodules: update clippy from c0dbd34 to bd33a97 Changes: ```` Fix implicit_return docs rustup https://github.com/rust-lang/rust/pull/61758/files Remove wrong lifetime from LintContext Workaround for rust-lang/rustfmt#3615 Fixing eta with respect to lazy evaluation. ```` r? @oli-obk
…etrochenkov Small cleanup in `check_pat_path`
Contributor
Author
|
@bors r+ p=5 rollup=never |
Collaborator
|
📌 Commit 8917b8e has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Jun 13, 2019
Rollup of 5 pull requests Successful merges: - #61598 (Handle index out of bound errors during const eval without panic) - #61720 (std: Remove internal definitions of `cfg_if!` macro) - #61757 (Deprecate ONCE_INIT in future 1.38 release) - #61766 (submodules: update clippy from c0dbd34 to bd33a97) - #61791 (Small cleanup in `check_pat_path`) Failed merges: r? @ghost
Collaborator
|
☀️ Test successful - checks-travis, status-appveyor |
Contributor
|
📣 Toolstate changed by #61799! Tested on commit 57a3300. 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jun 13, 2019
Tested on commit rust-lang/rust@57a3300. Direct link to PR: <rust-lang/rust#61799> 🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
cfg_if!macro #61720 (std: Remove internal definitions ofcfg_if!macro)check_pat_path#61791 (Small cleanup incheck_pat_path)Failed merges:
r? @ghost